Commit Graph

61968 Commits

Author SHA1 Message Date
Ahtisham Shahid
87ef27166f fix: resolved bug in big blue button (#31023) 2022-09-20 22:01:04 +05:00
Zachary Hancock
2f3c93ed9f feat: sync with exam service on course publish (#31015)
Call into the exam service instead of the edx-proctoring plugin on course publish if the course_apps.exams_ida course waffle flag is enabled. This is an early step in moving away from edx-proctoring
2022-09-20 12:38:32 -04:00
bszabo
17b03388f5 Merge pull request #31021 from openedx/revert-30719-kdmccormick/github-in-reorganize
revert: Optimize and reorganize GitHub-hosted dependencies
2022-09-20 07:30:20 -04:00
Kyle McCormick
d8442484a0 Revert "docs: update & improve instructions for GitHub-hosted deps"
This reverts commit 8bb39fa6c7.
2022-09-20 06:35:46 -04:00
Kyle McCormick
6f7ceaf80b Revert "docs: remove section headers from github.in"
This reverts commit 7ed0e8d0e9.
2022-09-20 06:35:46 -04:00
Kyle McCormick
211aa9856a Revert "style: alphabetize GitHub-based dependencies"
This reverts commit 40158f5991.
2022-09-20 06:35:46 -04:00
Kyle McCormick
2ac7a6f774 Revert "build: install GitHub-hosted dependencies as wheels"
This reverts commit 6490f5b585.
2022-09-20 06:35:46 -04:00
Kyle McCormick
29cebb7f92 Revert "chore: Updating Python Requirements"
This reverts commit 6d00e4b320.
2022-09-20 06:35:46 -04:00
Kyle McCormick
8632193b8d Revert "build: fix -e . in requirements pins"
This reverts commit f42427a1f6.
2022-09-20 06:35:46 -04:00
Tim McCormack
f6965b9555 chore: Unpin edx-event-bus-kafka and upgrade (#30966)
The producer API is stable enough now.

Make use of new topic prefixing feature for devstack (introduced in 0.6.2)
2022-09-19 19:43:34 +00:00
Kyle McCormick
f42427a1f6 build: fix -e . in requirements pins
I would expect the post-pip-compile steps in `make upgrade`
to have taken care of chaninging `-e file://...`
into `-e .`, but it didn't for some reason.

Normally I would debug this, but
https://github.com/openedx/edx-platform/pull/30890
is going to merge in a week or two and it
will remove `-e .` from the requirement pins
entirely, so I'm just going to fix it manually for now.
2022-09-19 13:54:21 -04:00
edX requirements bot
6d00e4b320 chore: Updating Python Requirements 2022-09-19 13:54:21 -04:00
Kyle McCormick
6490f5b585 build: install GitHub-hosted dependencies as wheels
We update github.in to use the proper git-based depencency
format specified in the file comment. This format installs
a package as a pre-built wheel:

    git+https://github.com/...

instead of a development-mode editable requirement:

   -e https://github.com/...

Installing packages in editable mode increases the amount of time
it takes to install edx-platform  dependencies, increases the
resulting virtual environment's size, and installs packages in a
way that has several subtle differences compared to the way
wheels are installed:
https://setuptools.pypa.io/en/latest/userguide/development_mode.html#limitations
2022-09-19 13:54:21 -04:00
Kyle McCormick
40158f5991 style: alphabetize GitHub-based dependencies 2022-09-19 13:54:21 -04:00
Kyle McCormick
7ed0e8d0e9 docs: remove section headers from github.in
They give the impression that, for example,
third-party XBlocks belong in github.in.
In reality, GitHub-hosted requirements should be avoided
in all circumstances. Third-party XBlocks are best
added to base.in as a PyPI-hosted dependency.

Furthermore, the existing section headers are not
even being followed.
2022-09-19 13:54:21 -04:00
Kyle McCormick
8bb39fa6c7 docs: update & improve instructions for GitHub-hosted deps
They have fallen out of date since we switched from Jenkins-
run upgrades to GitHub Actions -run upgrades.
2022-09-19 13:54:21 -04:00
Robert Raposa
3f147335ca docs: enhance mobile JWT ADR (#30906)
As part of the implementation of this ADR, we determined that we needed
to make some of the endpoints that return JWTs able to produce
asymmetric JWTs as needed, since asymmetric JWTs are a requirement
in certain cases. This ADR update notes this additional consequence.
2022-09-19 12:23:59 -04:00
Moeez Zahid
2f098c54e6 fix: Youtube has highest default stream priority (#31014) 2022-09-19 20:31:42 +05:00
Sagirov Evgeniy
42246c858d feat!: remove code related to Old -> Split migration (#30955)
This commit removes code that was used to copy Old Mongo courses into
new Split Mongo courses. This includes both the migrate_to_split
management command, as well as the backend code that would be invoked
to re-run Old Mongo courses as Split courses using Studio (the UI for
this was already removed in b429e55c).

This is a part of the Old Mongo removal effort tracked in:
  https://github.com/openedx/public-engineering/issues/62
2022-09-19 10:51:40 -04:00
Maxwell Frank
76cee06850 Merge pull request #31008 from openedx/mfrank/update-cert-reqs
fix: update cert requirements
2022-09-19 09:07:49 -04:00
Sagirov Evgeniy
42438db805 feat: Remove the table with a migration (#30993) 2022-09-19 08:36:43 -04:00
Kshitij Sobti
a923cfc32e feat: Add mechanism to migrate discussion blocks to discussion flag (#30931)
The new mechanism for marking that a unit has discussions is to use the
discussion_enabled flag instead of adding a discussion block. This change
adds code that is run during the course rerun process to mark any existing
units that have a discussion block as discussible using the new mechanism.
It doesn't touch the existing discussion blocks.

If the new discussions configuration experience is globally enabled, this
will also switch from the legacy provider to the new provider. It analyses
the course for any discussion blocks that have been added to graded
subsections, and if that is the case, it also automatically enables
discussions in graded subsections (which are otherwise disabled for new
courses by default).
2022-09-19 16:56:50 +05:00
Sandeep Dubey
51b5e624b3 feat: upgrade TinyMCE v4.0.20 to TinyMCE v5.5.1 (#30335)
Co-authored-by: Arunmozhi <arunmozhi@opencraft.com>
2022-09-19 12:43:19 +02:00
Piotr Surowiec
baeb64d13e Merge pull request #30811 from open-craft/0x29a/bb6442/remove_field_data
refactor: remove `field_data` usage by all `DescriptorSystem` subclasses [BD-13]
2022-09-19 12:35:57 +02:00
Muhammad Adeel Tajamul
1259c0e7a5 fix: sort order will not be alphabetical (#30990)
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
2022-09-19 12:24:46 +05:00
SaadYousaf
b8e466b55c fix: update editable action item for different discussion and course roles 2022-09-19 11:51:24 +05:00
Jenkins
bdb0e4d8ad chore(i18n): update translations 2022-09-18 16:57:26 -04:00
Maxwell Frank
4f0af713d8 fix: update cert requirements 2022-09-16 19:45:59 +00:00
Nathan Sprenkle
5f1530cd57 feat: learner home get suggested courses (#31004)
* feat: get suggested courses

* style: run black

* docs: update suggested courses mock

* docs: remove cardID from mock

* docs: fix mock course.title to course.courseName

* docs: fix mock course.bannerUrl to bannerImgSrc

* docs: fix mock provider to courseProvider

* docs: remove old mock courseProvider fields

* docs: fix mock "grades" to "gradeData"

* docs: fix mock remove courseRun.lastEnrolled

* docs: fix mock add enrollment.lastEnrolled

* docs: mock remove enrollment.isStarted

* docs: mock fix bad nesting in courseRun

* docs: mock certificates to certificate

* docs: mock remove certificate.isAvailable

* docs: mock remove entitlement.isEntitlement

* docs: mock add entitlement.expirationDate

* docs: mock fix some entitlement inconsistencies

* docs: mock remove entitlement.canViewCourse

* docs: mock nest relatedPrograms under programs

* fix: return null for missing resumeUrl

* test: return null for missing resumeUrl

* refactor: update suggested course fields

* refactor: update related programs fields

* docs: remove entitlement.expirationDate from mock

Co-authored-by: nsprenkle <nsprenkle@2u.com>
2022-09-16 14:41:02 -04:00
Jansen Kantor
8162d21566 feat: add related program info to unfulfilled entitlements (#31011) 2022-09-16 10:30:18 -04:00
Sarina Canelake
40467d8604 Merge pull request #30951 from openedx/tcril/fix-gh-org-url
Fix github url strings (org edx -> openedx)
2022-09-16 09:58:15 -04:00
Justin Hynes
b18716188d Merge pull request #30994 from openedx/jhynes/aper-1968_v2
feat: Send `modified` data of a learner's grade to the Credentials IDA
2022-09-16 08:45:40 -04:00
Sarina Canelake
6b42d67513 chore: run Manage local config files from masters in edx_lint.
version 5.3.0
Commands:

    write FILENAME
        Write a local copy of FILENAME using FILENAME_tweaks for local tweaks.

    check [FILENAME ...]
        Check that FILENAME has not been edited since writing.
        If FILENAME is omitted, all existing files are checked.

    list
        List the files that edx_lint can provide.

    update
        Re-write any edx_lint-written files that exists on disk.
     update with the current version of the repo.
2022-09-15 17:13:49 -04:00
Sarina Canelake
cf5fa64bd7 fix: update repo paths that stayed in the edx org
Co-authored-by: Kyle McCormick <kdmc@pm.me>
2022-09-15 14:52:28 -04:00
Sarina Canelake
69f0849165 fix: update path to .github workflows to read from openedx org 2022-09-15 14:52:28 -04:00
Sarina Canelake
4a2f231302 fix: fix github url strings (org edx -> openedx) 2022-09-15 14:52:28 -04:00
alangsto
8ab34fd918 chore: upgrade edx-proctoring version (#31002) 2022-09-15 10:31:57 -04:00
Justin Hynes
ef6de11467 feat: Send modified data of a learner's grade to the Credentials IDA
[APER-1968]

We don't have a good way to understand if grade data in Credentials is out of sync with the LMS. Grades are sent to Credentials via a REST API call originating from an asynchronous Celery task on the LMS side. This PR updates our Celery task `send_grade_to_credentials` to include sending the `modified` DateTime value of a grade record to the Credentials IDA. Updates will be made on the Credentials side to accept and store this data as part of the UserGrade instance.

* Updates the `send_grade_to_credentials` task to include passing the grade's `modified` DateTime info as part of the request data to Credentials
* Updates the `CourseGradeBase` class to include an optional `last_updated` field. This will store the `modified` date of a PersistentCourseGrade instance when a grade is read through the CourseGradeFactory.
* Update existing log statement to use format strings where possible.
2022-09-15 08:02:26 -04:00
Attiya Ishaque
795fbbde8c chore: update tests according to is_register_page check (#30986) 2022-09-15 14:42:08 +05:00
Ahtisham Shahid
eca87000c4 Created a edx.forum.thread.locked event (#30964)
* feat: added new discussions event edx.forum.thread.locked
2022-09-15 11:18:32 +05:00
Ahtisham Shahid
889c16533e feat: added new edit reason code (#30984) 2022-09-15 11:17:28 +05:00
Jenkins
0e6b1a334a chore: geoip2: update maxmind geolite country database 2022-09-14 16:51:43 -04:00
Sagirov Evgeniy
42adcaaf4d FC-0001: Remove Persistent Course Grades Flags (#30978)
* feat: revert Fix certificate generation without persistent grades

* feat: Remove Persistent Course Grades Flags

* test: update tests
2022-09-14 14:00:01 -04:00
Leangseu Kim
9530771cad feat: implement related programs for learner home
chore: simplify lms/djangoapps/learner_home/serializers.py

Co-authored-by: Nathan Sprenkle <nsprenkle@users.noreply.github.com>

chore: safety for authoring_organizations
2022-09-14 11:09:05 -04:00
Sagirov Evgeniy
b429e55cac feat!: remove Studio editing for Old Mongo Courses
This removes user-facing Studio edit support for Old Mongo courses
(courses that have a CourseKey of the format {org}/{course}/{run}).
This does not affect our normal courses, which have CourseKeys
starting with "course-v1:".

After this commit:

* Old Mongo courses will continue to appear on the Studio course
  listing page, but are not clickable.
* Any attempt to directly access an Old Mongo course in Studio via URL
  fail with a 404 error.
* Course certificates will still be available for Old Mongo courses.
* Old Mongo courses will continue to be returned by CourseOverviews
  and get_course_summaries() calls.

We decided against removing Old Mongo courses from the listing entirely
because that would require very expensive CourseOverviews query to
filter them out. Making that query more efficient would involve a
database migration to add appropriate indexing, which is something else
that we are looking to avoid. CourseOverviews are used everywhere in
the system, so we want to avoid changing how they work so that we can
minimize risk.

This is part of the Old Mongo Modulestore deprecation effort:
  https://github.com/openedx/public-engineering/issues/62
2022-09-14 10:53:33 -04:00
Kyle McCormick
57a1f58232 refactor!: remove safe_lxml import compatibility hack (#30671)
In the past, safe_lxml was located at ./common/lib/safe_lxml/safe_lxml,
and was imported as so:

  import safe_lxml

Now, safe_lxml is located at ./openedx/core/lib/safe_lxml, and is
imported as so:

  import openedx.core.lib.safe_lxml

We added in a temporary backwards-compatibility hack, in the form
of the module ./safe_lxml/__init__.py, to support the old import
format (with a warning written to the logs).

Enough time has passed that it we feel it is safe to
remove that compatibility hack. After this commit, imports in
the form `import safe_lxml` will raise an ImportError.
2022-09-14 10:07:21 -04:00
Leangseu Kim
49380a00ec chore: rename hasAccess to coursewareAccess 2022-09-14 09:32:10 -04:00
Brian Smith
9262357f1b build: rebuild package-lock.json
The existing `package-lock.json` included `fsevents` which is a macOS specific package.
This was causing errors when running a clean install (`npm ci`) on Linux hosts.
By deleting the existing `package-lock.json` and rebuilding it using `npm install --legacy-peer-deps`
on a Linux host machine, the `fsevents` error is resolved. This has the side-effect of updating
all of the pinned package versions to the latest versions that satisfy our `package.json` requirements.
2022-09-13 15:26:54 -04:00
Kyle McCormick
bacce909f6 build: in CI, use npm clean-install instead of npm install
Packages can be added to package-lock.json that will fail to
install on certain systems. For example, the `fsevents` NPM
package, which only works on macOS, was listed as a requirement
in the file.

`npm install` will happily skip over such packages.
`npm clean-install`, however, will exit with a fatal error.

Throughout several doc pages, we have recently been encouraging
folks to use `clean-install` instead of `install`, because its
strictness makes it more reproducible. To ensure that `clean-install`
is working reliably at any given time, we should use `clean-install`
in our CI pipeline.
2022-09-13 15:26:54 -04:00
Nathan Sprenkle
1673b1d3b9 feat: learner home course provider and grade data (#30959)
* feat: get course provider info

* feat: get grade data

* feat: get course provider for entitlements

* style: run black

Co-authored-by: nsprenkle <nsprenkle@2u.com>
2022-09-13 12:24:49 -04:00