Merge pull request #30811 from open-craft/0x29a/bb6442/remove_field_data

refactor: remove `field_data` usage by all `DescriptorSystem` subclasses [BD-13]

xmodule/modulestore/mongo/base.py

@@ -204,7 +204,6 @@ class CachingDescriptorSystem(MakoDescriptorSystem, EditInfoRuntimeMixin):  # li
         kwargs.setdefault('id_reader', id_manager)
         kwargs.setdefault('id_generator', id_manager)
         super().__init__(
-            field_data=None,
             load_item=self.load_item,
             **kwargs
         )

xmodule/modulestore/split_mongo/caching_descriptor_system.py

@@ -60,7 +60,6 @@ class CachingDescriptorSystem(MakoDescriptorSystem, EditInfoRuntimeMixin):  # li
         kwargs.setdefault('id_generator', id_manager)
 
         super().__init__(
-            field_data=None,
             load_item=self._load_item,
             resources_fs=OSFS(root),
             **kwargs

xmodule/modulestore/xml.py

@@ -493,7 +493,9 @@ class XMLModuleStore(ModuleStoreReadBase):
                 """
                 return policy.get(policy_key(usage_id), {})
 
-            services = {}
+            services = {
+                'field-data': self.field_data
+            }
             if self.i18n_service:
                 services['i18n'] = self.i18n_service
 
@@ -513,7 +515,6 @@ class XMLModuleStore(ModuleStoreReadBase):
                 mixins=self.xblock_mixins,
                 default_class=self.default_class,
                 select=self.xblock_select,
-                field_data=self.field_data,
                 services=services,
                 target_course_id=target_course_id,
             )

xmodule/modulestore/xml_importer.py

@@ -954,7 +954,7 @@ def _import_course_draft(
         error_tracker=errorlog.tracker,
         load_error_modules=False,
         mixins=xml_module_store.xblock_mixins,
-        field_data=KvsFieldData(kvs=DictKeyValueStore()),
+        services={'field-data': KvsFieldData(kvs=DictKeyValueStore())},
         target_course_id=target_id,
     )
 

xmodule/tests/__init__.py

@@ -182,7 +182,6 @@ def get_test_descriptor_system(render_template=None):
         error_tracker=Mock(name='get_test_descriptor_system.error_tracker'),
         render_template=render_template or mock_render_template,
         mixins=(InheritanceMixin, XModuleMixin),
-        field_data=field_data,
         services={'field-data': field_data},
     )
     descriptor_system.get_asides = lambda block: []

xmodule/tests/test_course_module.py

@@ -55,7 +55,7 @@ class DummySystem(ImportSystem):  # lint-amnesty, pylint: disable=abstract-metho
             course_dir=course_dir,
             error_tracker=error_tracker,
             load_error_modules=load_error_modules,
-            field_data=KvsFieldData(DictKeyValueStore()),
+            services={'field-data': KvsFieldData(DictKeyValueStore())},
         )
 
 

xmodule/tests/test_import.py

@@ -49,7 +49,7 @@ class DummySystem(ImportSystem):  # lint-amnesty, pylint: disable=abstract-metho
             error_tracker=error_tracker,
             load_error_modules=load_error_modules,
             mixins=(InheritanceMixin, XModuleMixin),
-            field_data=KvsFieldData(DictKeyValueStore()),
+            services={'field-data': KvsFieldData(DictKeyValueStore())},
         )
 
     def render_template(self, _template, _context):  # lint-amnesty, pylint: disable=method-hidden

xmodule/tests/xml/__init__.py

@@ -38,7 +38,7 @@ class InMemorySystem(XMLParsingSystem, MakoDescriptorSystem):  # pylint: disable
             mixins=xml_import_data.xblock_mixins,
             select=xml_import_data.xblock_select,
             render_template=lambda template, context: pprint.pformat((template, context)),
-            field_data=KvsFieldData(DictKeyValueStore()),
+            services={'field-data': KvsFieldData(DictKeyValueStore())},
         )
 
     def process_xml(self, xml):  # pylint: disable=method-hidden