Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: update tests according to is_register_page check (#30986)

Browse Source
This commit is contained in:
Attiya Ishaque
2022-09-15 14:42:08 +05:00
committed by GitHub
parent eca87000c4
commit 795fbbde8c
4 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lms/envs/common.py
View File

@@ -3570,9 +3570,9 @@ REGISTRATION_FIELD_ORDER = [
"city",
"state",
"country",
"gender",
"year_of_birth",
"level_of_education",
"gender",
"specialty",
"profession",
"company",

2
openedx/core/djangoapps/user_authn/api/helper.py
View File

@@ -96,7 +96,7 @@ class RegistrationFieldsContext(APIView):
return (field in self.user_profile_fields or field in ["terms_of_service", "honor_code"] or
field in configuration_helpers.get_value('extended_profile_fields', []))
def _get_fields(self):
def get_fields(self):
"""
Returns the required or optional fields configured in REGISTRATION_EXTRA_FIELDS settings.
"""

9
openedx/core/djangoapps/user_authn/api/tests/test_views.py
View File

@@ -240,7 +240,8 @@ class MFEContextViewTest(ThirdPartyAuthTestMixin, APITestCase):
'error_message': '',
}
}
response = self.client.get(self.url)
self.query_params.update({'is_register_page': True})
response = self.client.get(self.url, self.query_params)
assert response.status_code == status.HTTP_200_OK
assert response.data['optional_fields']['fields'] == expected_response
@@ -274,7 +275,8 @@ class MFEContextViewTest(ThirdPartyAuthTestMixin, APITestCase):
'type': 'text',
}
}
response = self.client.get(self.url)
self.query_params.update({'is_register_page': True})
response = self.client.get(self.url, self.query_params)
assert response.status_code == status.HTTP_200_OK
assert response.data['optional_fields']['fields'] == expected_response
@@ -292,7 +294,8 @@ class MFEContextViewTest(ThirdPartyAuthTestMixin, APITestCase):
"""
Test that order of optional fields
"""
response = self.client.get(self.url)
self.query_params.update({'is_register_page': True})
response = self.client.get(self.url, self.query_params)
assert response.status_code == status.HTTP_200_OK
assert list(response.data['optional_fields']['fields'].keys()) == ['specialty', 'goals']

14
openedx/core/djangoapps/user_authn/api/views.py
View File

@@ -60,17 +60,17 @@ class MFEContextView(APIView):
if settings.ENABLE_DYNAMIC_REGISTRATION_FIELDS:
if is_register_page:
registration_fields = RegistrationFieldsContext()._get_fields() # pylint: disable=protected-access
registration_fields = RegistrationFieldsContext().get_fields()
context['registration_fields'].update({
'fields': registration_fields,
'extended_profile': configuration_helpers.get_value('extended_profile_fields', []),
})
optional_fields = RegistrationFieldsContext('optional')._get_fields() # pylint: disable=protected-access
if optional_fields:
context['optional_fields'].update({
'fields': optional_fields,
'extended_profile': configuration_helpers.get_value('extended_profile_fields', []),
})
optional_fields = RegistrationFieldsContext('optional').get_fields()
if optional_fields:
context['optional_fields'].update({
'fields': optional_fields,
'extended_profile': configuration_helpers.get_value('extended_profile_fields', []),
})
return Response(
status=status.HTTP_200_OK,