Commit Graph

59882 Commits

Author SHA1 Message Date
Phillip Shiu
09809f322e fix: add unit test
Pulled from @julianajlk's WIP, thank you!
2021-09-15 12:14:39 -04:00
Phillip Shiu
9185b3335b fix: correct relative paths in templates to track_selection.html 2021-09-15 12:08:21 -04:00
Phillip Shiu
9d259d7a99 refactor: remove folder track_selection_types 2021-09-15 12:08:21 -04:00
Phillip Shiu
5cf419b9f6 refactor: add _redirect_to_course_or_dashboard 2021-09-15 12:08:20 -04:00
Phillip Shiu
2997e23f83 refactor: s/full_fbe/fbe, s/partial_fbe/unfbe + unfbe logic 2021-09-15 12:08:20 -04:00
Phillip Shiu
830878729d style: chop long lines 2021-09-15 12:08:20 -04:00
Phillip Shiu
1bafc0ff27 fix: remove check for verified - already performed earlier 2021-09-15 12:08:20 -04:00
Phillip Shiu
a8e841f523 fix: add track selection redirection for partial_fbe.html 2021-09-15 12:08:20 -04:00
Phillip Shiu
359f3cf3f6 fix: add partial_fbe.html 2021-09-15 12:08:20 -04:00
Phillip Shiu
2e5b922692 fix: abstract track selection bullets into new mako template 2021-09-15 12:08:08 -04:00
alangsto
9b204debf4 feat: check if profile name changes are valid for name affirmation. (#28697)
MST-970. If name affirmation is enabled, a user should only be allowed to make limited edits to their profile name before they are required to go through IDV. Right now, the allowable edits are limited to:

* add/delete/replace one character (including one space on either side)

Edits that are not allowed, and therefore require IDV include:

* changing 2 or more characters
* changing their name 3 or more times

This behavior will not be enabled until name affirmation is fully rolled out, so there should be no noticeable difference in account settings behavior at the time this is merged.
2021-09-15 09:53:30 -04:00
julianajlk
519872a993 feat: add SVGs for icons in Track Selection, refactor URLs and tests (#28701)
REV-2133
2021-09-15 09:37:31 -04:00
Thomas Tracy
6f44841deb [feat] Add user_id scope to credentialsApiClient (#28737)
Now that we're actively using the LMS_USER_ID inside credentials to
identify users, we need to make sure that users created by
notify_credentials are including it in the jwt scopes when authenticated
with credentials.
2021-09-15 09:17:51 -04:00
Shafqat Farhan
b1b750944b Merge pull request #28743 from edx/shafqat/VAN-474
fix: VAN-474 - Deleted cookie for activation popup
2021-09-15 15:25:24 +05:00
Shafqat Farhan
39ee98420a fix: VAN-474 - Deleted cookie for activation popup 2021-09-15 13:56:53 +05:00
Awais Qureshi
15461d3b6e Merge pull request #28740 from edx/fixing-constraint-
fix: Removing un-necessary link from the constraint.
2021-09-15 10:19:53 +05:00
Awais Qureshi
17e61b986d fix: Removing un-necessary link from the constraint. 2021-09-15 09:00:27 +05:00
Kyle McCormick
d701b423f1 fix: repair search of course creator statuses in django admin
It was broken because "organizations" was erronously included
in the `search_fields` admin option. Many-to-many fields
may not be used for search.

TNL-8722
2021-09-14 13:31:08 -04:00
Kyle McCormick
f0239b724e fix: show creation rights notice on studio "courses" tab
There was a JS bug that made it so the course creation rights
notice (the thing that invites new studio users to request
access to create content) disappeared if the user selected
the "Courses" or "Libraries" tab.

This is because it was incorrectly comparing the #courses-tab
URL frament against the string "courses" instead of "courses-tab".

TNL-8718
2021-09-14 13:31:08 -04:00
Manjinder Singh
f34606f8a4 feat: adding monitoring to CookieNameChange middleware (#28730)
* feat: adding monitoring to CookieNameChange middleware

Adding custom attribute: cookie.change_name
if cookie.change_name in transaction and equal 0, cookie with alternate name is detected and deleted
if cookie.change_name in transaction and equal 1, cookie with current name not in request and added
2021-09-14 08:31:36 -04:00
Kshitij Sobti
d15a954698 docs: ADR for in context discussions (#28221) 2021-09-14 12:28:26 +05:00
Adam Stankiewicz
96b2ab7a2f fix: bump edx-enterprise to v3.28.9 (#28729) 2021-09-13 15:02:47 -04:00
Olivia Ruiz-Knott
5678b9e036 Merge pull request #28715 from edx/ork/MICROBA-1488_change-override-to-datetime-field
feat: Change override date to datetime
2021-09-13 09:23:46 -06:00
Binod Pant
4be2535ed8 feat: edx-enterprise 3.28.8 (#28719)
ENT-4784
2021-09-13 10:36:20 -04:00
Awais Qureshi
f0cd6d78f5 Merge pull request #28707 from edx/dj30-regex-issue-re-path
fix: RegexPattern, used by re_path(), no longer returns keyword argum…
2021-09-13 18:52:24 +05:00
Jawayria
43d0b4eec8 Merge pull request #28709 from edx/jawayria/fix-check
fix: Added the condition on body_type in test_reset_password
2021-09-13 16:15:08 +05:00
edX Transifex Bot
6e9d448a19 chore(i18n): update translations 2021-09-13 02:45:53 +05:00
oliviaruizknott
59fefa10eb feat: Change override date to datetime
When first building the Certificate Date Override feature, I set up the
CertificateDateOverride model to store the override dates as Dates
instead of DateTimes.

Turns out this is not how edX typically handles dates, and it’s causing
some minor headaches around needing to convert values. Also, using just
Dates causes timezone issues.

MICROBA-1488
2021-09-10 14:42:36 -06:00
stvn
973b3c28fc merge(#28702): feat/ceng-codeowners
commits
=======
- fix: skip automatic reviews for noisy community-engineering paths
2021-09-10 12:39:28 -07:00
julianajlk
5cfa680835 fix: add nested CSS to avoid popover class name override (#28712)
REV-2329
2021-09-10 15:32:53 -04:00
Olivia Ruiz-Knott
1495981ef6 Merge pull request #28692 from edx/ork/MICROBA-1489_notify-credentials-and-date-overrides
feat: notify_credentials of changed overrides
2021-09-10 13:27:45 -06:00
Tim McCormack
0c164ad4c2 fix: Fix Studio logout by pointing to correct logout view (#28714)
This changes the "Sign out" link on Studio to point to Studio's own logout
view, which clears the session and then redirects to LMS's logout page. The
LMS logout page then skips loading the Studio logout because it is seen in
the Referer header.

This change also brings Studio better into line with how other IDAs perform
their logouts.

Background:

After the rollout of Studio OAuth, logouts initiated on Studio failed to
actually log out Studio (but all other IDAs were logged out). This was
because the LMS logout view loads the logout pages of other IDAs but skips
any that is a *prefix* match on the Referer header, and browsers now often
send a truncated version of the Referer for privacy. Therefore, Studio was
always skipped when coming from Studio.

The fix is to make sure that Studio has already performed its logout by the
time the LMS logout page is loaded.

One wrinkle here is that the LMS logout view is activated by `/logout`, but
the correct logout view (provided by auth_backends) is activated by
`/logout/` -- with a trailing slash. This is fragile and unfortunate, but
can be cleaned up when we later remove other leftovers of Studio's previous
ability to handle logistration.

ref: ARCHBOM-1897
2021-09-10 18:45:58 +00:00
oliviaruizknott
dbfe2a3f2b feat: notify_credentials of changed overrides
We use the `notify_credentials` management command to keep certificate-
related data in the LMS and Credentials service in sync. We can run it
with specific arguments (user_ids, course_keys, etc.) when we notice a
data discrepancy; and it is run regularly by a Jenkins job with the
`--auto` flag every ~4 hours to keep things up-to-date.

Because we probably never want to notify credentials of of ALL the
GeneratedCertificates, the celery task must be given some arguments
to filter down to the relevant certificates. Running the management
command with the `--auto` flag (as the Jenkins job does) adds
`start_date` and `end_date` arguments of 4 hours ago and now,
respectively.

The handle_notify_credentials celery task then takes those arguments and
looks for any GeneratedCertificates that have been modified within the
given time range by checking the GeneratedCertificate modified_date.
It will send the current data for those certificates to credentials.

However, we also want to notify credentials about certificates that have
an associated CertificateDateOverride that has changed within that time
range: added, updated, or deleted. But changes to a
CertificateDateOverride won’t affect the GeneratedCertificate’s modified
date, and therefore wouldn’t be included in the list of certs cent to
credentials.

This commit adds a check for changed CertificateDateOverrides and
includes their associated GeneratedCertificates in the list of certs. We
use the CertificateDateOverride’s history model for this check so that
we can include certificates whose override was deleted.

MICROBA-1489
2021-09-10 12:32:17 -06:00
Albert (AJ) St. Aubin
a235f497ac feat: Remove email sent with program cert award.
[MICROBA-1466]
2021-09-10 13:57:52 -04:00
Farhaan Bukhsh
48ad7effb1 feat: grant course/library creation rights by organization (#26616)
Current State (before this commit):

  Studio, as of today doesn't have a way to restrict a user to
  create a course in a particular organization. What Studio
  provides right now is a CourseCreator permission which gives
  an Admin the power to grant a user the permission to create
  a course.

  For example: If the Admin has given a user Spiderman the
  permission to create courses, Spiderman can now create courses
  in any organization i.e Marvel as well as DC.
  There is no way to restrict Spiderman from creating courses
  under DC.

Purpose of this commit:

  The changes done here gives Admin the ability to restrict a
  user on an Organization level from creating courses via the
  Course Creators section of the Studio Django administration
  panel.

  For example: Now, the Admin can give the user Spiderman the
  privilege of creating courses only under Marvel organization.
  The moment Spiderman tries to create a course under some
  other organization(i.e DC), Studio will show an error message.

  This change is available to all Studio instances that
  enable the FEATURES['ENABLE_CREATOR_GROUP'] flag.
  Regardless of the flag, it will not affect any instances that choose
  not to use it.

BB-3622
2021-09-10 12:43:26 -04:00
Jawayria
a3fd502bab fix quality 2021-09-10 21:10:21 +05:00
Binod Pant
42035b669b feat: upgrade for ent-4784 (#28711)
fixes issue with get_remote_id when multiple idps
2021-09-10 11:42:49 -04:00
Jawayria
dee102a70b fix: Added the condition on body_type in test_reset_password 2021-09-10 18:14:07 +05:00
Michael Terry
d5bacad86f Merge pull request #28698 from edx/mikix/hide-after-due-mfe
feat: notify MFE when a sequence is hidden-after-due
2021-09-10 09:12:57 -04:00
Andrew Shultz
ced1bca95a Merge pull request #28688 from edx/ashultz0/idv-submitted-name
Do not immediately update profile name from IDV when name affirmation is on
2021-09-10 09:07:22 -04:00
Awais Qureshi
8f2a4f87fb fix: RegexPattern, used by re_path(), no longer returns keyword arguments with None values to be passed to the view for the optional named groups that are missing.
BOM-2793
2021-09-10 16:51:13 +05:00
Aarif
475a6af2af fix: fixed the workflow for publishing ci runner docker image (#28703) 2021-09-10 12:13:48 +05:00
Aarif
0d58faa926 added a workflow to build and push CI runner docker image (#28539) 2021-09-10 05:44:21 +05:00
stvn
4a2cc6769c fix: skip automatic reviews for noisy community-engineering paths
as we aren't concerned with these and do not intend to actively monitor,
unless tagged explicitly.
2021-09-09 15:11:47 -07:00
Michael Terry
cd7d13cd6d feat: notify MFE when a sequence is hidden-after-due
Currently, if a learner manually loads a sequence page that would
normally be skipped for them because it is hidden-after-due, the
sequence renders anyway.

This commit tells the frontend when it should not show a sequence
because it's hidden.

AA-1000
2021-09-09 14:43:00 -04:00
Andy Shultz
dc01bf3aad feat: add parameter to submit attempt to carry full name through
original behavior does pass the empty name through to
_update_full_name rather than just considering that as full name not
set. That's a little weird but outside the scope of this work so I've
preserved it by checking is not None rather than just using full_name
as a boolean.

MST-1015
2021-09-09 14:18:38 -04:00
Andy Shultz
695f2cd4c8 feat: prevent name update on photo verification if the name is already updated
MST-1015
2021-09-09 11:56:06 -04:00
Andy Shultz
f158fedd15 feat: only update full name if not verified name enabled
MST-1015
2021-09-09 11:56:06 -04:00
Andy Shultz
1288d964b8 docs: clarify docs for _update_full_name 2021-09-09 11:56:06 -04:00
Zia Fazal
1578b0c6ea Merge pull request #28642 from edly-io/ERTE-55
feat: Added support for enterprise id in course_grade_passed_first_time event
2021-09-09 18:37:51 +05:00