Merge pull request #28715 from edx/ork/MICROBA-1488_change-override-to-datetime-field

feat: Change override date to datetime

lms/djangoapps/certificates/migrations/0032_change_certificatedateoverride_date.py

@@ -0,0 +1,23 @@
+# Generated by Django 2.2.24 on 2021-09-09 22:10
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('certificates', '0031_certificatedateoverride_historicalcertificatedateoverride'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='certificatedateoverride',
+            name='date',
+            field=models.DateTimeField(help_text="The date to display on the certificate. Set 'Time' to midnight (00:00:00)."),
+        ),
+        migrations.AlterField(
+            model_name='historicalcertificatedateoverride',
+            name='date',
+            field=models.DateTimeField(help_text="The date to display on the certificate. Set 'Time' to midnight (00:00:00)."),
+        ),
+    ]

lms/djangoapps/certificates/models.py

@@ -1214,8 +1214,8 @@ class CertificateDateOverride(TimeStampedModel):
         related_name='date_override',
         help_text="The id of the Generated Certificate to override",
     )
-    date = models.DateField(
-        help_text="The date to display on the certificate",
+    date = models.DateTimeField(
+        help_text="The date to display on the certificate. Set 'Time' to midnight (00:00:00).",
     )
     reason = models.TextField(
         help_text="The reason why you are overriding the certificate date (Update this when you add OR edit the date.)",

lms/djangoapps/certificates/tests/factories.py

@@ -115,5 +115,5 @@ class CertificateDateOverrideFactory(DjangoModelFactory):
     class Meta:
         model = CertificateDateOverride
 
-    date = datetime.datetime(2021, 5, 11)
+    date = datetime.datetime(2021, 5, 11, 0, 0, tzinfo=datetime.timezone.utc)
     reason = "Learner really wanted this on their birthday"

openedx/core/djangoapps/programs/tasks.py

@@ -33,8 +33,7 @@ MAX_RETRIES = 11
 
 PROGRAM_CERTIFICATE = 'program'
 COURSE_CERTIFICATE = 'course-run'
-VISIBLE_DATE_FORMAT = '%Y-%m-%dT%H:%M:%SZ'
-DATE_OVERRIDE_FORMAT = '%Y-%m-%d'
+DATE_FORMAT = '%Y-%m-%dT%H:%M:%SZ'
 
 
 def get_completed_programs(site, student):
@@ -119,7 +118,7 @@ def award_program_certificate(client, user, program_uuid, visible_date):
         'attributes': [
             {
                 'name': 'visible_date',
-                'value': visible_date.strftime(VISIBLE_DATE_FORMAT)
+                'value': visible_date.strftime(DATE_FORMAT)
             }
         ]
     })
@@ -309,11 +308,11 @@ def post_course_certificate(client, username, certificate, visible_date, date_ov
             'mode': certificate.mode,
             'type': COURSE_CERTIFICATE,
         },
-        'date_override': {'date': date_override.strftime(DATE_OVERRIDE_FORMAT)} if date_override else None,
+        'date_override': {'date': date_override.strftime(DATE_FORMAT)} if date_override else None,
         'attributes': [
             {
                 'name': 'visible_date',
-                'value': visible_date.strftime(VISIBLE_DATE_FORMAT)
+                'value': visible_date.strftime(DATE_FORMAT)
             }
         ]
     })
@@ -449,7 +448,7 @@ def award_course_certificate(self, username, course_run_key, certificate_availab
             # Date is being passed via JSON and is encoded in the EMCA date time string format. The rest of the code
             # expects a datetime.
             if certificate_available_date:
-                certificate_available_date = datetime.strptime(certificate_available_date, VISIBLE_DATE_FORMAT)
+                certificate_available_date = datetime.strptime(certificate_available_date, DATE_FORMAT)
 
             # Even in the cases where this task is called with a certificate_available_date, we still need to retrieve
             # the course overview because it's required to determine if we should use the certificate_available_date or

openedx/core/djangoapps/programs/tests/test_tasks.py

@@ -586,7 +586,7 @@ class AwardCourseCertificatesTestCase(CredentialsApiConfigMixin, TestCase):
         assert call_args[1] == self.student.username
         assert call_args[2] == self.certificate
         assert call_args[3] == self.certificate.modified_date
-        assert call_args[4] == self.certificate.date_override.date.date()
+        assert call_args[4] == self.certificate.date_override.date
 
     def test_award_course_cert_not_called_if_disabled(self, mock_post_course_certificate):
         """