Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: adding monitoring to CookieNameChange middleware (#28730)

Browse Source 
* feat: adding monitoring to CookieNameChange middleware

Adding custom attribute: cookie.change_name
if cookie.change_name in transaction and equal 0, cookie with alternate name is detected and deleted
if cookie.change_name in transaction and equal 1, cookie with current name not in request and added
This commit is contained in:
Manjinder Singh
2021-09-14 08:31:36 -04:00
committed by GitHub
parent d15a954698
commit f34606f8a4
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
openedx/core/djangoapps/cookie_metadata/middleware.py
View File

@@ -1,6 +1,8 @@
"""Middleware to change name of an incoming cookie"""
from django.conf import settings
from edx_django_utils.monitoring import set_custom_attribute
class CookieNameChange:
"""Changes name of an incoming cookie"""
@@ -78,12 +80,19 @@ class CookieNameChange:
alt_cookie_in_request = True
alt_cookie_value = request.COOKIES[expand_settings["alternate"]]
del request.COOKIES[expand_settings["alternate"]]
# Adding custom attribute: cookie.change_name
# if cookie.change_name in transaction and equal 0,
# cookie with alternate name was detected and deleted
# if cookie.change_name in transaction and equal 1,
# cookie with current name was added
set_custom_attribute("cookie.change_name", 0)
if (
expand_settings["current"] not in request.COOKIES
and alt_cookie_in_request
):
request.COOKIES[expand_settings["current"]] = alt_cookie_value
set_custom_attribute("cookie.change_name", 1)
response = self.get_response(request)
return response