fix: remove hard-coded edX from page title (#432)

This uses variable substitution to insert SITE_NAME into index.html, rather than hard-coding “edX” into the file. It also updates the .env files to use “localhost” as the default SITE_NAME.
2021-05-03 15:53:05 -04:00
parent d1548b7287
commit 58affb83a9
4 changed files with 4 additions and 4 deletions
--- a/.env
+++ b/.env
@@ -13,7 +13,7 @@ NODE_ENV=null
 ORDER_HISTORY_URL=null
 REFRESH_ACCESS_TOKEN_ENDPOINT=null
 SEGMENT_KEY=null
-SITE_NAME=null
+SITE_NAME=''
 SUPPORT_URL=null
 USER_INFO_COOKIE_NAME=null
 LOGO_URL=''
--- a/.env.development
+++ b/.env.development
@@ -14,7 +14,7 @@ ORDER_HISTORY_URL='localhost:1996/orders'
 PORT=1997
 REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
 SEGMENT_KEY=null
-SITE_NAME='edX'
+SITE_NAME=localhost
 SUPPORT_URL='http://localhost:18000/support'
 USER_INFO_COOKIE_NAME='edx-user-info'
 # Temporary, Remove this once we are ready to release the feature.
--- a/.env.test
+++ b/.env.test
@@ -13,7 +13,7 @@ NODE_ENV=null
 ORDER_HISTORY_URL='localhost:1996/orders'
 REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
 SEGMENT_KEY=null
-SITE_NAME='edX'
+SITE_NAME=localhost
 SUPPORT_URL='http://localhost:18000/support'
 USER_INFO_COOKIE_NAME='edx-user-info'
 COACHING_ENABLED=''
--- a/public/index.html
+++ b/public/index.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <html lang="en-us">
  <head>
-      <title>Account | edX</title>
+      <title>Account | <%= process.env.SITE_NAME %></title>
      <meta charset="utf-8">
      <meta name="viewport" content="width=device-width, initial-scale=1.0">
      <link rel="shortcut icon" href="<%=webpackConfig.output.publicPath%>favicon.ico" type="image/x-icon" />