From 58affb83a961703ed78535b89ce9428f7aa651e7 Mon Sep 17 00:00:00 2001 From: David Joy Date: Mon, 3 May 2021 15:53:05 -0400 Subject: [PATCH] fix: remove hard-coded edX from page title (#432) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This uses variable substitution to insert SITE_NAME into index.html, rather than hard-coding “edX” into the file. It also updates the .env files to use “localhost” as the default SITE_NAME. --- .env | 2 +- .env.development | 2 +- .env.test | 2 +- public/index.html | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.env b/.env index f7ce109..3dcf9e4 100644 --- a/.env +++ b/.env @@ -13,7 +13,7 @@ NODE_ENV=null ORDER_HISTORY_URL=null REFRESH_ACCESS_TOKEN_ENDPOINT=null SEGMENT_KEY=null -SITE_NAME=null +SITE_NAME='' SUPPORT_URL=null USER_INFO_COOKIE_NAME=null LOGO_URL='' diff --git a/.env.development b/.env.development index f45660b..10e112c 100644 --- a/.env.development +++ b/.env.development @@ -14,7 +14,7 @@ ORDER_HISTORY_URL='localhost:1996/orders' PORT=1997 REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh' SEGMENT_KEY=null -SITE_NAME='edX' +SITE_NAME=localhost SUPPORT_URL='http://localhost:18000/support' USER_INFO_COOKIE_NAME='edx-user-info' # Temporary, Remove this once we are ready to release the feature. diff --git a/.env.test b/.env.test index 762e4d0..2e672ab 100644 --- a/.env.test +++ b/.env.test @@ -13,7 +13,7 @@ NODE_ENV=null ORDER_HISTORY_URL='localhost:1996/orders' REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh' SEGMENT_KEY=null -SITE_NAME='edX' +SITE_NAME=localhost SUPPORT_URL='http://localhost:18000/support' USER_INFO_COOKIE_NAME='edx-user-info' COACHING_ENABLED='' diff --git a/public/index.html b/public/index.html index 8f7e9cc..a09f8e4 100755 --- a/public/index.html +++ b/public/index.html @@ -1,7 +1,7 @@ - Account | edX + Account | <%= process.env.SITE_NAME %>