Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
57,530 Commits 1 Branch 0 Tags
f383a5b38522cc77f0ffee615db9313e6fa55bed
Commit Graph

22274 Commits

Author SHA1 Message Date
Tim McCormack
80a4437f33 fix: Always save generated anonymous user ID in DB; ignore save=False (#26399) 
This deprecates `save=False` for several functions and removes all known
usages of the parameter but does not actually remove the parameter.
Instead, it will emit a deprecation warning if the parameter is used.
We can remove the parameter as soon as we feel sure nothing is using it.

Now that we have refactored `anonymous_id_for_user` to always prefer
retrieving an existing ID from the database -- and observed that only a
small fraction of calls pass save=False -- we can stop respecting
save=False. This opens the door for future improvements, such as generating
random IDs or switching to the external user ID system.

Metrics: I observe that 1 in 16 requests for new, non-request-cached
anon user IDs are made with save=False. But 71% of all calls are served
from the request cache, and 99.7% of the misses are served from the DB.
save=False only appear to come from intermittent spikes as reports are
generated and are low in absolute number.

Also document usage/risk/rotation of secret in anonymous user ID
generation as indicated by `docs/decisions/0008-secret-key-usage.rst`
ADR on `SECRET_KEY` usage.

ref: ARCHBOM-1683
 2021-02-08 19:16:05 +00:00
Bianca Severino
54505b82c4 Merge pull request #26436 from edx/bseverino/proctoring-check-fix 
[MST-645] Account for no enrollment in courseware rules
 2021-02-08 13:39:40 -05:00
Carla Duarte
a3f0050c4d Merge pull request #26396 from edx/ciduarte/depr-keys 
AA-650: block deprecated keys from course home MFE
 2021-02-08 13:27:58 -05:00
Bianca Severino
4fb36709a5 Account for no enrollment in courseware rules 2021-02-08 13:12:52 -05:00
Carla Duarte
8d2d78dc61 AA-650: block deprecated keys from course home MFE 2021-02-08 13:00:36 -05:00
Feanil Patel
03d2d983ea Merge pull request #26392 from edx/feanil/rate_limit_anon_csv 
Feanil/rate limit anon csv
 2021-02-08 12:05:21 -05:00
Christie Rice
367d2a07c9 Fix lint-amnesty warnings (#26411) 2021-02-08 10:49:32 -05:00
Gábor Boros
dd55860da1 [TSD] [SE-3988] add annotations to instructor plugin settings (#26202) 
docs: add annotations to instructor plugin settings
 2021-02-08 10:45:26 -05:00
Tim McCormack
b8a6e30bd9 fix: Add new proctoring key to Studio devstack & tests envs (copy from LMS) (#26430) 
Turns out it's needed for the Proctoring Settings view.

Also reorder slightly for better clustering.

MST-644
 2021-02-08 15:43:51 +00:00
Christie Rice
6e5a9f5f6f MICROBA-918 Move methods to separate certificate generation from celery task to schedule certificate generation. Also standardizes imports. (#26410) 2021-02-08 10:01:04 -05:00
edx-pipeline-bot
930980d732 Merge pull request #26427 from edx/private_to_public_01b389b 
Mergeback PR from private to public.
 2021-02-08 09:36:23 -05:00
Usama Sadiq
1bb06669e3 Merge branch 'master' into usamasadiq/bom-2312-pylint-amnesty-common-lib 2021-02-08 18:26:15 +05:00
Usama Sadiq
90666a6231 Merge pull request #26311 from edx/usamasadiq/bom-2305-pylint-amnesty 
Applied pylint-amnesty
 2021-02-08 18:23:34 +05:00
JayRam Nai
17cde562da docs: Add annotations for ENABLE_FOOTER_MOBILE_APP_LINKS feature flag (#26389) 
docs: update warning for ENABLE_FOOTER_MOBILE_APP_LINKS features toggle
 2021-02-08 07:58:09 -05:00
Ali Akbar
06cfaa2d88 Merge pull request #220 from edx/IM/security-fixes-9 
Incident Management Security Fixes 9
 2021-02-08 17:46:06 +05:00
usamasadiq
1175838fa5 fix pep8 warnings 2021-02-08 16:08:01 +05:00
usamasadiq
7bbde8f0f5 Applied pylint-amnesty 2021-02-08 13:00:22 +05:00
JayRam Nai
f5ba226c71 docs: Add annotations for ENABLE_DJANGO_ADMIN_SITE feature flag (#26388) 2021-02-06 11:04:22 -05:00
JayRam Nai
c658a4719b docs: Adds annotations for HIDE_DASHBOARD_COURSES_UNTIL_ACTIVATED feature flag (#26403) 2021-02-06 10:48:10 -05:00
Felipe Montoya
081a334fb8 Merge pull request #26212 from eduNEXT/lmm/annotation_mfe_urls 
[TSD] Add annotations for MFE URL settings
 2021-02-05 17:51:05 -05:00
Felipe Montoya
aba34c506e Merge pull request #26406 from jramnai/tsd-enable_student_history_view 
[TSD] docs: Add annotations for ENABLE_STUDENT_HISTORY_VIEW feature flag
 2021-02-05 17:50:41 -05:00
Tim McCormack
38f29c30f8 feat: Use edx-proctoring 3.0.0 and set required ID generation key (#26408) 
MST-637: edx-proctoring 3.0.0 now requires a new key for use in ID
generation, starting from same value as SECRET_KEY (pre-rotation, but
rotation never happened for devstack.)

Remote config changes already made for relevant environments.
 2021-02-05 16:19:14 +00:00
Matthew Piatetsky
b91f720b7e Merge pull request #26293 from edx/AA-613 
[AA-613] Return content type gate for staff users when masquerading as the Learner in Audit or Learner in Limited Access Roles
 2021-02-05 09:18:34 -05:00
Jayram Nai
df517c7c21 docs: Add annotations for ENABLE_STUDENT_HISTORY_VIEW feature flag 2021-02-05 18:54:36 +05:30
Matthew Piatetsky
ae7d0a1ed8 Return content type gate for staff users when masquerading as the Learner in Audit or Learner in Limited Access Roles 
This is necessary to display the content type gate in the UI
AA-613
 2021-02-04 17:34:16 -05:00
Christie Rice
1fe0eee969 MICROBA-918 Fix warnings (#26397) 2021-02-04 15:45:00 -05:00
Carla Duarte
a08faaaa9c Merge pull request #26360 from edx/ciduarte/AA-635 
AA-635: learner dashboard course card image bug
 2021-02-04 14:58:53 -05:00
Feanil Patel
0221d6a081 feat: Add ratelimitng to the get_anon_ids api endpoint. 
This endpoint can be computationally intensive and so we want to limit
the number of concurrent executions so that it doesn't overload the
server.
 2021-02-04 14:03:15 -05:00
Christie Rice
8845685fd8 MICROBA-918 Check for the allowlist on invalidation and failing grades (#26356) 2021-02-04 13:42:33 -05:00
Olivia Ruiz-Knott
016b1ce3f7 Merge pull request #26227 from edx/ork/MICROBA-905_add-history-to-certificate-invalidation 
MICROBA-905 Add django-simple-history  to CertificateInvalidation model
 2021-02-04 10:11:05 -05:00
Sid Verma
d81215c1e9 [SE-3685] Hide footer links if unconfigured in Certificates (#25872) 
* Don't show marketing links if not configured

* Remove failing test
 2021-02-04 10:09:49 -05:00
Waheed Ahmed
38187de0f9 Authn MFE: Toggle for microfrontend redirect. 
VAN-308
 2021-02-04 18:58:58 +05:00
Jawayria
11174a8d9c Merge pull request #26285 from edx/py-amnesty-courseware 
Applied pylint-amnesty to courseware
 2021-02-04 14:44:36 +05:00
Jawayria
1bfbedcc8f Merge pull request #26280 from edx/py-amnesty-course-api 
Applied pylint-amnesty to course_api
 2021-02-04 14:44:24 +05:00
Jawayria
959aed9841 Resolved pep8 issues 2021-02-04 14:07:47 +05:00
Jawayria
e9b167e1fd Applied pylint-amnesty to course_api 2021-02-04 13:22:45 +05:00
Ali-D-Akbar
c7a467b04d PROD-1999 2021-02-04 10:20:25 +05:00
oliviaruizknott
d33d9a66c8 docs: clarify comment 2021-02-03 16:52:34 -05:00
Carla Duarte
d6beb37d72 AA-635: learner dashboard course card image bug 2021-02-03 16:21:43 -05:00
Gonzalo Romero
22eb29dabe [TSD]Adding toggle annotations for wiki settings (#26262) 
Adding toggle annotations for WIKI settings

* adding annotations for WIKI_HANDLING_ACCOUNT
* adding annotations for WIKI_ANONYMOUS
* add toggle annotations for WIKI_ENABLED
* add toggle annotations for WIKI_USE_BOOTSTRAP_SELECT_WIDGET
 2021-02-03 15:43:20 -05:00
anjalia28
df45be2e20 [TSD] add toggle annotations for FEATURES['ENABLE_DISCUSSION_SERVICE'] (#26205) 
* add toggle annotations for FEATURES['ENABLE_DISCUSSION_SERVICE']
* added comments in cms/envs/common.py
 2021-02-03 15:18:14 -05:00
Ali Akbar
c5b0056b30 Merge pull request #215 from edx/IM/security-fixes-6 
Incident Management Security Fixes 6
 2021-02-04 00:03:38 +05:00
Felipe Montoya
b3cbc404d9 Merge pull request #26046 from open-craft/danielf/BB-3502 
[BTR-53] [BB-3502] Misuse of urljoin in Gradebook URL from Instructor Panel
 2021-02-03 12:59:21 -05:00
Nimisha Asthagiri
2a8b57b01f Merge pull request #26350 from jramnai/tsd-redirect_user_to_homepage 
[TSD] annotations for ALWAYS_REDIRECT_HOMEPAGE_TO_DASHBOARD_FOR_AUTHENTICATED_USER
 2021-02-03 12:52:51 -05:00
Nimisha Asthagiri
3f8aa0bd7d Merge pull request #26352 from jramnai/tsd-courses_are_borwsable 
[TSD] adds annotations for COURSES_ARE_BROWSABLE feature flag
 2021-02-03 12:45:54 -05:00
Nimisha Asthagiri
01f2a73081 Merge pull request #26353 from jramnai/tsd-enable_account_deletion 
[TSD] add annotations for ENABLE_ACCOUNT_DELETION feature flag
 2021-02-03 12:45:25 -05:00
Nimisha Asthagiri
cdb254075c Merge pull request #26354 from jramnai/tsd-enable_bulk_enrollment_view 
[TSD] add annotations for ENABLE_BULK_ENROLLMENT_VIEW feature flag
 2021-02-03 12:45:06 -05:00
Jawayria
03e6a874d0 Applied pylint-amnesty to courseware 2021-02-03 21:56:24 +05:00
Robert Raposa
bb4cfca17b Merge pull request #26183 from open-craft/nizar/tsd-maintenance-warning 
[TSD] Documents maintenance banner switch and setting and updates switch
 2021-02-03 11:41:38 -05:00
Jayram
d312ab4ff5 add annotations for ENABLE_BULK_ENROLLMENT_VIEW feature flag 2021-02-03 21:44:42 +05:30