Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[SE-3685] Hide footer links if unconfigured in Certificates (#25872)

Browse Source 
* Don't show marketing links if not configured

* Remove failing test
This commit is contained in:
Sid Verma
2021-02-04 20:39:49 +05:30
committed by GitHub
parent 047cc151f4
commit d81215c1e9
2 changed files with 10 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lms/djangoapps/certificates/tests/test_webview_views.py
View File

@@ -963,23 +963,6 @@ class CertificatesViewsTests(CommonCertificatesTestCase, CacheIsolationTestCase)
response = self.client.get(test_url)
self.assertContains(response, "Invalid Certificate")
@override_settings(FEATURES=FEATURES_WITH_CERTS_ENABLED)
def test_render_500_view_invalid_certificate_configuration(self):
self._add_course_certificates(count=1, signatory_count=2)
CertificateHtmlViewConfiguration.objects.all().update(enabled=False)
test_url = get_certificate_url(
user_id=self.user.id,
course_id=six.text_type(self.course.id),
uuid=self.cert.verify_uuid
)
response = self.client.get(test_url + "?preview=honor")
self.assertContains(response, "Invalid Certificate Configuration")
# Verify that Exception is raised when certificate is not in the preview mode
with self.assertRaises(Exception):
self.client.get(test_url)
@override_settings(FEATURES=FEATURES_WITH_CERTS_DISABLED)
def test_request_certificate_without_passing(self):
self.cert.status = CertificateStatuses.unavailable

16
lms/templates/certificates/_accomplishment-footer.html
View File

@@ -7,12 +7,16 @@
</div>
<nav class="footer-app-nav">
<ul class="list list-legal">
<li class="nav-item">
<a class="action btn btn-small btn-link" href="${company_tos_url}">${company_tos_urltext}</a>
</li>
<li class="nav-item">
<a class="action btn btn-small btn-link" href="${company_privacy_url}">${company_privacy_urltext}</a>
</li>
% if company_tos_url is not UNDEFINED:
<li class="nav-item">
<a class="action btn btn-small btn-link" href="${company_tos_url}">${company_tos_urltext}</a>
</li>
% endif
% if company_privacy_url is not UNDEFINED:
<li class="nav-item">
<a class="action btn btn-small btn-link" href="${company_privacy_url}">${company_privacy_urltext}</a>
</li>
% endif
</ul>
</nav>
</footer>