fix pep8 warnings

This commit is contained in:
usamasadiq
2021-02-04 17:27:19 +05:00
parent bbc386752f
commit 1175838fa5
51 changed files with 63 additions and 65 deletions

View File

@@ -1,4 +1,5 @@
# ----------------------------------------------------------------------------- # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
# -----------------------------------------------------------------------------
# class used to store graded responses to CAPA questions
#
# Used by responsetypes and capa_problem
@@ -47,7 +48,7 @@ class CorrectMap(object):
hint='',
hintmode=None,
queuestate=None,
answervariable=None, # lint-amnesty, pylint: disable=C0330, bad-option-value
answervariable=None,
**kwargs
):

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
from abc import ABCMeta, abstractmethod

View File

@@ -212,7 +212,8 @@ class CAPAProblemTest(unittest.TestCase):
Verify that tag with question text is not removed when inputtype is not fully accessible.
"""
question = "Click the country which is home to the Pyramids."
xml = """ # lint-amnesty, pylint: disable=duplicate-string-formatting-argument
# lint-amnesty, pylint: disable=duplicate-string-formatting-argument
xml = """
<problem>
<p>{}</p>
<imageresponse>

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import unittest
import xml.sax.saxutils as saxutils

View File

@@ -1,4 +1,4 @@
# # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
# LMS Interface to external queueing system (xqueue)
#

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=django-not-configured, missing-module-docstring
# lint-amnesty, pylint: disable=django-not-configured, missing-module-docstring
from setuptools import find_packages, setup

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
from setuptools import setup

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import json
import unittest

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=django-not-configured, missing-module-docstring
# lint-amnesty, pylint: disable=django-not-configured, missing-module-docstring
from setuptools import setup
setup(

View File

@@ -1,4 +1,5 @@
#!/usr/bin/python # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
# !/usr/bin/python
# -*- coding: utf-8 -*-
#
# File: symmath_check.py

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
from unittest import TestCase
from six.moves import range

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=django-not-configured, missing-module-docstring
# lint-amnesty, pylint: disable=django-not-configured, missing-module-docstring
from setuptools import find_packages, setup

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging
import textwrap

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging
import os

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
from importlib import import_module

View File

@@ -28,7 +28,7 @@ class MongoContentStore(ContentStore):
"""
MongoDB-backed ContentStore.
"""
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value, unused-argument
# lint-amnesty, pylint: disable=unused-argument
def __init__(
self, host, db,
port=27017, tz_aware=True, user=None, password=None, bucket='fs', collection=None, **kwargs

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
from xmodule.contentstore.content import StaticContent

View File

@@ -1,4 +1,5 @@
class InvalidDefinitionError(Exception): # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
class InvalidDefinitionError(Exception):
pass

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import datetime
import logging

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
from lxml import etree

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import copy
import logging

View File

@@ -387,7 +387,6 @@ class EditInfo(object):
self.original_usage_version = edit_info.get('original_usage_version', None)
def __repr__(self):
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
return ("{classname}(previous_version={self.previous_version}, "
"update_version={self.update_version}, "
"source_version={source_version}, "
@@ -400,7 +399,7 @@ class EditInfo(object):
self=self,
classname=self.__class__.__name__,
source_version="UNSET" if self.source_version is None else self.source_version,
) # lint-amnesty, pylint: disable=bad-continuation, bad-option-value
)
def __eq__(self, edit_info):
"""
@@ -474,7 +473,6 @@ class BlockData(object):
return self.asides
def __repr__(self):
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
return ("{classname}(fields={self.fields}, "
"block_type={self.block_type}, "
"definition={self.definition}, "
@@ -485,7 +483,7 @@ class BlockData(object):
self=self,
classname=self.__class__.__name__,
asides=self.get_asides()
) # lint-amnesty, pylint: disable=bad-continuation, bad-option-value
)
def __eq__(self, block_data):
"""
@@ -1160,14 +1158,14 @@ class ModuleStoreReadBase(BulkOperationsMixin, ModuleStoreRead):
"""
Implement interface functionality that can be shared.
"""
def __init__(
def __init__( # lint-amnesty, pylint: disable=unused-argument
self,
contentstore=None,
doc_store_config=None, # ignore if passed up # lint-amnesty, pylint: disable=unused-argument
doc_store_config=None, # ignore if passed up
metadata_inheritance_cache_subsystem=None, request_cache=None,
xblock_mixins=(), xblock_select=None, xblock_field_data_wrappers=(), disabled_xblock_types=lambda: [], # lint-amnesty, pylint: disable=bad-continuation, bad-option-value
xblock_mixins=(), xblock_select=None, xblock_field_data_wrappers=(), disabled_xblock_types=lambda: [],
# temporary parms to enable backward compatibility. remove once all envs migrated
db=None, collection=None, host=None, port=None, tz_aware=True, user=None, password=None, # lint-amnesty, pylint: disable=unused-argument
db=None, collection=None, host=None, port=None, tz_aware=True, user=None, password=None,
# allow lower level init args to pass harmlessly
** kwargs
):

View File

@@ -1637,8 +1637,8 @@ class MongoModuleStore(ModuleStoreDraftAndPublished, ModuleStoreWriteBase, Mongo
but does NOT return a version agnostic location.
'''
assert location.branch is None
assert revision == ModuleStoreEnum.RevisionOption.published_only \ # lint-amnesty, pylint: disable=consider-using-in
or revision == ModuleStoreEnum.RevisionOption.draft_preferred
assert revision == ModuleStoreEnum.RevisionOption.published_only \
or revision == ModuleStoreEnum.RevisionOption.draft_preferred # lint-amnesty, pylint: disable=consider-using-in
parent_cache = self._get_parent_cache(self.get_branch_setting())
if parent_cache.has(six.text_type(location)):

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging
import sys

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import copy

View File

@@ -1287,7 +1287,7 @@ class SplitMongoModuleStore(SplitBulkWriteMixin, ModuleStoreWriteBase):
Check that the block matches all the criteria
"""
# do the checks which don't require loading any additional data
if ( # lint-amnesty, pylint: disable=bad-continuation, bad-option-value
if (
self._block_matches(block_data, qualifiers) and
self._block_matches(block_data.fields, settings)
):
@@ -1337,7 +1337,7 @@ class SplitMongoModuleStore(SplitBulkWriteMixin, ModuleStoreWriteBase):
for block_id, value in six.iteritems(course.structure['blocks']):
if _block_matches_all(value):
if not include_orphans:
if ( # lint-amnesty, pylint: disable=bad-continuation, bad-option-value
if (
block_id.type in DETACHED_XBLOCK_TYPES or
self.has_path_to_root(block_id, course, path_cache, parents_cache)
):

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import copy
from collections import namedtuple

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging
import re

View File

@@ -47,7 +47,6 @@ class AssetStoreTestData(object):
'edited_by', 'edited_by_email', 'edited_on', 'created_by', 'created_by_email', 'created_on',
'curr_version', 'prev_version'
)
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
all_asset_data = (
('pic1.jpg', 'EKMND332DDBK', 'pix/archive', False,
user_id_long, user_email, now + timedelta(seconds=10 * 1), user_id_long, user_email, now, '14', '13'),
@@ -451,7 +450,6 @@ class TestMongoAssetMetadataStorage(TestCase):
"""
getting all things which are of type other than 'asset'
"""
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
with storebuilder.build() as (__, store):
course = CourseFactory.create(modulestore=store)
@@ -488,7 +486,6 @@ class TestMongoAssetMetadataStorage(TestCase):
"""
Save a list of asset metadata all at once.
"""
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
with storebuilder.build() as (__, store):
course = CourseFactory.create(modulestore=store)
@@ -528,7 +525,6 @@ class TestMongoAssetMetadataStorage(TestCase):
"""
Save a list of asset metadata all at once - but with one asset's metadata from a different course.
"""
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
with storebuilder.build() as (__, store):
course1 = CourseFactory.create(modulestore=store)
course2 = CourseFactory.create(modulestore=store)

View File

@@ -13,7 +13,6 @@ import pymongo
import pytest
import six
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
# pylint: disable=protected-access
from django.test import TestCase
# pylint: enable=E0611

View File

@@ -1024,7 +1024,6 @@ class ElementalDeleteItemTests(DraftPublishedOpBaseTestSetup):
# Weirdly, this is a difference between old Mongo -and- old Mongo wrapped with a mixed modulestore.
# When the code attempts and fails to delete the draft vertical using the published_only revision,
# the draft children are still around in one case and not in the other? Needs investigation.
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
if (
isinstance(modulestore_builder, MongoModulestoreBuilder) and
revision == ModuleStoreEnum.RevisionOption.published_only

View File

@@ -2266,7 +2266,7 @@ def modulestore():
options.update(SplitModuleTest.MODULESTORE['OPTIONS'])
options['render_template'] = render_to_template_mock
# lint-amnesty, pylint: disable=bad-option-value, star-args
# lint-amnesty, pylint: disable=bad-option-value, star-args
SplitModuleTest.modulestore = class_(
None, # contentstore
SplitModuleTest.MODULESTORE['DOC_STORE_CONFIG'],

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import datetime
import os

View File

@@ -95,7 +95,7 @@ def modulestore():
options.update(ModuleStoreNoSettings.MODULESTORE['OPTIONS'])
options['render_template'] = render_to_template_mock
# lint-amnesty, pylint: disable=bad-option-value, star-args
# lint-amnesty, pylint: disable=bad-option-value, star-args
ModuleStoreNoSettings.modulestore = class_(
None, # contentstore
ModuleStoreNoSettings.MODULESTORE['DOC_STORE_CONFIG'],

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import codecs # lint-amnesty, pylint: disable=unused-import
import glob

View File

@@ -21,7 +21,6 @@ logger = logging.getLogger(__name__) # pylint: disable=invalid-name
MONGO_READ_PREFERENCE_MAP = dict(zip(_MONGOS_MODES, _MODES))
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
def connect_to_mongodb(
db, host,
port=27017, tz_aware=True, user=None, password=None,

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging
import random

View File

@@ -1,4 +1,5 @@
import logging # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging
import re
from lxml import etree

View File

@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*- # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
# -*- coding: utf-8 -*-
from lxml import etree

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import json
import unittest

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import unittest

View File

@@ -1,4 +1,5 @@
# -*- coding: utf-8 -*- # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
# -*- coding: utf-8 -*-
import datetime

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import re

View File

@@ -1,4 +1,5 @@
# Same as vertical, # lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
# Same as vertical,
# But w/o css delimiters between children

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import logging
import os
@@ -1481,7 +1481,6 @@ class DescriptorSystem(MetricsMixin, ConfigurableFragmentWrapper, Runtime):
"""
Base class for :class:`Runtime`s to be used with :class:`XModuleDescriptor`s
"""
# lint-amnesty, pylint: disable=bad-continuation, bad-option-value
def __init__(
self, load_item, resources_fs, error_tracker, get_policy=None, disabled_xblock_types=lambda: [], **kwargs
):

View File

@@ -1,4 +1,4 @@
# lint-amnesty, pylint: disable=missing-module-docstring
# lint-amnesty, pylint: disable=missing-module-docstring
import copy
import json

View File

@@ -109,7 +109,7 @@ class DjangoKeyValueStore(KeyValueStore):
Scope.user_info,
)
def __init__(self, field_data_cache):
def __init__(self, field_data_cache): # lint-amnesty, pylint: disable=super-init-not-called
self._field_data_cache = field_data_cache
def get(self, key):

View File

@@ -25,7 +25,7 @@ from mock import patch
from opaque_keys import InvalidKeyError
from opaque_keys.edx.keys import CourseKey
from six import text_type
from six.moves.urllib.parse import urljoin
from six.moves.urllib.parse import urljoin # lint-amnesty, pylint: disable=unused-import
from xblock.field_data import DictFieldData
from xblock.fields import ScopeIds

View File

@@ -1,7 +1,7 @@
# lint-amnesty, pylint: disable=django-not-configured
"""
Tests of the LMS XBlock Mixin
"""
# pylint: disable=cyclic-import
import ddt
from xblock.validation import ValidationMessage

View File

@@ -364,6 +364,7 @@ disable =
no-else-continue,
useless-object-inheritance,
useless-suppression,
cyclic-import,
[REPORTS]
output-format = text