Commit Graph

60364 Commits

Author SHA1 Message Date
Awais Jibran
deba009e25 refactor: remove unused variables (#29304)
I have come across these unused variables and thought it's good to remove and clean up the code.
2021-11-12 00:28:35 +05:00
M. Zulqarnain
d9a91d4c38 BOM-2781: Django codemods on LMS (2) (#28852)
* feat: Django codemods on LMS (2)
2021-11-11 17:52:57 +05:00
Matthew Piatetsky
5dbfae83fc fix: Miscellaneous styling fixes for mobile (#29294)
* fix: Miscellaneous styling fixes for mobile

* fix: Add px fallback since outlook doesn't support rem
2021-11-10 16:47:55 -05:00
edX Transifex Bot
52a2da61f1 geoip2: update maxmind geolite country database 2021-11-11 02:18:37 +05:00
edX Transifex Bot
fe067bab16 chore(i18n): update translations 2021-11-10 21:10:54 +05:00
John Nagro
dbc0e22fa2 fix: release edx-enterprise 3.33.10 (#29298)
ENT-5095
2021-11-10 10:55:44 -05:00
Ned Batchelder
d9dd10dc97 style: code cleanups from Steven Burch (#29292)
* chore: update deprecated import from collections

* chore: remove outdated imports from markdown library

as it hasn't been supported since 2.0.3 and we're on 3.x.
This was deprecated at least as early as 2012!

* docs: add docstring and remove lint-amnesty to markdown plugin

* chore: remove deprecated etree import

* style: remove unnecessary-comprehension for sets

* style: resolve a number of amnestied pylint complaints

Co-authored-by: stvn <stvn@mit.edu>
2021-11-10 07:11:57 -08:00
Chris Deery
1d2319b42a feat: [AA-1082] fix 500 error on courses dashboard (#29290)
feat: [AA-1082] fix 500 error on courses dashboard

When there are no selected blocks, the dict comprehension to
compare is throwing an exception. Handle the error more gracefully.
The blocks will not be sorted, but they should not be filtered.
2021-11-10 09:47:32 -05:00
Mehak Nasir
f0b9fde997 fix: ed-discussion configuration message added (#29295) 2021-11-10 19:35:26 +05:00
Usama Sadiq
20d87061d4 BOM-2983: Pin docutils<0.18 due to Sphinx requirement (#29281)
* fix: pin docutils<0.18 due to Sphinx requirement
2021-11-10 14:27:29 +05:00
Matthew Piatetsky
4822faccc4 [AA-910] Miscellaneous UI fixes and fixed unsubscribe link (#29288)
* fix: use pngs for the goal reminder email banner and remove redundant unsubscribe link

* fix: update

* fix: Miscellaneous UI fixes and fixed unsubscribe link
2021-11-09 13:56:12 -05:00
AsadAzam
49367f4758 feat: added program discussions admin view (#29283)
* feat: added program discussions admin view

* refactor: updated docstring

* refactor: updated constant
2021-11-09 22:35:21 +05:00
David Ormsbee
2d60224125 Merge pull request #28571 from open-craft/jill/bd-13-render_template
feat!: [BD-13] Deprecate ModuleSystem.render_template
2021-11-09 12:20:59 -05:00
Régis Behmo
9ab904fd19 fix: "Uncaught TypeError: n is null" during login to LMS (#29192)
When signing in from the LMS, the authentication request succeeds but
the user was never redirected to the dashboard. This is because of a
js error:

    Uncaught TypeError: userCookie is null
        userFromEdxUserCookie
        http://maple.openedx.overhang.io:8000/static/js/student_account/utils.js:32

The error comes from the fact that the util.js code ignores the
EDXAPP_EDXMKTG_USER_INFO_COOKIE_NAME setting name. Instead the cookie
name is abritrarily prefixed by "stage-" or "prod-" depending on the
hostname. This seems to be primarily motivated by the definition of
edX.org staging/prod environment hostnames :-(

To resolve this issue, we decided that the actual cookie name was not so
important. Instead, the js code needs to not crash even when the cookie
is absent.

This issue was first reported here:
https://github.com/edx/edx-platform/pull/28170#issuecomment-890449885

Close https://github.com/openedx/build-test-release-wg/issues/104
2021-11-09 11:12:24 -05:00
David Ormsbee
0ec2a3b9b5 docs: ADR for removing MongoDB usage. 2021-11-09 10:55:28 -05:00
Matthew Piatetsky
3c0d824701 fix: use pngs for the goal reminder email banner and remove redundant unsubscribe link from the email (#29215)
* fix: use pngs for the goal reminder email banner and remove redundant unsubscribe link

* fix: update
2021-11-09 09:24:58 -05:00
Jason Myatt
25e32477e2 Merge pull request #29180 from open-craft/maxim/bb-4823-fix-issues-with-LANGUAGE-CODE-legacy-UI
fix: fix issues with LANGUAGE_CODE for legacy UI [BB-4823] [OSPR-6196]
2021-11-09 09:22:12 -05:00
Bianca Severino
1fb7058d61 Merge pull request #29278 from edx/bseverino/proctoring-4.7.0
chore: upgrade edx-proctoring to 4.7.0
2021-11-09 09:14:12 -05:00
Andrew Shultz
abe44d561d Merge pull request #29277 from edx/ashultz0/no-idv-dashboard
feat: only show IDV panel until honor code replaces it
2021-11-09 09:09:58 -05:00
Jillian Vogel
26b43465a4 refactor: use MakoService.render_template to remove deprecation warnings
from test code.
2021-11-09 14:03:54 +10:30
Jillian Vogel
8d62d337f5 refactor: use MakoService.render_template to remove deprecation warnings
from block code.
2021-11-09 14:03:54 +10:30
Jillian Vogel
457f959356 refactor: deprecates ModuleSystem.render_template
in favor of the added MakoSystem render_template method.

Related changes:
* Adds the MakoService to the StudioEditModuleRuntime,
  PreviewModuleSystem, LmsModuleSystem, and XBlockRuntime
* MakoService constructor takes a `namespace_prefix` string, so that the
  CMS PreviewModuleSystem can render to LMS templates, without needing
  the special render_from_lms helper method.
* ModuleSystem.render_template becomes a read-only property, so the
  constructor calls and test module systems are updated accordingly.
* Adds tests for the MakoService and module system shims.
2021-11-09 14:03:50 +10:30
Maxim Beder
ec1e3b6e74 fix: fix side-wide language for legacy UI
When side-wide language is set via LANGUAGE_CODE site configuration,
some elements of legacy UI still use the language set in user
preferences (or None, which fallsback to 'en' if nothing is set in
preferences). The expectation is that everything should be translated to
the language which is set in the site configuration.

In legacy UI (i.e. templates) the code of the current language sometimes
is needed, and in these cases `user_language` variable from the context
is used. The value for that variable is inserted via context processor,
which takes the value from the user preferences.

The solution modifies the context processor to check if there is a
language set in site configuration, and if there is, send that value,
instead of whatever value there was in user peferences.
2021-11-09 00:37:43 +01:00
Andy Shultz
6884361bce feat: only show IDV panel until honor code replaces it
the integrity flag is a course waffle flag so until it's on for
everyone this will not be triggered - that's OK and expected

MST-1153
2021-11-08 14:52:13 -05:00
Bianca Severino
e7aa822cf6 chore: upgrade edx-proctoring to 4.7.0 2021-11-08 14:50:31 -05:00
Braden MacDonald
480e8997ec fix: A test (test_save_one_and_confirm) was flaky 2021-11-08 10:46:33 -08:00
Simon Chen
bcf093c1f6 feat: disable idv on dashboard course listing (#29276)
There are messages on each course card on learner dashboard that displays action panels to prompt learners to do IDV. With honor code signature feature on, those panel message should be disabled

Co-authored-by: Simon Chen <schen@edx-c02fw0guml85.lan>
2021-11-08 13:36:40 -05:00
Long Lin
7f797b35ed chore: bump edx-enterprise version to 3.33.9 2021-11-08 11:49:57 -05:00
Tim McCormack
8a764cca10 refactor: Safer, more readable user-mismatch detection code in safe-sessions (#29226)
- Add early exit for readability. Less indentation here may make the control flow easier to read.
- Wrap debug info generation in error-suppressing try-except block.

Co-authored-by: Robert Raposa <rraposa@edx.org>
2021-11-08 16:13:39 +00:00
Justin Hynes
fdeb7714aa Merge pull request #29219 from edx/jhynes/microba-1569_filter_bulk_emails_last_login
feat: filter bulk course email recipients based on last_login date
2021-11-08 09:46:57 -05:00
Bianca Severino
c362507b5d Merge pull request #29267 from edx/bseverino/integrity-signature-flag
[MST-1150] Add integrity signature flag to courseware api
2021-11-08 09:30:18 -05:00
David Ormsbee
15eca3ba59 Merge pull request #29190 from open-craft/jill/BD-13-user-service-fix
[FAL-2457] Let ModuleSystem use UserService
2021-11-08 09:18:10 -05:00
Justin Hynes
e50085401e feat: filter bulk course email recipients based on last_login date
[MICROBA-1569]
- filter bulk course email recipients based on the last_login date of a learner's user account
- introduces a new setting named `BULK_COURSE_EMAIL_LAST_LOGIN_ELIGIBILITY_PERIOD` that sets the login threshold to be included (in months) to a bulk course email message(if set)
2021-11-08 09:14:50 -05:00
Uzair Rasheed
4b0d450d73 Merge pull request #29265 from edx/refactor_hibp_call
refactor: hibp call to celery task
2021-11-08 17:55:53 +05:00
Farhaan Bukhsh
cfe75e95b9 feat: Add discussion_enabled for Unit (#28864)
For each unit discussion_enabled flag is added
so that each unit can be made discussable when needed.

Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
2021-11-08 16:17:07 +05:00
Awais Jibran
1668d74abb feat: gate proctoring card in course apps (#29263)
* feat: gate proctoring card in course apps

* refactor: quality fix

* refactor: quality fix
2021-11-08 16:12:30 +05:00
Bianca Severino
9f2dc8606b fix: add integrity signature flag to courseware api 2021-11-05 15:35:04 -04:00
kenclary
a7181d263e Merge pull request #29269 from edx/kclary/coursegraph
fix: correct path for dump_course_to_neo4j task, so it goes to correct celery queue.
2021-11-05 15:03:49 -04:00
Ken Clary
81f7d10452 fix: correct path for dump_course_to_neo4j task, so it goes to correct celery queue.
TNL-8386
2021-11-05 14:37:33 -04:00
Dillon Dumesnil
ea0a9cf9d3 Merge pull request #29200 from edx/ddumesnil/progress-page-credit-aa-1020
feat: AA-1020: Add Credit Information to Progress tab
2021-11-05 11:07:11 -07:00
uzairr
0f3b3d2763 refactor: hibp call to celery task
Uses is_staff flag to figure out whether the user is internal or not.

Fixes: VAN-664
2021-11-05 18:19:49 +05:00
Waheed Ahmed
100752419e chore: update register identify call traits (#29264)
Updated identify call traits and only include the email_subscribe attribute
if the feature is enabled.
2021-11-05 15:43:15 +05:00
Tim McCormack
fdd27a1f71 feat: Log session ID from various sources after safe-session mismatch (#29185)
Add logging in case a safe-session user mismatch is related to wrong
session being retrieved from cache. This additional logging should
reveal any such mismatch (without revealing the actual session ID in
logs).

Send to metrics as custom attributes as well.

Also:

- Compute "session_id_changed" based on all three session IDs (and
  send as custom attribute)
- Put all _verify_user logs into one (multiline) log line
- Accordingly, change logging assertion to only require a substring,
  at-least-once match rather than a full-and-only match.

ref: ARCHBOM-1939
2021-11-04 19:34:44 +00:00
John Nagro
ccb8c6ce27 fix: release edx-enterprise 3.33.6 (#29222)
ENT-5115
2021-11-04 15:21:07 -04:00
Chris Deery
e96dff1e40 feat: [AA-1087] add flag for enabled proctored exams (#29201)
* feat: [AA-1087] add flag for enabled proctored exams

Add flag to enable frontend to optimize outline tab widget rendering without
having to wait for the proctoring API call to return.
2021-11-04 14:14:50 -04:00
Bianca Severino
ccb4324cd1 Merge pull request #29220 from edx/bseverino/proctoring-4.6.0
chore: upgrade to edx-proctoring to 4.6.0
2021-11-04 13:55:52 -04:00
Bianca Severino
fecf79ad9d chore: upgrade to edx-proctoring to 4.6.0 2021-11-04 11:56:05 -04:00
John Nagro
9fbb1ae645 feat: edx-enterprise 3.33.5 release (#29217)
[3.33.5]
---------
fix: CSOD API session tokens are now saved to the customer's configuration instead of individual transmission audits

[3.33.4]
---------
feat: integrated channels only requests content metadata for courses that need updating

[3.33.3]
---------
feat: Change Bulk Enrollment Assignment Logic for Pending learners

[3.33.2]
---------
fix: no longer notify learners of already existing enrollments

ENT-5115
2021-11-04 09:51:08 -04:00
edX Transifex Bot
20535e12eb geoip2: update maxmind geolite country database 2021-11-04 02:08:52 +05:00
Feanil Patel
18383a5b1a Merge pull request #29214 from edx/feanil/remove_dead_action
build!: Remove unused github action and sql file.
2021-11-03 16:35:24 -04:00