Commit Graph

57292 Commits

Author SHA1 Message Date
Manjinder Singh
cf350f9c44 fix: Correcting logic for xblock_handler token expiration (#26224)
* fix: Correcting logic for xblock_handler token expiration

The previous math had a date math error which resulted in token expiring in 0-2 days
instead of 2-4 days

Co-authored-by: Feanil Patel <feanil@edx.org>
Co-authored-by: Tim McCormack <tmccormack@edx.org>
2021-02-02 10:52:31 -05:00
stvn
12ba5d2b87 Merge PR #25920 bd03/model/filter
* Commits:
  feat: Allow filtering of discussion providers
2021-02-02 07:29:46 -08:00
Kyle McCormick
b626a43fa1 fix: Rename some tasks to match new import paths (#26236)
Several tasks are explicitly named as (or like)
their old, deprecated import path.

The issue here is that django-user-tasks listens for task
invocations, and attempts to import the task based on its name.
If the task name is completely wrong, user-tasks will catch
the ImportError and move on.
If the task is a valid *deprecated* import, though, then
user-tasks will choke on the raised `DeprecatedEdxPlatformImportError`.

Thus, we must rename three tasks to their new full path:
1. entitlements.expire_old_enrollments
2. third_party_auth.fetch_saml_metadata
3. student.send_activation_email

The first two are run daily, and so are safe to be
renamed in place.

The third task must be renamed using an expand-contract
pattern; otherwise, we would drop hundreds of tasks
during the App vs. Worker out-of-sync version window
that happens at deployments.
This commit is the expand phase.
2021-02-02 10:26:08 -05:00
Usama Sadiq
29d715d82d Merge pull request #26301 from edx/test
Applied pylint-amnesty to pipeline_mako
2021-02-02 20:19:11 +05:00
Usama Sadiq
a5143e063d Merge pull request #26302 from edx/amnesty-static-replace
Applied pylint-amnesty to static_replace
2021-02-02 20:19:00 +05:00
stvn
cff2cb8941 feat: Allow filtering of discussion providers
Propose and implement organization-wide discussion-provider filtering.

Fixes: TNL-7814
2021-02-02 06:51:41 -08:00
jawad khan
8529e433b8 Added completion from root to child blocks api and increased version
* Added completion from root to child blocks api and increased version
Learner-8158
2021-02-02 19:51:14 +05:00
Jawayria
edfced071d Resolved quality errors 2021-02-02 19:19:33 +05:00
Jawayria
4dad2ab406 Applied pylint-amnesty to static_replace 2021-02-02 19:19:33 +05:00
Christie Rice
ad3ab3712e MICROBA-918 Remove unused variables, standardize imports, and use factories in tests (#26291) 2021-02-02 09:00:18 -05:00
Jawayria
3f1fd27534 Resolved quality error 2021-02-02 18:36:41 +05:00
Jawayria
6f06cc5e05 Applied pylint-amnesty to pipeline_mako 2021-02-02 18:32:11 +05:00
Usama Sadiq
0cad2f6feb Merge pull request #26322 from edx/usamasadiq/lower-pylint-upper-threshold
Lower the UPPER_PYLINT_THRESHOLD to 5900
2021-02-02 17:58:24 +05:00
usamasadiq
96bb6657a5 Lower the UPPER_PYLINT_THRESHOLD to 5900 2021-02-02 17:23:16 +05:00
Usama Sadiq
2eb4298c08 Merge pull request #26318 from edx/bom-2312
Applied pylint-amnesty to common/{lib, test, __init__.py}
2021-02-02 16:52:00 +05:00
Usama Sadiq
84deed7ad8 Merge pull request #26314 from edx/amnesty-xblockdjango
Applied pylint-amnesty to xblock_django
2021-02-02 16:51:12 +05:00
Usama Sadiq
390429f8fb Merge pull request #26306 from edx/amnesty-terrain
Applied pylint-amnesty to terrain
2021-02-02 16:51:01 +05:00
Usama Sadiq
8f919bdbe1 Merge pull request #26303 from edx/amnesty-status
Applied pylint-amnesty to status
2021-02-02 16:50:46 +05:00
Usama Sadiq
c4e21bf75f Merge pull request #26315 from edx/usamasadiq/bom-2307-pylint-amnesty
Applied pylint-amnesty
2021-02-02 16:46:44 +05:00
Usama Sadiq
28b5e533f7 Merge pull request #26316 from edx/2306-bom
BOM-2306 : pylint amnesty in cms apps
2021-02-02 16:44:24 +05:00
Usama Sadiq
661dc522f7 Merge pull request #26283 from edx/BOM-2282
BOM-2282
2021-02-02 16:41:02 +05:00
Usama Sadiq
56ec289fd8 Merge pull request #26295 from edx/BOM-2283
BOM-2283
2021-02-02 16:40:42 +05:00
Usama Sadiq
851eed1699 Merge pull request #26296 from edx/BOM-2284
BOM-2284
2021-02-02 16:40:17 +05:00
Usama Sadiq
5fde0ad27e Merge pull request #26297 from edx/BOM-2285
BOM-2285
2021-02-02 16:39:57 +05:00
Usama Sadiq
1cacd0cda5 Merge pull request #26298 from edx/BOM-2286
BOM-2286
2021-02-02 16:39:27 +05:00
Jawayria
9e677960bf Applied pylint-amnesty to common/{lib, test, __init__.py} 2021-02-02 15:42:02 +05:00
Zulqarnain
ffb9e6cb4b pylint amnesty in cms apps 2021-02-02 15:31:33 +05:00
usamasadiq
8556d670a2 Applied pylint-amnesty 2021-02-02 15:29:41 +05:00
Jawayria
f3846144a5 Applied pylint-amnesty to xblock_django 2021-02-02 15:09:08 +05:00
Jawayria
fb6a62b753 Applied pylint-amnesty to terrain 2021-02-02 14:37:08 +05:00
Zaman Afzal
712a6bcc0c ENT-4034 Added more detail in exception (#26299) 2021-02-02 13:54:20 +05:00
Jawayria
44664d6a52 Merge pull request #26284 from edx/py-amnesty-coursewiki
Applied pylint-amnesty to course_wiki
2021-02-02 13:46:47 +05:00
Jawayria
c1e33c96c1 Merge pull request #26282 from edx/py-amnesty-commerce
Applied pylint-amnesty to commerce
2021-02-02 13:46:29 +05:00
Jawayria
10887e520e Merge pull request #26279 from edx/py-amnesty-ccx
Applied pylint-amnesty to ccx
2021-02-02 13:46:13 +05:00
Jawayria
bcfa24ad43 Merge pull request #26277 from edx/py-amnesty-branding
Applied pylint-amnesty to branding
2021-02-02 13:45:46 +05:00
Jawayria
3ce03896af Applied pylint-amnesty to status 2021-02-02 13:38:45 +05:00
Awais Qureshi
08f3ea6852 BOM-2286
Apply pylint-amnesty.
2021-02-02 13:29:06 +05:00
M. Zulqarnain
d9b9f21e22 pylint amnesty in LMS root (#26276) 2021-02-02 12:52:24 +05:00
edX requirements bot
df89e6d2d2 Updating Python Requirements (#26294) 2021-02-02 12:42:55 +05:00
Awais Qureshi
5510dc1c43 BOM-2286
Apply pylint-amnesty.
2021-02-02 12:39:06 +05:00
Awais Qureshi
ea26268b0a BOM-2285
Apply pylint-amnesty.
2021-02-02 12:09:42 +05:00
Awais Qureshi
1f7b33f9bd BOM-2284
Apply pylint-amnesty.
2021-02-02 11:39:28 +05:00
Awais Qureshi
07599e930c BOM-2284
Apply pylint-amnesty.
2021-02-02 11:37:56 +05:00
Awais Qureshi
aeca77e633 BOM-2283
Apply pylint-amnesty.
2021-02-02 11:33:01 +05:00
Awais Qureshi
28307c0a0a BOM-2283
Apply pylint-amnesty.
2021-02-02 11:31:34 +05:00
Awais Qureshi
d24a1401ae BOM-2282
Apply pylint-amnesty.
2021-02-02 10:47:24 +05:00
Robert Raposa
eba1e282da Merge pull request #26175 from open-craft/nizar/tsd-block-structure-storage-caching
[TSD] Annotates block structures settings and waffle switches
2021-02-01 16:53:04 -05:00
Adam Stankiewicz
c99b7a12ce bump edx-enterprise to 3.17.16 (#26289) 2021-02-01 15:44:06 -05:00
Robert Raposa
6e6b6901a0 Merge pull request #26040 from regisb/regisb/remove-waffle-custom-monitoring
[BD-21] Remove soon-to-be-deprecated value monitor in edx-toggles
2021-02-01 14:56:35 -05:00
Nizar Mahmoud
fa9746a714 Annotates block structures settings and waffle switches
This includes the following settings:

- BLOCK_STRUCTURES_SETTINGS : setting dictionary which stores the other different block structures related settings

- BLOCK_STRUCTURES_SETTINGS['PRUNING_ACTIVE'] : keeps only a specific number of versions of each block structure, and deletes the rest

- BLOCK_STRUCTURES_SETTINGS['COURSE_PUBLISH_TASK_DELAY'] : specifies the delay, in seconds, after a new edit of a course is published before updating the block structures cache

- BLOCK_STRUCTURES_SETTINGS['TASK_DEFAULT_RETRY_DELAY'] : Specifies the delay, in seconds, between retry attempts for block structure tasks

- BLOCK_STRUCTURES_SETTINGS['TASK_MAX_RETRIES'] : specifies the max number of retries per block structure task

- BLOCK_STRUCTURES_SETTINGS['STORAGE_CLASS'] : specifies the storage which block structures would be saved to when storage backed block structures are enabled

    Example: 'storages.backends.s3boto.S3BotoStorage'

- BLOCK_STRUCTURES_SETTINGS['STORAGE_KWARGS'] : specifies additional arguments needed when utilizing storage for storing storage backed block structures

    Example: { bucket: 'test-edxapp' }

- BLOCK_STRUCTURES_SETTINGS['DIRECTORY_PREFIX'] : specifies the path to which storage backed block structures are saved

    Example: '/courses/'

This also includes the following waffle switches:

- block_structure.storage_backing_for_cache : enables storage backed block structures, used to retrieve the block structures from storage instead of regenerating the structure, when not available in cache

    it is important to note that this is important for production because it reduces response times on block structure related apis

- block_structure.raise_error_when_not_found : raises an error if the block structure requested doesnt exist in store or is outdated

- block_structure.invalidate_cache_on_publish : invalidates the block structure cache when courses are published

For an example with additional context, see the following forum post:

https://discuss.openedx.org/t/help-please-very-slow-load-time-10-seconds-for-courseware-on-sections-with-several-subsections-and-xblocks/2998/16

This also includes information about the toggles that will likely be deprecated and removed:

https://github.com/edx/edx-platform/pull/26175#issuecomment-769080286
2021-02-01 22:55:14 +03:00