Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #26306 from edx/amnesty-terrain

Browse Source 
Applied pylint-amnesty to terrain
This commit is contained in:
Usama Sadiq
2021-02-02 16:51:01 +05:00
committed by GitHub
parent 8f919bdbe1 fb6a62b753
commit 390429f8fb
12 changed files with 31 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/djangoapps/terrain/stubs/catalog.py
View File

@@ -11,9 +11,9 @@ import six.moves.urllib.parse
from .http import StubHttpRequestHandler, StubHttpService
class StubCatalogServiceHandler(StubHttpRequestHandler):
class StubCatalogServiceHandler(StubHttpRequestHandler): # lint-amnesty, pylint: disable=missing-class-docstring
def do_GET(self):
def do_GET(self): # lint-amnesty, pylint: disable=missing-function-docstring
pattern_handlers = {
r'/api/v1/programs/$': self.program_list,
r'/api/v1/programs/([0-9a-f-]+)/$': self.program_detail,

20
common/djangoapps/terrain/stubs/comments.py
View File

@@ -11,13 +11,13 @@ import six.moves.urllib.parse
from .http import StubHttpRequestHandler, StubHttpService
class StubCommentsServiceHandler(StubHttpRequestHandler):
class StubCommentsServiceHandler(StubHttpRequestHandler): # lint-amnesty, pylint: disable=missing-class-docstring
@property
def _params(self):
return six.moves.urllib.parse.parse_qs(six.moves.urllib.parse.urlparse(self.path).query)
def do_GET(self):
def do_GET(self): # lint-amnesty, pylint: disable=missing-function-docstring
pattern_handlers = OrderedDict([
("/api/v1/users/(?P<user_id>\\d+)/active_threads$", self.do_user_profile),
("/api/v1/users/(?P<user_id>\\d+)$", self.do_user),
@@ -32,7 +32,7 @@ class StubCommentsServiceHandler(StubHttpRequestHandler):
self.send_response(404, content="404 Not Found")
def match_pattern(self, pattern_handlers):
def match_pattern(self, pattern_handlers): # lint-amnesty, pylint: disable=missing-function-docstring
path = six.moves.urllib.parse.urlparse(self.path).path
for pattern in pattern_handlers:
match = re.match(pattern, path)
@@ -51,11 +51,11 @@ class StubCommentsServiceHandler(StubHttpRequestHandler):
return
self.send_response(204, "")
def do_put_user(self, user_id):
def do_put_user(self, user_id): # lint-amnesty, pylint: disable=unused-argument
self.server.config['default_sort_key'] = self.post_dict.get("default_sort_key", "date")
self.send_json_response({'username': self.post_dict.get("username"), 'external_id': self.post_dict.get("external_id")})
self.send_json_response({'username': self.post_dict.get("username"), 'external_id': self.post_dict.get("external_id")}) # lint-amnesty, pylint: disable=line-too-long
def do_DELETE(self):
def do_DELETE(self): # lint-amnesty, pylint: disable=missing-function-docstring
pattern_handlers = {
"/api/v1/comments/(?P<comment_id>\\w+)$": self.do_delete_comment
}
@@ -63,7 +63,7 @@ class StubCommentsServiceHandler(StubHttpRequestHandler):
return
self.send_json_response({})
def do_user(self, user_id):
def do_user(self, user_id): # lint-amnesty, pylint: disable=missing-function-docstring
response = {
"id": user_id,
"default_sort_key": self.server.config.get("default_sort_key", "date"),
@@ -78,7 +78,7 @@ class StubCommentsServiceHandler(StubHttpRequestHandler):
})
self.send_json_response(response)
def do_user_profile(self, user_id):
def do_user_profile(self, user_id): # lint-amnesty, pylint: disable=missing-function-docstring, unused-argument
if 'active_threads' in self.server.config:
user_threads = self.server.config['active_threads'][:]
params = self._params
@@ -94,13 +94,13 @@ class StubCommentsServiceHandler(StubHttpRequestHandler):
else:
self.send_response(404, content="404 Not Found")
def do_thread(self, thread_id):
def do_thread(self, thread_id): # lint-amnesty, pylint: disable=missing-function-docstring
if thread_id in self.server.config.get('threads', {}):
thread = self.server.config['threads'][thread_id].copy()
params = six.moves.urllib.parse.parse_qs(six.moves.urllib.parse.urlparse(self.path).query)
if "recursive" in params and params["recursive"][0] == "True":
thread.setdefault('children', [])
resp_total = thread.setdefault('resp_total', len(thread['children']))
resp_total = thread.setdefault('resp_total', len(thread['children'])) # lint-amnesty, pylint: disable=unused-variable
resp_skip = int(params.get("resp_skip", ["0"])[0])
resp_limit = int(params.get("resp_limit", ["10000"])[0])
thread['children'] = thread['children'][resp_skip:(resp_skip + resp_limit)]

4
common/djangoapps/terrain/stubs/edxnotes.py
View File

@@ -107,7 +107,7 @@ class StubEdxNotesServiceHandler(StubHttpRequestHandler):
self.send_response(200, headers={
"Access-Control-Allow-Origin": "*",
"Access-Control-Allow-Methods": "GET, POST, PUT, DELETE, OPTIONS",
"Access-Control-Allow-Headers": "Content-Length, Content-Type, X-Annotator-Auth-Token, X-Requested-With, X-Annotator-Auth-Token, X-Requested-With, X-CSRFToken",
"Access-Control-Allow-Headers": "Content-Length, Content-Type, X-Annotator-Auth-Token, X-Requested-With, X-Annotator-Auth-Token, X-Requested-With, X-CSRFToken", # lint-amnesty, pylint: disable=line-too-long
})
def respond(self, status_code=200, content=None):
@@ -300,7 +300,7 @@ class StubEdxNotesService(StubHttpService):
HANDLER_CLASS = StubEdxNotesServiceHandler
def __init__(self, *args, **kwargs):
super(StubEdxNotesService, self).__init__(*args, **kwargs)
super(StubEdxNotesService, self).__init__(*args, **kwargs) # lint-amnesty, pylint: disable=super-with-arguments
self.notes = list()
def get_all_notes(self):

2
common/djangoapps/terrain/stubs/http.py
View File

@@ -117,7 +117,7 @@ class StubHttpRequestHandler(BaseHTTPRequestHandler, object):
for key, list_val in post_dict.items()
}
except:
except: # lint-amnesty, pylint: disable=bare-except
return dict()
@lazy

2
common/djangoapps/terrain/stubs/start.py
View File

@@ -78,7 +78,7 @@ def _parse_config_args(args):
if len(components) >= 2:
config_dict[components[0]] = "=".join(components[1:])
except:
except: # lint-amnesty, pylint: disable=bare-except
print("Warning: could not interpret config value '{0}'".format(config_str))
return config_dict

2
common/djangoapps/terrain/stubs/tests/test_edxnotes.py
View File

@@ -24,7 +24,7 @@ class StubEdxNotesServiceTest(unittest.TestCase):
"""
Start the stub server.
"""
super(StubEdxNotesServiceTest, self).setUp()
super(StubEdxNotesServiceTest, self).setUp() # lint-amnesty, pylint: disable=super-with-arguments
self.server = StubEdxNotesService()
dummy_notes = self._get_dummy_notes(count=5)
self.server.add_notes(dummy_notes)

8
common/djangoapps/terrain/stubs/tests/test_http.py
View File

@@ -12,10 +12,10 @@ import six
from common.djangoapps.terrain.stubs.http import StubHttpRequestHandler, StubHttpService, require_params
class StubHttpServiceTest(unittest.TestCase):
class StubHttpServiceTest(unittest.TestCase): # lint-amnesty, pylint: disable=missing-class-docstring
def setUp(self):
super(StubHttpServiceTest, self).setUp()
super(StubHttpServiceTest, self).setUp() # lint-amnesty, pylint: disable=super-with-arguments
self.server = StubHttpService()
self.addCleanup(self.server.shutdown)
self.url = "http://127.0.0.1:{0}/set_config".format(self.server.port)
@@ -71,7 +71,7 @@ class StubHttpServiceTest(unittest.TestCase):
self.assertEqual(response.status_code, 404)
class RequireRequestHandler(StubHttpRequestHandler):
class RequireRequestHandler(StubHttpRequestHandler): # lint-amnesty, pylint: disable=missing-class-docstring
@require_params('GET', 'test_param')
def do_GET(self):
self.send_response(200)
@@ -91,7 +91,7 @@ class RequireParamTest(unittest.TestCase):
"""
def setUp(self):
super(RequireParamTest, self).setUp()
super(RequireParamTest, self).setUp() # lint-amnesty, pylint: disable=super-with-arguments
self.server = RequireHttpService()
self.addCleanup(self.server.shutdown)
self.url = "http://127.0.0.1:{port}".format(port=self.server.port)

4
common/djangoapps/terrain/stubs/tests/test_lti_stub.py
View File

@@ -20,7 +20,7 @@ class StubLtiServiceTest(unittest.TestCase):
Used for lettuce BDD tests in lms/courseware/features/lti.feature
"""
def setUp(self):
super(StubLtiServiceTest, self).setUp()
super(StubLtiServiceTest, self).setUp() # lint-amnesty, pylint: disable=super-with-arguments
self.server = StubLtiService()
self.uri = 'http://127.0.0.1:{}/'.format(self.server.port)
self.launch_uri = self.uri + 'correct_lti_endpoint'
@@ -60,7 +60,7 @@ class StubLtiServiceTest(unittest.TestCase):
self.assertIn(b'Wrong LTI signature', response.content)
@patch('common.djangoapps.terrain.stubs.lti.signature.verify_hmac_sha1', return_value=True)
def test_success_response_launch_lti(self, check_oauth):
def test_success_response_launch_lti(self, check_oauth): # lint-amnesty, pylint: disable=unused-argument
"""
Success lti launch.
"""

2
common/djangoapps/terrain/stubs/tests/test_video.py
View File

@@ -33,7 +33,7 @@ class StubVideoServiceTest(unittest.TestCase):
"""
Start the stub server.
"""
super(StubVideoServiceTest, self).setUp()
super(StubVideoServiceTest, self).setUp() # lint-amnesty, pylint: disable=super-with-arguments
self.server = VideoSourceHttpService()
self.server.config['root_dir'] = '{}/data/video'.format(settings.TEST_ROOT)
self.addCleanup(self.server.shutdown)

8
common/djangoapps/terrain/stubs/tests/test_xqueue_stub.py
View File

@@ -17,17 +17,17 @@ class FakeTimer(object):
"""
Fake timer implementation that executes immediately.
"""
def __init__(self, delay, func):
def __init__(self, delay, func): # lint-amnesty, pylint: disable=unused-argument
self.func = func
def start(self):
self.func()
class StubXQueueServiceTest(unittest.TestCase):
class StubXQueueServiceTest(unittest.TestCase): # lint-amnesty, pylint: disable=missing-class-docstring
def setUp(self):
super(StubXQueueServiceTest, self).setUp()
super(StubXQueueServiceTest, self).setUp() # lint-amnesty, pylint: disable=super-with-arguments
self.server = StubXQueueService()
self.url = "http://127.0.0.1:{0}/xqueue/submit".format(self.server.port)
self.addCleanup(self.server.shutdown)
@@ -119,7 +119,7 @@ class StubXQueueServiceTest(unittest.TestCase):
self.assertFalse(self.post.called)
self.assertTrue(logger.error.called)
def _post_submission(self, callback_url, lms_key, queue_name, xqueue_body):
def _post_submission(self, callback_url, lms_key, queue_name, xqueue_body): # lint-amnesty, pylint: disable=unused-argument
"""
Post a submission to the stub XQueue implementation.
`callback_url` is the URL at which we expect to receive a grade response

4
common/djangoapps/terrain/stubs/tests/test_youtube_stub.py
View File

@@ -10,10 +10,10 @@ import requests
from ..youtube import StubYouTubeService
class StubYouTubeServiceTest(unittest.TestCase):
class StubYouTubeServiceTest(unittest.TestCase): # lint-amnesty, pylint: disable=missing-class-docstring
def setUp(self):
super(StubYouTubeServiceTest, self).setUp()
super(StubYouTubeServiceTest, self).setUp() # lint-amnesty, pylint: disable=super-with-arguments
self.server = StubYouTubeService()
self.url = "http://127.0.0.1:{0}/".format(self.server.port)
self.server.config['time_to_response'] = 0.0

2
common/djangoapps/terrain/stubs/youtube.py
View File

@@ -91,7 +91,7 @@ class StubYouTubeHandler(StubHttpRequestHandler):
youtube_id = params.path.split('/').pop()
if self.server.config.get('youtube_api_private_video'):
self._send_private_video_response(youtube_id, "I'm youtube private video.")
self._send_private_video_response(youtube_id, "I'm youtube private video.") # lint-amnesty, pylint: disable=too-many-function-args
else:
self._send_video_response(youtube_id, "I'm youtube.")