Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
57,525 Commits 1 Branch 0 Tags
9dfd38bb2c5ab0de1db0541240ca805aef0fb483
Commit Graph

57525 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Usama Sadiq
9dfd38bb2c Merge pull request #26431 from edx/usamasadiq/lower-pylint-upper-threshold 
Lower down pylint error thresholds
 2021-02-09 00:44:18 +05:00
Matt Tuchfarber
cabb5d928f Merge pull request #26292 from edx/tuchfarber/add_consistent_logging_credentials_tasks 
Make credentials celery tasks errors consistent
 2021-02-08 14:40:35 -05:00
Alexander J Sheehan
0bfb60e9ac Merge pull request #26438 from edx/alex-sheehan-edx/bumping-enterprise-to-3.17.24 
bumping enterprise to 3.17.24
 2021-02-08 14:25:21 -05:00
Tim McCormack
80a4437f33 fix: Always save generated anonymous user ID in DB; ignore save=False (#26399) 
This deprecates `save=False` for several functions and removes all known
usages of the parameter but does not actually remove the parameter.
Instead, it will emit a deprecation warning if the parameter is used.
We can remove the parameter as soon as we feel sure nothing is using it.

Now that we have refactored `anonymous_id_for_user` to always prefer
retrieving an existing ID from the database -- and observed that only a
small fraction of calls pass save=False -- we can stop respecting
save=False. This opens the door for future improvements, such as generating
random IDs or switching to the external user ID system.

Metrics: I observe that 1 in 16 requests for new, non-request-cached
anon user IDs are made with save=False. But 71% of all calls are served
from the request cache, and 99.7% of the misses are served from the DB.
save=False only appear to come from intermittent spikes as reports are
generated and are low in absolute number.

Also document usage/risk/rotation of secret in anonymous user ID
generation as indicated by `docs/decisions/0008-secret-key-usage.rst`
ADR on `SECRET_KEY` usage.

ref: ARCHBOM-1683
 2021-02-08 19:16:05 +00:00
usamasadiq
ab678daaa5 Lower down pylint error thresholds 2021-02-09 00:15:33 +05:00
Matt Tuchfarber
64032faae7 Make credentials celery tasks errors consistent 
In order to better alert off of tasks that failed after maximum retries,
this makes the the error for each task consistent with itself.
 2021-02-08 13:55:35 -05:00
Bianca Severino
54505b82c4 Merge pull request #26436 from edx/bseverino/proctoring-check-fix 
[MST-645] Account for no enrollment in courseware rules
 2021-02-08 13:39:40 -05:00
Carla Duarte
a3f0050c4d Merge pull request #26396 from edx/ciduarte/depr-keys 
AA-650: block deprecated keys from course home MFE
 2021-02-08 13:27:58 -05:00
Alexander Sheehan
749b630c55 bumping enterprise to 3,17,24- am also responsible for and ok with 23 going out 2021-02-08 13:20:18 -05:00
Bianca Severino
4fb36709a5 Account for no enrollment in courseware rules 2021-02-08 13:12:52 -05:00
Matt Tuchfarber
eac7904a7f Merge pull request #26434 from edx/tuchfarber/update_pylint 
Update to newest edx-lint
 2021-02-08 13:02:07 -05:00
Carla Duarte
8d2d78dc61 AA-650: block deprecated keys from course home MFE 2021-02-08 13:00:36 -05:00
Matt Tuchfarber
978183bfc6 Update to newest edx-lint 
Copy existing pylintrc changes to pylintrc_tweaks
 2021-02-08 12:26:47 -05:00
Feanil Patel
03d2d983ea Merge pull request #26392 from edx/feanil/rate_limit_anon_csv 
Feanil/rate limit anon csv
 2021-02-08 12:05:21 -05:00
Fox Piacenti
c840e6f9bb Update Library v2 Indexes to work with ElasticSearch 7. Repair blockstore integration tests. (#26230) 2021-02-08 11:55:47 -05:00
Christie Rice
367d2a07c9 Fix lint-amnesty warnings (#26411) 2021-02-08 10:49:32 -05:00
Usama Sadiq
1dca1835ce Merge pull request #26429 from edx/BOM-2334 
Apply pylint-amnesty.
 2021-02-08 20:46:15 +05:00
Gábor Boros
dd55860da1 [TSD] [SE-3988] add annotations to instructor plugin settings (#26202) 
docs: add annotations to instructor plugin settings
 2021-02-08 10:45:26 -05:00
Tim McCormack
b8a6e30bd9 fix: Add new proctoring key to Studio devstack & tests envs (copy from LMS) (#26430) 
Turns out it's needed for the Proctoring Settings view.

Also reorder slightly for better clustering.

MST-644
 2021-02-08 15:43:51 +00:00
Awais Qureshi
7ee49390bb BOM-2334 
Apply pylint-amnesty.
 2021-02-08 20:12:45 +05:00
Usama Sadiq
045a3dc249 Merge pull request #26422 from edx/BOM-2337 
Apply pylint-amnesty.
 2021-02-08 20:09:34 +05:00
Usama Sadiq
325d4ec770 Merge pull request #26423 from edx/BOM-2338 
Apply pylint-amnesty.
 2021-02-08 20:09:12 +05:00
Christie Rice
6e5a9f5f6f MICROBA-918 Move methods to separate certificate generation from celery task to schedule certificate generation. Also standardizes imports. (#26410) 2021-02-08 10:01:04 -05:00
edx-pipeline-bot
930980d732 Merge pull request #26427 from edx/private_to_public_01b389b 
Mergeback PR from private to public.
 2021-02-08 09:36:23 -05:00
Usama Sadiq
9ab240f87e Merge pull request #26380 from edx/usamasadiq/bom-2312-pylint-amnesty-common-lib 
Applied pylint-amnesty
 2021-02-08 18:57:01 +05:00
Usama Sadiq
eb2f8e791b Merge pull request #26382 from edx/usamasadiq/bom-2327-pylint-amnesty 
Applied pylint amnesty
 2021-02-08 18:56:01 +05:00
Usama Sadiq
1bb06669e3 Merge branch 'master' into usamasadiq/bom-2312-pylint-amnesty-common-lib 2021-02-08 18:26:15 +05:00
Usama Sadiq
7eb2c40106 Merge branch 'master' into usamasadiq/bom-2327-pylint-amnesty 2021-02-08 18:24:53 +05:00
Usama Sadiq
90666a6231 Merge pull request #26311 from edx/usamasadiq/bom-2305-pylint-amnesty 
Applied pylint-amnesty
 2021-02-08 18:23:34 +05:00
Muhammad Soban Javed
108859a550 Merge pull request #25954 from edx/iamsobanjaved/celery-tasks-openedx 
Replace @task decorator with @shared_task in openedx
 2021-02-08 18:23:22 +05:00
Usama Sadiq
78087152b8 Merge pull request #26387 from edx/usamasadiq/bom-2333-pylint-amnesty 
Applied pylint amnesty
 2021-02-08 18:20:51 +05:00
JayRam Nai
17cde562da docs: Add annotations for ENABLE_FOOTER_MOBILE_APP_LINKS feature flag (#26389) 
docs: update warning for ENABLE_FOOTER_MOBILE_APP_LINKS features toggle
 2021-02-08 07:58:09 -05:00
JayRam Nai
16cc57dc7d docs: Add annotations for EDITABLE_SHORT_DESCRIPTION feature flag (#26401) 2021-02-08 07:56:48 -05:00
Ali Akbar
01b389b73a Merge pull request #221 from edx/IM/security-fixes-10 
Incident Management Security Fixes 10
 2021-02-08 17:46:16 +05:00
Ali Akbar
06cfaa2d88 Merge pull request #220 from edx/IM/security-fixes-9 
Incident Management Security Fixes 9
 2021-02-08 17:46:06 +05:00
Awais Qureshi
7321e9e5eb BOM-2338 
Apply pylint-amnesty.
 2021-02-08 17:42:01 +05:00
Awais Qureshi
41b50237d3 BOM-2337 
Apply pylint-amnesty.
 2021-02-08 17:12:55 +05:00
usamasadiq
1175838fa5 fix pep8 warnings 2021-02-08 16:08:01 +05:00
M. Zulqarnain
047a5f5f19 BOM-2319 : Pylint amnesty in openedx content apps (#26347) 
* pylint amnesty in openedx content apps

Co-authored-by: Jawayria <jawayriahashmi@gmail.com>
 2021-02-08 15:51:22 +05:00
usamasadiq
7bbde8f0f5 Applied pylint-amnesty 2021-02-08 13:00:22 +05:00
usamasadiq
e6d43ac69c Applied pylint amnesty 2021-02-08 12:45:57 +05:00
M. Zulqarnain
3db1a21263 BOM-2247 : Upgrade pip-tools (#26192) 
* Upgrade pip-tools

* Updating Python Requirements (#26191)

Co-authored-by: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com>
 2021-02-08 12:42:05 +05:00
edX requirements bot
cdeb430f68 Updating Python Requirements (#26418) 2021-02-08 12:19:01 +05:00
JayRam Nai
f5ba226c71 docs: Add annotations for ENABLE_DJANGO_ADMIN_SITE feature flag (#26388) 2021-02-06 11:04:22 -05:00
JayRam Nai
c658a4719b docs: Adds annotations for HIDE_DASHBOARD_COURSES_UNTIL_ACTIVATED feature flag (#26403) 2021-02-06 10:48:10 -05:00
Uzair Rasheed
6522bbdc43 Merge pull request #26413 from edx/reset-password-success-email 
reset-password-success-email
 2021-02-06 17:01:01 +05:00
uzairr
d86550e1a3 reset-password-success-email 2021-02-06 15:41:56 +05:00
Felipe Montoya
081a334fb8 Merge pull request #26212 from eduNEXT/lmm/annotation_mfe_urls 
[TSD] Add annotations for MFE URL settings
 2021-02-05 17:51:05 -05:00
Felipe Montoya
aba34c506e Merge pull request #26406 from jramnai/tsd-enable_student_history_view 
[TSD] docs: Add annotations for ENABLE_STUDENT_HISTORY_VIEW feature flag
 2021-02-05 17:50:41 -05:00
Aarif
b3b8e81148 replaced unittest assertions pytest assertions (#26267) 2021-02-05 23:54:11 +05:00