Commit Graph

22032 Commits

Author SHA1 Message Date
Awais Jibran
90776770dc Revert ".is-hidden" CSS hack and related hint fix (#25938)
Reverts two PRs:
* "Fix hiding of completion/bookmark indicators in legacy courseware (#25919)"
* "Fix hint show" (#25930)

TNL-7845
2020-12-23 11:35:25 -05:00
David Ormsbee
5dac11948a Add user_tasks to LMS (for Django admin access). (#25933)
The user_tasks app is used by Studio import/export and not used by
anything in the LMS. But because our app-permissions user/role
provisioning script invokes the LMS process, any app+permission
listed there must exist in the LMS or the provisioning fails. So
this commit adds the user_tasks app to the LMS list of installed
apps because it's a lot faster than getting app-permissions to do
the right thing.
2020-12-22 15:38:19 -05:00
Simon Chen
78407b4a8f MST-400 Update the support verification_api to provide the correct status under the same API used by learner (#25917) 2020-12-21 09:14:57 -05:00
Kyle McCormick
a03bb13492 Fix hiding of completion/bookmark indicators in legacy courseware (#25919)
In the edx.org-next theme, the completion green check-
marks and the little bookmark icons were appearing on every
single unit. This was because a fontawesome CSS rule
in the new theme was overriding the `display: none`,
as set by `.is-hidden`, to be `display: inline: block`.

The fix is to add `!important` to a couple definitions
of `.is-hidden`. Definitely somewhat hacky, but this is
SCSS that we plan to deprecate at some point anyway.

TNL-7823
2020-12-18 17:08:13 -05:00
Kyle McCormick
54d5f7f394 Course Blocks API: Fix handling of incorrectly-cased course keys (#25911)
Commit 7f59688 attempted to solve this using
`CourseOverview.course_exists`, but that check is case-
insensitive. This commit instead does a small refactor
to `lms.djangoapps.courseware.get_course` so that we can
handle a failed course lookup without broadly catching
a `ValueError`.
2020-12-18 11:26:29 -05:00
alangsto
30d4106659 added endpoint to retrieve IDV photo urls (#25909)
fixed quality issues

added comment

updated for comments

fixing test

removed typo

readded files

moved settings override

testing adding other keys

not overriding setting
2020-12-18 08:14:44 -05:00
stvn
39acbf2f21 Implement a new configuration system for discussions plugins
Additional details available in the attached decisions document.

Co-authored-by: Kshitij Sobti <kshitij@sobti.in>
Co-authored-by: stvn <stvn@mit.edu>
2020-12-17 18:23:46 -08:00
Kyle McCormick
7f59688f9b Course Blocks API: Return 403 instead of 500 for unknown courses (#25906)
Anonymous users (like crawlers) requesting non-existent courses
should get 403, just like logged-in users do. They instead raised
a ValueError.
2020-12-17 18:13:51 -05:00
Kyle McCormick
bb30a27b3e Revert "added endpoint to retrieve IDV photo urls (#25903)"
This reverts commit 356f187559.
2020-12-17 17:08:58 -05:00
alangsto
356f187559 added endpoint to retrieve IDV photo urls (#25903)
fixed quality issues

added comment

updated for comments
2020-12-17 16:13:32 -05:00
Robert Raposa
de16529ab6 Merge pull request #25885 from regisb/regisb/fix-deprecated-waffle-usage
[BD-21] Fix deprecated waffle usage
2020-12-17 12:41:40 -05:00
Awais Jibran
9c471226cd Merge pull request #25896 from edx/aj/branding/update-width-in-core
Update site width in core
2020-12-17 14:28:23 +05:00
Carla Duarte
3fb3f913b5 Merge pull request #25661 from edx/ciduarte/AA-131
AA-131: Allow anonymous users through course home MFE
2020-12-16 15:49:20 -05:00
Ned Batchelder
3abd0e8e62 Update the Open edX logo urls (#25898)
The old URLs now serve the new logo, but at the old pixel size.  These
URLs serve the new logo at a natural pixel size.
2020-12-16 15:30:55 -05:00
Dillon Dumesnil
2f7fcdea85 Merge pull request #25897 from edx/ddumesnil/fix-masquerade-for-mfe
Fixes for Shift deadlines during masquerade in Learning MFE
2020-12-16 11:57:23 -08:00
Dillon Dumesnil
e1517223b9 Fixes for Shift deadlines during masquerade in Learning MFE
The change to masquerade in the courseware view allows the proper
viewing of the xblock from the perspective of the masqueraded user.
In this case, it allows a staff user masquerading as a learner to see
their shift dates calls to action inside the MFE (the old view already
had this set up). The second change allows the staff user masquerading
to reset the schedule of the learner being masqueraded via the CTAs
2020-12-16 19:13:33 +00:00
Carla Duarte
99163bdf2c AA-131: Allow anonymous users through course home MFE 2020-12-16 12:58:33 -05:00
Awais Jibran
16cd342cb3 Update site width in core 2020-12-16 17:30:04 +05:00
Muhammad Soban Javed
bd601cf3a6 Update celery routing for celery 4+ (#25567)
* Update celery routing

- Used routing function instead of class
- Move task queues dictionary to Django settings
- Removed routing_key parameter
- Refactored routing for singleton celery instantiation

Co-authored-by: Awais Qureshi <awais.qureshi@arbisoft.com>
2020-12-16 13:40:47 +05:00
Zainab Amir
c6be0f9d51 Update institution login page title (#25892) 2020-12-16 12:51:38 +05:00
Carla Duarte
ce8c17d975 Merge pull request #25409 from edx/ciduarte/AA-387
AA-387: Removing shift dates banner from mobile app view
2020-12-15 16:57:05 -05:00
Christie Rice
79fa6c515f MICROBA-736 Swap cert image (#25841) 2020-12-15 09:05:37 -05:00
Kyle McCormick
8b1162e6ae Clean up deprecated edx-platform imports of edxmako & util (#25684) 2020-12-15 09:04:03 -05:00
Régis Behmo
c5a0ebe219 Fix missing module_name argument in CourseWaffleFlag constructor
In future versions of edx-toggles, this argument will become mandatory.
2020-12-15 12:30:25 +01:00
Régis Behmo
f29e415353 Fix deprecated usage of WaffleFlag.namespaced_flag_name
As of edx-toggles==1.2.0, the `WaffleFlag.namespaced_flag_name`
attribute is deprecated in favour of `WaffleFlag.name`.
2020-12-15 12:28:57 +01:00
Bianca Severino
a94f83688c Merge pull request #25879 from edx/bseverino/idv-logs
[MST-567] Remove course_key from IDV photo submission
2020-12-14 16:29:51 -05:00
Michael Terry
52ad3ac30e Merge pull request #25878 from edx/mikix/remove-html-blobs
TNL-7185: clean up unused html blobs from the API
2020-12-14 16:23:52 -05:00
Bianca Severino
d8bfbe96bb Remove course_key from IDV SubmitPhotosView 2020-12-14 15:52:00 -05:00
Dillon Dumesnil
d58a080236 Merge pull request #25865 from edx/ddumesnil/aa-260
AA-260/AA-500: Improvements to in course shift deadlines
2020-12-14 12:25:23 -08:00
Awais Jibran
87aa5906b9 Merge pull request #25877 from edx/aj/branding/update-expand-button
Update Course Home button Expand All / Collapse All
2020-12-15 00:48:21 +05:00
Michael Terry
cf2e778b56 TNL-7185: clean up unused html blobs from the API
Now that the MFE consumes our data structure for a couple of the
alerts, we no longer need to send raw html at all for them.
2020-12-14 14:26:10 -05:00
Michael Terry
2711fbb376 Merge pull request #25863 from edx/mikix/offer-expire-refactor
TNL-7185: Send data, not rendered HTML to the learning MFE
2020-12-14 14:18:58 -05:00
Awais Jibran
0b34ec891f Xsy image remove for course home messages at theme level 2020-12-15 00:17:02 +05:00
Dillon Dumesnil
3c1de16eba AA-260/AA-500: Improvements to in course shift deadlines
As part of AA-500, we added a completeness check to showing the
banner since we didn't before. As part of AA-260, we now take into
account if a learner has more attempts left on a problem (regardless
of completeness) and allow them to shift their dates to try again.
2020-12-14 19:05:30 +00:00
Michael Terry
eef72b5ab7 TNL-7185: Send data, not rendered HTML to the learning MFE
Specifically, send data versions of course_expired_message and
offer_html.

The rendered HTML is still being sent for now, until the learning
MFE is updated to consume the data objects.
2020-12-14 13:41:03 -05:00
Bianca Severino
d1549e5129 Merge pull request #25845 from edx/bseverino/idv-course-key-fix
[MST-567] Encode course_id passed into IDV flow
2020-12-11 13:16:30 -05:00
Robert Raposa
54044232b8 update FEATURES toggle annotation names
Update toggle_name annotations from "XXX"
to "FEATURES['XXX']" to match the name
used by the toggle state endpoint so they
don't seem like two different toggles.
2020-12-11 11:16:19 -05:00
Bianca Severino
2a4c26c367 Encode course_key passed into IDV flow 2020-12-11 09:38:38 -05:00
Jillian Vogel
511d6b975d SE-2010 Allows XBlocks to order columns for the Problem Response Report (#23109) 2020-12-11 09:37:26 -05:00
Raul Gallegos
5279975483 [TNL-7771][LX-1409] sets blockstore values timeouts to avoid S3 links expiration (#25830) 2020-12-11 09:35:45 -05:00
Adeel Ehsan
39334358d2 Merge pull request #25847 from edx/aehsan/van-198/rebrand_the_saml_page
applied rebranding to saml page
2020-12-11 02:54:02 +05:00
adeelehsan
f6d743ad6b applied rebranding to saml page 2020-12-11 01:41:21 +05:00
Feanil Patel
cfc63722a5 Undo revert.
This change was reverted along with the downgrade of super-csv because
it was believed that this change was causing issues with celery task
registration.

It was reverted in https://github.com/edx/edx-platform/pull/25762

The fix turned out to be something different and this and the
super-csv library should both be same to upgrade.  The library
upgrade will come in a follow-on make upgrade with some other
constraints that also need to be lifted.

Actual fix: https://github.com/edx/edx-platform/pull/25822
2020-12-10 13:54:36 -05:00
Tim McCormack
0c57a02119 Enforce a Celery singleton across cms and lms by using shared module (#25840)
This should prevent the issues we've seen recently where cms modules are
imported by the running lms process, resulting in two celery instances
being created and tasks intermittently being registered to the wrong
instance (and therefore effectively lost.)

In commit ab6bf348d4/PR #25822 we tried to ensure that only one or the
other of the instances was created by adding a startup check.
Unfortunately, there's an external shared library that refers directly
to the lms celery, causing a startup failure in cms, so we had to revert
it. Rather than waiting to fix that library, this commit collapses
the two instances together so that there is only ever one.
2020-12-10 17:54:31 +00:00
Alexander J Sheehan
999b88ebbb Merge pull request #25709 from edx/asheehan-edx/ENT-3648-assessment-level-signals
Adding signals and receivers for assessment level reporting
2020-12-10 09:29:54 -08:00
Feanil Patel
68e4732590 Merge pull request #25829 from edx/feanil/enable_history_panel
Enable keeping some request history in the debug toolbar.
2020-12-10 11:28:17 -05:00
Awais Jibran
e621563194 Merge pull request #25824 from edx/aj/branding/update-progress-page-base-font-size
Update base fontsize on progress page
2020-12-10 19:38:11 +05:00
Tim McCormack
a9bcf22169 Revert "Only instantiate one celery app per process." 2020-12-10 14:14:42 +00:00
Ali Akbar
e209d892c1 Merge pull request #210 from edx/IM/security-fixes-2
Incident Management security fixes 2
2020-12-10 14:26:25 +05:00
Alexander Sheehan
2220a1bcb2 Adding feature flag for subsection grade update signal 2020-12-09 14:01:39 -08:00