Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #25845 from edx/bseverino/idv-course-key-fix

Browse Source 
[MST-567] Encode course_id passed into IDV flow
This commit is contained in:
Bianca Severino
2020-12-11 13:16:30 -05:00
committed by GitHub
parent 1118f2d049 2a4c26c367
commit d1549e5129
2 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lms/djangoapps/verify_student/services.py
View File

@@ -5,6 +5,7 @@ Implementation of abstraction layer for other parts of the system to make querie
import logging
from datetime import timedelta
from itertools import chain
from urllib.parse import quote
from django.conf import settings
from django.urls import reverse
@@ -238,5 +239,5 @@ class IDVerificationService(object):
"""
location = '{}/id-verification'.format(settings.ACCOUNT_MICROFRONTEND_URL)
if course_id:
location = location + '?course_id={}'.format(str(course_id))
location += '?course_id={}'.format(quote(str(course_id)))
return location

25
lms/djangoapps/verify_student/tests/test_services.py
View File

@@ -116,6 +116,31 @@ class TestIDVerificationService(ModuleStoreTestCase):
self.assertEqual(expected_user_ids, verified_user_ids)
def test_get_verify_location_no_course_key(self):
"""
Test for the path to the IDV flow with no course key given
"""
path = IDVerificationService.get_verify_location()
expected_path = '{}/id-verification'.format(settings.ACCOUNT_MICROFRONTEND_URL)
self.assertEqual(path, expected_path)
def test_get_verify_location_from_course_id(self):
"""
Test for the path to the IDV flow with a course ID
"""
course = CourseFactory.create(org='Robot', number='999', display_name='Test Course')
path = IDVerificationService.get_verify_location(course.id)
expected_path = '{}/id-verification'.format(settings.ACCOUNT_MICROFRONTEND_URL)
self.assertEqual(path, expected_path + '?course_id=Robot/999/Test_Course')
def test_get_verify_location_from_string(self):
"""
Test for the path to the IDV flow with a course key string
"""
path = IDVerificationService.get_verify_location('course-v1:edX+DemoX+Demo_Course')
expected_path = '{}/id-verification'.format(settings.ACCOUNT_MICROFRONTEND_URL)
self.assertEqual(path, expected_path + '?course_id=course-v1%3AedX%2BDemoX%2BDemo_Course')
@patch.dict(settings.VERIFY_STUDENT, FAKE_SETTINGS)
@ddt.ddt