Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #12454 from edx/ned/remove-useless-asserts

Browse Source 
These asserts are never run.
This commit is contained in:
Ned Batchelder
2016-05-13 09:45:44 -04:00
parent 1720645302 4ef850f815
commit ebc11849be
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pavelib/paver_tests/test_paver_quality.py
View File

@@ -196,7 +196,6 @@ class TestPaverRunQuality(unittest.TestCase):
with patch('pavelib.quality._get_pep8_violations', _mock_pep8_violations):
with self.assertRaises(SystemExit):
pavelib.quality.run_quality("")
self.assertRaises(BuildFailure)
# Test that pep8, pylint, and jshint were called by counting the calls to
# _get_pep8_violations (for pep8) and sh (for diff-quality pylint & jshint)
@@ -215,7 +214,7 @@ class TestPaverRunQuality(unittest.TestCase):
with patch('pavelib.quality._get_pep8_violations', _mock_pep8_violations):
with self.assertRaises(SystemExit):
pavelib.quality.run_quality("")
self.assertRaises(BuildFailure)
# Test that both pep8 and pylint were called by counting the calls
# Assert that _get_pep8_violations (which calls "pep8") is called once
self.assertEqual(_mock_pep8_violations.call_count, 1)