From 4ef850f815352038d89f76a62006c54dba64bcd1 Mon Sep 17 00:00:00 2001 From: Ned Batchelder Date: Thu, 12 May 2016 14:48:37 -0400 Subject: [PATCH] These asserts are never run. --- pavelib/paver_tests/test_paver_quality.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pavelib/paver_tests/test_paver_quality.py b/pavelib/paver_tests/test_paver_quality.py index db08061eee..fb4f1fd0bc 100644 --- a/pavelib/paver_tests/test_paver_quality.py +++ b/pavelib/paver_tests/test_paver_quality.py @@ -196,7 +196,6 @@ class TestPaverRunQuality(unittest.TestCase): with patch('pavelib.quality._get_pep8_violations', _mock_pep8_violations): with self.assertRaises(SystemExit): pavelib.quality.run_quality("") - self.assertRaises(BuildFailure) # Test that pep8, pylint, and jshint were called by counting the calls to # _get_pep8_violations (for pep8) and sh (for diff-quality pylint & jshint) @@ -215,7 +214,7 @@ class TestPaverRunQuality(unittest.TestCase): with patch('pavelib.quality._get_pep8_violations', _mock_pep8_violations): with self.assertRaises(SystemExit): pavelib.quality.run_quality("") - self.assertRaises(BuildFailure) + # Test that both pep8 and pylint were called by counting the calls # Assert that _get_pep8_violations (which calls "pep8") is called once self.assertEqual(_mock_pep8_violations.call_count, 1)