Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

REVMI-354 Add edit_bookmark permission (#21254)

Browse Source
This commit is contained in:
Christie Rice
2019-08-02 11:01:43 -04:00
committed by GitHub
parent 1c9904859b
commit bf414335cc
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lms/djangoapps/courseware/permissions.py
View File

@@ -5,10 +5,12 @@ Permission definitions for the courseware djangoapp
from bridgekeeper import perms
from .rules import HasAccessRule
EDIT_BOOKMARK = 'courseware.edit_bookmark'
VIEW_COURSE_HOME = 'courseware.view_course_home'
VIEW_COURSEWARE = 'courseware.view_courseware'
VIEW_XQA_INTERFACE = 'courseware.view_xqa_interface'
perms[EDIT_BOOKMARK] = HasAccessRule('staff')
perms[VIEW_COURSE_HOME] = HasAccessRule('load')
perms[VIEW_COURSEWARE] = HasAccessRule('load')
perms[VIEW_XQA_INTERFACE] = HasAccessRule('staff')

4
openedx/features/course_bookmarks/plugins.py
View File

@@ -7,7 +7,7 @@ from __future__ import absolute_import
from django.urls import reverse
from django.utils.translation import ugettext as _
from courseware.access import has_access
from courseware.permissions import EDIT_BOOKMARK
from openedx.features.course_experience.course_tools import CourseTool
from student.models import CourseEnrollment
@@ -28,7 +28,7 @@ class CourseBookmarksTool(CourseTool):
"""
The bookmarks tool is only enabled for enrolled users or staff.
"""
if has_access(request.user, 'staff', course_key):
if request.user.has_perm(EDIT_BOOKMARK, course_key):
return True
return CourseEnrollment.is_enrolled(request.user, course_key)