From bf414335cc06b1a6a821a589ad2f16c8a70da42c Mon Sep 17 00:00:00 2001 From: Christie Rice <8483753+crice100@users.noreply.github.com> Date: Fri, 2 Aug 2019 11:01:43 -0400 Subject: [PATCH] REVMI-354 Add edit_bookmark permission (#21254) --- lms/djangoapps/courseware/permissions.py | 2 ++ openedx/features/course_bookmarks/plugins.py | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lms/djangoapps/courseware/permissions.py b/lms/djangoapps/courseware/permissions.py index 7038960660..722a4a4bbf 100644 --- a/lms/djangoapps/courseware/permissions.py +++ b/lms/djangoapps/courseware/permissions.py @@ -5,10 +5,12 @@ Permission definitions for the courseware djangoapp from bridgekeeper import perms from .rules import HasAccessRule +EDIT_BOOKMARK = 'courseware.edit_bookmark' VIEW_COURSE_HOME = 'courseware.view_course_home' VIEW_COURSEWARE = 'courseware.view_courseware' VIEW_XQA_INTERFACE = 'courseware.view_xqa_interface' +perms[EDIT_BOOKMARK] = HasAccessRule('staff') perms[VIEW_COURSE_HOME] = HasAccessRule('load') perms[VIEW_COURSEWARE] = HasAccessRule('load') perms[VIEW_XQA_INTERFACE] = HasAccessRule('staff') diff --git a/openedx/features/course_bookmarks/plugins.py b/openedx/features/course_bookmarks/plugins.py index 21103617c9..7ec78dca96 100644 --- a/openedx/features/course_bookmarks/plugins.py +++ b/openedx/features/course_bookmarks/plugins.py @@ -7,7 +7,7 @@ from __future__ import absolute_import from django.urls import reverse from django.utils.translation import ugettext as _ -from courseware.access import has_access +from courseware.permissions import EDIT_BOOKMARK from openedx.features.course_experience.course_tools import CourseTool from student.models import CourseEnrollment @@ -28,7 +28,7 @@ class CourseBookmarksTool(CourseTool): """ The bookmarks tool is only enabled for enrolled users or staff. """ - if has_access(request.user, 'staff', course_key): + if request.user.has_perm(EDIT_BOOKMARK, course_key): return True return CourseEnrollment.is_enrolled(request.user, course_key)