Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #17719 from edx/ai/EDUCATOR-2520-incorrect-message

Browse Source 
Fix incorrect message feedback in discussion feature.
This commit is contained in:
Attiya Ishaque
2018-03-21 17:24:22 +05:00
committed by GitHub
parent fdf8f0da46 1bca5bab10
commit 795dda47d8
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
common/static/common/js/discussion/views/discussion_thread_list_view.js
View File

@@ -414,6 +414,7 @@
DiscussionThreadListView.prototype.chooseFilter = function() {
this.filter = $('.forum-nav-filter-main-control :selected').val();
this.clearSearchAlerts();
return this.retrieveFirstPage();
};

13
common/static/common/js/spec/discussion/view/discussion_thread_list_view_spec.js
View File

@@ -233,6 +233,19 @@
});
});
it('filter should clear search alert when alternate term was searched', function() {
var filterval = 'unread';
expectFilter(filterval);
this.view.$('.forum-nav-filter-main-control').val(filterval);
expect($('.search-alert .message').text())
.toEqual('There are no posts in this topic yet.');
filterval = 'all';
expectFilter(filterval);
this.view.$('.forum-nav-filter-main-control').val(filterval).change();
expect($('.search-alert .message').text()).toEqual('');
});
describe('group selector', function() {
it('should not be visible to students', function() {
return expect(this.view.$('.forum-nav-filter-cohort-control:visible')).not.toExist();