From 1bca5bab1052ca52b6b5c7b9859b145f7f95ce66 Mon Sep 17 00:00:00 2001 From: attiyaishaque Date: Mon, 19 Mar 2018 17:33:28 +0500 Subject: [PATCH] Fix incorrect message feedback in discussion feature. --- .../discussion/views/discussion_thread_list_view.js | 1 + .../view/discussion_thread_list_view_spec.js | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/common/static/common/js/discussion/views/discussion_thread_list_view.js b/common/static/common/js/discussion/views/discussion_thread_list_view.js index 2d07bfebd6..f9727fede0 100644 --- a/common/static/common/js/discussion/views/discussion_thread_list_view.js +++ b/common/static/common/js/discussion/views/discussion_thread_list_view.js @@ -414,6 +414,7 @@ DiscussionThreadListView.prototype.chooseFilter = function() { this.filter = $('.forum-nav-filter-main-control :selected').val(); + this.clearSearchAlerts(); return this.retrieveFirstPage(); }; diff --git a/common/static/common/js/spec/discussion/view/discussion_thread_list_view_spec.js b/common/static/common/js/spec/discussion/view/discussion_thread_list_view_spec.js index 77eab3564a..abd7dba46c 100644 --- a/common/static/common/js/spec/discussion/view/discussion_thread_list_view_spec.js +++ b/common/static/common/js/spec/discussion/view/discussion_thread_list_view_spec.js @@ -233,6 +233,19 @@ }); }); + it('filter should clear search alert when alternate term was searched', function() { + var filterval = 'unread'; + expectFilter(filterval); + this.view.$('.forum-nav-filter-main-control').val(filterval); + expect($('.search-alert .message').text()) + .toEqual('There are no posts in this topic yet.'); + + filterval = 'all'; + expectFilter(filterval); + this.view.$('.forum-nav-filter-main-control').val(filterval).change(); + expect($('.search-alert .message').text()).toEqual(''); + }); + describe('group selector', function() { it('should not be visible to students', function() { return expect(this.view.$('.forum-nav-filter-cohort-control:visible')).not.toExist();