Fix quality issues.

This commit is contained in:
Feanil Patel
2019-08-19 11:51:30 -04:00
parent 7c8d9dd422
commit 68933ec089
7 changed files with 22 additions and 7 deletions

View File

@@ -1072,7 +1072,10 @@ class TestCheckTranscripts(BaseTranscripts):
link = reverse('check_transcripts')
resp = self.client.get(link, {'data': json.dumps(data)})
self.assertEqual(resp.status_code, 400)
self.assertEqual(json.loads(resp.content.decode('utf-8')).get('status'), 'Transcripts are supported only for "video" modules.')
self.assertEqual(
json.loads(resp.content.decode('utf-8')).get('status'),
'Transcripts are supported only for "video" modules.',
)
@patch('xmodule.video_module.transcripts_utils.get_video_transcript_content')
def test_command_for_fallback_transcript(self, mock_get_video_transcript_content):

View File

@@ -3,7 +3,6 @@ Signal handlers for course goals.
"""
from __future__ import absolute_import
import six
from django.db import models
from django.dispatch import receiver

View File

@@ -1731,7 +1731,10 @@ class ThreadViewSetRetrieveTest(DiscussionAPIViewTestMixin, ModuleStoreTestCase,
self.register_get_thread_response(cs_thread)
response = self.client.get(self.url)
self.assertEqual(response.status_code, 200)
self.assertEqual(json.loads(response.content.decode('utf-8')), self.expected_thread_data({"unread_comment_count": 1}))
self.assertEqual(
json.loads(response.content.decode('utf-8')),
self.expected_thread_data({"unread_comment_count": 1})
)
self.assertEqual(httpretty.last_request().method, "GET")
def test_retrieve_nonexistent_thread(self):

View File

@@ -486,7 +486,10 @@ class SingleThreadQueryCountTestCase(ForumsEnableMixin, ModuleStoreTestCase):
test_thread_id
)
self.assertEquals(response.status_code, 200)
self.assertEquals(len(json.loads(response.content.decode('utf-8'))["content"]["children"]), num_thread_responses)
self.assertEquals(
len(json.loads(response.content.decode('utf-8'))["content"]["children"]),
num_thread_responses
)
# Test uncached first, then cached now that the cache is warm.
cached_calls = [

View File

@@ -408,4 +408,7 @@ class CatalogPreviewViewTest(CatalogTest):
def test_get_without_query(self):
response = self.client.get(self.url)
self.assertEqual(response.status_code, 200)
self.assertEqual(json.loads(response.content.decode('utf-8')), {'count': 0, 'results': [], 'next': None, 'prev': None})
self.assertEqual(
json.loads(response.content.decode('utf-8')),
{'count': 0, 'results': [], 'next': None, 'prev': None}
)

View File

@@ -942,7 +942,10 @@ class EnrollmentTest(EnrollmentTestMixin, ModuleStoreTestCase, APITestCase, Ente
self.assertEqual(is_active, old_is_active)
self.assertEqual(course_mode, old_mode)
# error message should contain specific text. Otto checks for this text in the message.
self.assertRegexpMatches(json.loads(response.content.decode('utf-8'))['message'], 'Enrollment mode mismatch')
self.assertRegexpMatches(
json.loads(response.content.decode('utf-8'))['message'],
'Enrollment mode mismatch'
)
else:
# call should have succeeded
self.assertEqual(is_active, new_is_active)

View File

@@ -2,9 +2,10 @@
Tabs for courseware.
"""
from __future__ import absolute_import
from functools import cmp_to_key
from openedx.core.lib.plugins import PluginManager
from functools import cmp_to_key
# Stevedore extension point namespaces
COURSE_TAB_NAMESPACE = 'openedx.course_tab'