From 68933ec0890ce440687c89086a1bf2d4cb67ac94 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Mon, 19 Aug 2019 11:51:30 -0400 Subject: [PATCH] Fix quality issues. --- cms/djangoapps/contentstore/views/tests/test_transcripts.py | 5 ++++- lms/djangoapps/course_goals/handlers.py | 1 - lms/djangoapps/discussion/rest_api/tests/test_views.py | 5 ++++- lms/djangoapps/discussion/tests/test_views.py | 5 ++++- openedx/core/djangoapps/api_admin/tests/test_views.py | 5 ++++- openedx/core/djangoapps/enrollments/tests/test_views.py | 5 ++++- openedx/core/lib/course_tabs.py | 3 ++- 7 files changed, 22 insertions(+), 7 deletions(-) diff --git a/cms/djangoapps/contentstore/views/tests/test_transcripts.py b/cms/djangoapps/contentstore/views/tests/test_transcripts.py index bac2ae0421..f2f5ce4862 100644 --- a/cms/djangoapps/contentstore/views/tests/test_transcripts.py +++ b/cms/djangoapps/contentstore/views/tests/test_transcripts.py @@ -1072,7 +1072,10 @@ class TestCheckTranscripts(BaseTranscripts): link = reverse('check_transcripts') resp = self.client.get(link, {'data': json.dumps(data)}) self.assertEqual(resp.status_code, 400) - self.assertEqual(json.loads(resp.content.decode('utf-8')).get('status'), 'Transcripts are supported only for "video" modules.') + self.assertEqual( + json.loads(resp.content.decode('utf-8')).get('status'), + 'Transcripts are supported only for "video" modules.', + ) @patch('xmodule.video_module.transcripts_utils.get_video_transcript_content') def test_command_for_fallback_transcript(self, mock_get_video_transcript_content): diff --git a/lms/djangoapps/course_goals/handlers.py b/lms/djangoapps/course_goals/handlers.py index 2992ba9a28..ef4afb8c9f 100644 --- a/lms/djangoapps/course_goals/handlers.py +++ b/lms/djangoapps/course_goals/handlers.py @@ -3,7 +3,6 @@ Signal handlers for course goals. """ from __future__ import absolute_import -import six from django.db import models from django.dispatch import receiver diff --git a/lms/djangoapps/discussion/rest_api/tests/test_views.py b/lms/djangoapps/discussion/rest_api/tests/test_views.py index 348d95ea32..c5ba3b42a7 100644 --- a/lms/djangoapps/discussion/rest_api/tests/test_views.py +++ b/lms/djangoapps/discussion/rest_api/tests/test_views.py @@ -1731,7 +1731,10 @@ class ThreadViewSetRetrieveTest(DiscussionAPIViewTestMixin, ModuleStoreTestCase, self.register_get_thread_response(cs_thread) response = self.client.get(self.url) self.assertEqual(response.status_code, 200) - self.assertEqual(json.loads(response.content.decode('utf-8')), self.expected_thread_data({"unread_comment_count": 1})) + self.assertEqual( + json.loads(response.content.decode('utf-8')), + self.expected_thread_data({"unread_comment_count": 1}) + ) self.assertEqual(httpretty.last_request().method, "GET") def test_retrieve_nonexistent_thread(self): diff --git a/lms/djangoapps/discussion/tests/test_views.py b/lms/djangoapps/discussion/tests/test_views.py index d1d479b415..d7f4896d43 100644 --- a/lms/djangoapps/discussion/tests/test_views.py +++ b/lms/djangoapps/discussion/tests/test_views.py @@ -486,7 +486,10 @@ class SingleThreadQueryCountTestCase(ForumsEnableMixin, ModuleStoreTestCase): test_thread_id ) self.assertEquals(response.status_code, 200) - self.assertEquals(len(json.loads(response.content.decode('utf-8'))["content"]["children"]), num_thread_responses) + self.assertEquals( + len(json.loads(response.content.decode('utf-8'))["content"]["children"]), + num_thread_responses + ) # Test uncached first, then cached now that the cache is warm. cached_calls = [ diff --git a/openedx/core/djangoapps/api_admin/tests/test_views.py b/openedx/core/djangoapps/api_admin/tests/test_views.py index 356f2516f2..e777fd862e 100644 --- a/openedx/core/djangoapps/api_admin/tests/test_views.py +++ b/openedx/core/djangoapps/api_admin/tests/test_views.py @@ -408,4 +408,7 @@ class CatalogPreviewViewTest(CatalogTest): def test_get_without_query(self): response = self.client.get(self.url) self.assertEqual(response.status_code, 200) - self.assertEqual(json.loads(response.content.decode('utf-8')), {'count': 0, 'results': [], 'next': None, 'prev': None}) + self.assertEqual( + json.loads(response.content.decode('utf-8')), + {'count': 0, 'results': [], 'next': None, 'prev': None} + ) diff --git a/openedx/core/djangoapps/enrollments/tests/test_views.py b/openedx/core/djangoapps/enrollments/tests/test_views.py index ce7e2b66ac..c7764ea8ac 100644 --- a/openedx/core/djangoapps/enrollments/tests/test_views.py +++ b/openedx/core/djangoapps/enrollments/tests/test_views.py @@ -942,7 +942,10 @@ class EnrollmentTest(EnrollmentTestMixin, ModuleStoreTestCase, APITestCase, Ente self.assertEqual(is_active, old_is_active) self.assertEqual(course_mode, old_mode) # error message should contain specific text. Otto checks for this text in the message. - self.assertRegexpMatches(json.loads(response.content.decode('utf-8'))['message'], 'Enrollment mode mismatch') + self.assertRegexpMatches( + json.loads(response.content.decode('utf-8'))['message'], + 'Enrollment mode mismatch' + ) else: # call should have succeeded self.assertEqual(is_active, new_is_active) diff --git a/openedx/core/lib/course_tabs.py b/openedx/core/lib/course_tabs.py index 02b08434de..d8b86974f7 100644 --- a/openedx/core/lib/course_tabs.py +++ b/openedx/core/lib/course_tabs.py @@ -2,9 +2,10 @@ Tabs for courseware. """ from __future__ import absolute_import +from functools import cmp_to_key + from openedx.core.lib.plugins import PluginManager -from functools import cmp_to_key # Stevedore extension point namespaces COURSE_TAB_NAMESPACE = 'openedx.course_tab'