Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #18376 from edx/LEARNER-5360/utm-update-for-social-sharing

Browse Source 
Update UTM params of social sharing buttons
This commit is contained in:
Uzair Rasheed
2018-06-14 18:24:27 +05:00
committed by GitHub
parent d7e29c210e e77a19a4a3
commit 58b9cb4938
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
common/djangoapps/util/course.py
View File

@@ -12,13 +12,13 @@ log = logging.getLogger(__name__)
COURSE_SHARING_UTM_PARAMETERS = {
'facebook': {
'utm_medium': 'social-post',
'utm_campaign': 'social-sharing',
'utm_medium': 'social',
'utm_campaign': 'social-sharing-db',
'utm_source': 'facebook',
},
'twitter': {
'utm_medium': 'social-post',
'utm_campaign': 'social-sharing',
'utm_medium': 'social',
'utm_campaign': 'social-sharing-db',
'utm_source': 'twitter',
},
}

4
common/test/acceptance/tests/lms/test_lms_dashboard.py
View File

@@ -164,7 +164,7 @@ class LmsDashboardPageTest(BaseLmsDashboardTest):
"""
twitter_widget = self.dashboard_page.get_course_social_sharing_widget('twitter')
twitter_url = ("https://twitter.com/intent/tweet?text=Testing+feature%3A%20http%3A%2F%2Fcustom%2Fcourse%2Furl"
"%3Futm_campaign%3Dsocial-sharing%26utm_medium%3Dsocial-post%26utm_source%3Dtwitter")
"%3Futm_campaign%3Dsocial-sharing-db%26utm_medium%3Dsocial%26utm_source%3Dtwitter")
self.assertEqual(twitter_widget.attrs('title')[0], 'Share on Twitter')
self.assertEqual(twitter_widget.attrs('data-tooltip')[0], 'Share on Twitter')
self.assertEqual(twitter_widget.attrs('target')[0], '_blank')
@@ -173,7 +173,7 @@ class LmsDashboardPageTest(BaseLmsDashboardTest):
facebook_widget = self.dashboard_page.get_course_social_sharing_widget('facebook')
facebook_url = ("https://www.facebook.com/sharer/sharer.php?u=http%3A%2F%2Fcustom%2Fcourse%2Furl%3F"
"utm_campaign%3Dsocial-sharing%26utm_medium%3Dsocial-post%26utm_source%3Dfacebook&"
"utm_campaign%3Dsocial-sharing-db%26utm_medium%3Dsocial%26utm_source%3Dfacebook&"
"quote=I%27m+taking+Test")
self.assertEqual(facebook_widget.attrs('title')[0], 'Share on Facebook')
self.assertEqual(facebook_widget.attrs('data-tooltip')[0], 'Share on Facebook')

4
lms/djangoapps/mobile_api/users/tests.py
View File

@@ -500,8 +500,8 @@ class TestCourseEnrollmentSerializer(MobileAPITestCase, MilestonesTestCaseMixin)
# Assert utm parameters
expected_utm_parameters = {
'twitter': 'utm_campaign=social-sharing&utm_medium=social-post&utm_source=twitter',
'facebook': 'utm_campaign=social-sharing&utm_medium=social-post&utm_source=facebook'
'twitter': 'utm_campaign=social-sharing-db&utm_medium=social&utm_source=twitter',
'facebook': 'utm_campaign=social-sharing-db&utm_medium=social&utm_source=facebook'
}
self.assertEqual(serialized['course']['course_sharing_utm_parameters'], expected_utm_parameters)