Fix how the 'empty' field is excluded from html_module editable fields

2013-03-06 16:34:21 -05:00
parent 4327aa1885
commit 5222c61d73
1 changed files with 5 additions and 2 deletions
--- a/common/lib/xmodule/xmodule/html_module.py
+++ b/common/lib/xmodule/xmodule/html_module.py
@@ -168,8 +168,11 @@ class HtmlDescriptor(XmlDescriptor, EditingDescriptor):
    @property
    def editable_metadata_fields(self):
        """Remove any metadata from the editable fields which have their own editor or shouldn't be edited by user."""
-        subset = [field for field in super(HtmlDescriptor,self).editable_metadata_fields
-                  if field not in ['empty']]
+        subset = super(HtmlDescriptor, self).editable_metadata_fields
+
+        if 'empty' in subset:
+            del subset['empty']
+
        return subset