From 5222c61d73cbd7a979242ba2cc2642d258cc8e24 Mon Sep 17 00:00:00 2001 From: Calen Pennington Date: Wed, 6 Mar 2013 16:34:21 -0500 Subject: [PATCH] Fix how the 'empty' field is excluded from html_module editable fields --- common/lib/xmodule/xmodule/html_module.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/common/lib/xmodule/xmodule/html_module.py b/common/lib/xmodule/xmodule/html_module.py index d620b1fe7f..1f9228b47f 100644 --- a/common/lib/xmodule/xmodule/html_module.py +++ b/common/lib/xmodule/xmodule/html_module.py @@ -168,8 +168,11 @@ class HtmlDescriptor(XmlDescriptor, EditingDescriptor): @property def editable_metadata_fields(self): """Remove any metadata from the editable fields which have their own editor or shouldn't be edited by user.""" - subset = [field for field in super(HtmlDescriptor,self).editable_metadata_fields - if field not in ['empty']] + subset = super(HtmlDescriptor, self).editable_metadata_fields + + if 'empty' in subset: + del subset['empty'] + return subset