Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename CookieMetricsMiddleware to CookingMonitoringMiddleware

Browse Source 
This fixes a misuse of New Relic terminology. Here we are in fact using
custom attributes; custom metrics are a different thing that we may start
using in the future.
This commit is contained in:
Tim McCormack
2020-09-18 14:25:50 +00:00
parent ba9ee4e151
commit 328e790e8a
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cms/envs/common.py
View File

@@ -661,7 +661,7 @@ MIDDLEWARE = [
'edx_django_utils.monitoring.middleware.MonitoringMemoryMiddleware',
# Cookie monitoring
'openedx.core.lib.request_utils.CookieMetricsMiddleware',
'openedx.core.lib.request_utils.CookingMonitoringMiddleware',
'openedx.core.djangoapps.header_control.middleware.HeaderControlMiddleware',
'django.middleware.cache.UpdateCacheMiddleware',

2
lms/envs/common.py
View File

@@ -1683,7 +1683,7 @@ MIDDLEWARE = [
'edx_django_utils.monitoring.code_owner.middleware.CodeOwnerMonitoringMiddleware',
# Cookie monitoring
'openedx.core.lib.request_utils.CookieMetricsMiddleware',
'openedx.core.lib.request_utils.CookingMonitoringMiddleware',
'mobile_api.middleware.AppVersionUpgrade',
'openedx.core.djangoapps.header_control.middleware.HeaderControlMiddleware',

10
openedx/core/lib/request_utils.py
View File

@@ -95,14 +95,14 @@ def course_id_from_url(url):
return None
class CookieMetricsMiddleware(MiddlewareMixin):
class CookingMonitoringMiddleware(MiddlewareMixin):
"""
Middleware for monitoring the size and growth of all our cookies, to see if
we're running into browser limits.
"""
def process_request(self, request):
"""
Emit custom metrics for cookie size values for every cookie we have.
Emit custom attributes for cookie size values for every cookie we have.
Don't log contents of cookies because that might cause a security issue.
We just want to see if any cookies are growing out of control.
@@ -118,9 +118,9 @@ class CookieMetricsMiddleware(MiddlewareMixin):
for name, value in request.COOKIES.items()
}
for name, size in cookie_names_to_size.items():
metric_name = 'cookies.{}.size'.format(name)
newrelic.agent.add_custom_parameter(metric_name, size)
log.debug(u'%s = %d', metric_name, size)
attribute_name = 'cookies.{}.size'.format(name)
newrelic.agent.add_custom_parameter(attribute_name, size)
log.debug(u'%s = %d', attribute_name, size)
total_cookie_size = sum(cookie_names_to_size.values())
newrelic.agent.add_custom_parameter('cookies_total_size', total_cookie_size)