diff --git a/cms/envs/common.py b/cms/envs/common.py index a9d45cadaa..820577fd23 100644 --- a/cms/envs/common.py +++ b/cms/envs/common.py @@ -661,7 +661,7 @@ MIDDLEWARE = [ 'edx_django_utils.monitoring.middleware.MonitoringMemoryMiddleware', # Cookie monitoring - 'openedx.core.lib.request_utils.CookieMetricsMiddleware', + 'openedx.core.lib.request_utils.CookingMonitoringMiddleware', 'openedx.core.djangoapps.header_control.middleware.HeaderControlMiddleware', 'django.middleware.cache.UpdateCacheMiddleware', diff --git a/lms/envs/common.py b/lms/envs/common.py index 5f2d723cc2..2cf7d17590 100644 --- a/lms/envs/common.py +++ b/lms/envs/common.py @@ -1683,7 +1683,7 @@ MIDDLEWARE = [ 'edx_django_utils.monitoring.code_owner.middleware.CodeOwnerMonitoringMiddleware', # Cookie monitoring - 'openedx.core.lib.request_utils.CookieMetricsMiddleware', + 'openedx.core.lib.request_utils.CookingMonitoringMiddleware', 'mobile_api.middleware.AppVersionUpgrade', 'openedx.core.djangoapps.header_control.middleware.HeaderControlMiddleware', diff --git a/openedx/core/lib/request_utils.py b/openedx/core/lib/request_utils.py index 4be90f16a3..471ee05883 100644 --- a/openedx/core/lib/request_utils.py +++ b/openedx/core/lib/request_utils.py @@ -95,14 +95,14 @@ def course_id_from_url(url): return None -class CookieMetricsMiddleware(MiddlewareMixin): +class CookingMonitoringMiddleware(MiddlewareMixin): """ Middleware for monitoring the size and growth of all our cookies, to see if we're running into browser limits. """ def process_request(self, request): """ - Emit custom metrics for cookie size values for every cookie we have. + Emit custom attributes for cookie size values for every cookie we have. Don't log contents of cookies because that might cause a security issue. We just want to see if any cookies are growing out of control. @@ -118,9 +118,9 @@ class CookieMetricsMiddleware(MiddlewareMixin): for name, value in request.COOKIES.items() } for name, size in cookie_names_to_size.items(): - metric_name = 'cookies.{}.size'.format(name) - newrelic.agent.add_custom_parameter(metric_name, size) - log.debug(u'%s = %d', metric_name, size) + attribute_name = 'cookies.{}.size'.format(name) + newrelic.agent.add_custom_parameter(attribute_name, size) + log.debug(u'%s = %d', attribute_name, size) total_cookie_size = sum(cookie_names_to_size.values()) newrelic.agent.add_custom_parameter('cookies_total_size', total_cookie_size)