fix(deps): update dependency @edx/paragon to v20.45.5

Merge pull request #370 from openedx/Ayesha/INF-951
fix: clicking on notification redirecting to correct URL
2023-07-24 06:29:20 +00:00 · 2023-07-14 13:04:49 +05:00 · 2023-07-14 08:53:02 +05:00 · 2023-07-13 15:48:35 +05:00
4 changed files with 10 additions and 10 deletions
--- a/package-lock.json
+++ b/package-lock.json
@@ -9,7 +9,7 @@
      "version": "1.0.0-semantically-released",
      "license": "AGPL-3.0",
      "dependencies": {
-        "@edx/paragon": "20.45.0",
+        "@edx/paragon": "20.45.5",
        "@fortawesome/fontawesome-svg-core": "6.4.0",
        "@fortawesome/free-brands-svg-icons": "6.4.0",
        "@fortawesome/free-regular-svg-icons": "6.4.0",
@@ -3220,9 +3220,9 @@
      }
    },
    "node_modules/@edx/paragon": {
-      "version": "20.45.0",
-      "resolved": "https://registry.npmjs.org/@edx/paragon/-/paragon-20.45.0.tgz",
-      "integrity": "sha512-9lHcnSJ36sQ+bsYFhydf/Pvp3Bo5N3go8R3ORPTNtvYnwiKSfjlv11QpURC/xHobXsT2eYHiwl2gNmq1yP09BA==",
+      "version": "20.45.5",
+      "resolved": "https://registry.npmjs.org/@edx/paragon/-/paragon-20.45.5.tgz",
+      "integrity": "sha512-7GsGPKyxtjFo3Xnj+uQ4vx/Khz7S6srHe8MqcsYCMx2mJ8fulPN2JFm84m+0o1CSwHaL469wBPONI4KCa+vfrA==",
      "dependencies": {
        "@fortawesome/fontawesome-svg-core": "^6.1.1",
        "@fortawesome/react-fontawesome": "^0.1.18",
--- a/package.json
+++ b/package.json
@@ -56,7 +56,7 @@
    "redux-saga": "1.2.3"
  },
  "dependencies": {
-    "@edx/paragon": "20.45.0",
+    "@edx/paragon": "20.45.5",
    "@fortawesome/fontawesome-svg-core": "6.4.0",
    "@fortawesome/free-brands-svg-icons": "6.4.0",
    "@fortawesome/free-regular-svg-icons": "6.4.0",
--- a/src/Notifications/NotificationRowItem.jsx
+++ b/src/Notifications/NotificationRowItem.jsx
@@ -3,7 +3,6 @@ import { useDispatch } from 'react-redux';
 import { useIntl } from '@edx/frontend-platform/i18n';
 import PropTypes from 'prop-types';
 import { Icon } from '@edx/paragon';
-import { Link } from 'react-router-dom';
 import * as timeago from 'timeago.js';
 import { getIconByType } from './utils';
 import { markNotificationsAsRead } from './data/thunks';
@@ -24,12 +23,13 @@ const NotificationRowItem = ({
  const { icon: iconComponent, class: iconClass } = getIconByType(type);

  return (
-    <Link
+    <a
      target="_blank"
      className="d-flex mb-2 align-items-center text-decoration-none"
-      to={contentUrl}
+      href={contentUrl}
      onClick={handleMarkAsRead}
      data-testid={`notification-${id}`}
+      rel="noopener noreferrer"
    >
      <Icon
        src={iconComponent}
@@ -62,7 +62,7 @@ const NotificationRowItem = ({
          )}
        </div>
      </div>
-    </Link>
+    </a>
  );
 };

--- a/src/Notifications/NotificationSections.jsx
+++ b/src/Notifications/NotificationSections.jsx
@@ -60,7 +60,7 @@ const NotificationSections = () => {
            type={notification.type}
            contentUrl={notification.contentUrl}
            content={notification.content}
-            courseName={notification.courseName}
+            courseName={notification.contentContext?.courseName || ''}
            createdAt={notification.createdAt}
            lastRead={notification.lastRead}
          />
Author	SHA1	Message	Date
renovate[bot]	3dd41030d3	fix(deps): update dependency @edx/paragon to v20.45.5	2023-07-24 06:29:20 +00:00
Awais Ansari	27228f093d	Merge pull request #370 from openedx/Ayesha/INF-951 fix: clicking on notification redirecting to correct URL	2023-07-14 13:04:49 +05:00
Muhammad Adeel Tajamul	83f3241e26	fix: course name was not visible in notification (#371 )	2023-07-14 08:53:02 +05:00
ayeshoali	e153aefc13	fix: clicking on notification redirecting to correct URL	2023-07-13 15:48:35 +05:00