fix: update snapshot to reflect new ids

fix: add unique ids to Icon components
Merge pull request #7 from edx/robrap/update-readme
2019-03-08 12:44:00 -05:00 · 2019-03-08 12:35:35 -05:00 · 2019-03-08 09:44:26 -05:00 · 2019-03-06 09:36:43 -05:00
3 changed files with 18 additions and 15 deletions
--- a/README.rst
+++ b/README.rst
@@ -7,6 +7,9 @@ frontend-component-footer
 frontend-component-footer is a library containing a site footer
 component for use when building edX frontend applications.

+At this time, this componenet is hard-coded to match the legacy LMS site footer, including all of its links.
+Note: As implemented, it should really be called the ``frontend-component-lms-footer``.
+
 Usage
 -----

--- a/src/lib/components/SiteFooter/snapshots/SiteFooter.test.jsx.snap
+++ b/src/lib/components/SiteFooter/snapshots/SiteFooter.test.jsx.snap
@@ -188,7 +188,7 @@ exports[`<SiteFooter /> renders correctly does not render mobile links 1`] = `
            <span
              aria-hidden={true}
              className="fa fa-facebook-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-facebook"
            />
            <span
              className="sr-only"
@@ -208,7 +208,7 @@ exports[`<SiteFooter /> renders correctly does not render mobile links 1`] = `
            <span
              aria-hidden={true}
              className="fa fa-twitter-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-twitter"
            />
            <span
              className="sr-only"
@@ -228,7 +228,7 @@ exports[`<SiteFooter /> renders correctly does not render mobile links 1`] = `
            <span
              aria-hidden={true}
              className="fa fa-youtube-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-youtube"
            />
            <span
              className="sr-only"
@@ -248,7 +248,7 @@ exports[`<SiteFooter /> renders correctly does not render mobile links 1`] = `
            <span
              aria-hidden={true}
              className="fa fa-linkedin-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-linkedin"
            />
            <span
              className="sr-only"
@@ -268,7 +268,7 @@ exports[`<SiteFooter /> renders correctly does not render mobile links 1`] = `
            <span
              aria-hidden={true}
              className="fa fa-google-plus-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-google"
            />
            <span
              className="sr-only"
@@ -720,7 +720,7 @@ exports[`<SiteFooter /> renders correctly renders with social and mobile links 1
            <span
              aria-hidden={true}
              className="fa fa-facebook-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-facebook"
            />
            <span
              className="sr-only"
@@ -740,7 +740,7 @@ exports[`<SiteFooter /> renders correctly renders with social and mobile links 1
            <span
              aria-hidden={true}
              className="fa fa-twitter-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-twitter"
            />
            <span
              className="sr-only"
@@ -760,7 +760,7 @@ exports[`<SiteFooter /> renders correctly renders with social and mobile links 1
            <span
              aria-hidden={true}
              className="fa fa-youtube-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-youtube"
            />
            <span
              className="sr-only"
@@ -780,7 +780,7 @@ exports[`<SiteFooter /> renders correctly renders with social and mobile links 1
            <span
              aria-hidden={true}
              className="fa fa-linkedin-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-linkedin"
            />
            <span
              className="sr-only"
@@ -800,7 +800,7 @@ exports[`<SiteFooter /> renders correctly renders with social and mobile links 1
            <span
              aria-hidden={true}
              className="fa fa-google-plus-square fa-2x"
-              id="Icon1"
+              id="edx-footer-icon-google"
            />
            <span
              className="sr-only"
--- a/src/lib/components/SiteFooter/index.jsx
+++ b/src/lib/components/SiteFooter/index.jsx
@@ -59,7 +59,7 @@ class SiteFooter extends React.Component {
              target="_blank"
              onClick={this.externalLinkClickHandler}
            >
-              <Icon className={['fa', 'fa-facebook-square', 'fa-2x']} screenReaderText={`Like ${siteName} on Facebook`} />
+              <Icon id="edx-footer-icon-facebook" className={['fa', 'fa-facebook-square', 'fa-2x']} screenReaderText={`Like ${siteName} on Facebook`} />
            </a>
          </li>

@@ -72,7 +72,7 @@ class SiteFooter extends React.Component {
              target="_blank"
              onClick={this.externalLinkClickHandler}
            >
-              <Icon className={['fa', 'fa-twitter-square', 'fa-2x']} screenReaderText={`Follow ${siteName} on Twitter`} />
+              <Icon id="edx-footer-icon-twitter" className={['fa', 'fa-twitter-square', 'fa-2x']} screenReaderText={`Follow ${siteName} on Twitter`} />
            </a>
          </li>
          <li>
@@ -83,7 +83,7 @@ class SiteFooter extends React.Component {
              target="_blank"
              onClick={this.externalLinkClickHandler}
            >
-              <Icon className={['fa', 'fa-youtube-square', 'fa-2x']} screenReaderText={`Subscribe to the ${siteName} YouTube channel`} />
+              <Icon id="edx-footer-icon-youtube" className={['fa', 'fa-youtube-square', 'fa-2x']} screenReaderText={`Subscribe to the ${siteName} YouTube channel`} />
            </a>
          </li>
          <li>
@@ -94,7 +94,7 @@ class SiteFooter extends React.Component {
              target="_blank"
              onClick={this.externalLinkClickHandler}
            >
-              <Icon className={['fa', 'fa-linkedin-square', 'fa-2x']} screenReaderText={`Follow ${siteName} on LinkedIn`} />
+              <Icon id="edx-footer-icon-linkedin" className={['fa', 'fa-linkedin-square', 'fa-2x']} screenReaderText={`Follow ${siteName} on LinkedIn`} />
            </a>
          </li>
          <li>
@@ -105,7 +105,7 @@ class SiteFooter extends React.Component {
              target="_blank"
              onClick={this.externalLinkClickHandler}
            >
-              <Icon className={['fa', 'fa-google-plus-square', 'fa-2x']} screenReaderText={`Follow ${siteName} on Google+`} />
+              <Icon id="edx-footer-icon-google" className={['fa', 'fa-google-plus-square', 'fa-2x']} screenReaderText={`Follow ${siteName} on Google+`} />
            </a>
          </li>
          <li>
Author	SHA1	Message	Date
Adam Butterworth	abe3d03f58	fix: update snapshot to reflect new ids	2019-03-08 12:44:00 -05:00
Adam Butterworth	7af4b71faa	fix: add unique ids to Icon components	2019-03-08 12:35:35 -05:00
Robert Raposa	7f2c5b32b1	Merge pull request #7 from edx/robrap/update-readme Update README.rst	2019-03-08 09:44:26 -05:00
Robert Raposa	6e0f9cf30a	fix(docs): update README.rst Add a note to clarify that this component is not really a flexible site footer at this time.	2019-03-06 09:36:43 -05:00