Merge pull request #681 from openedx/jhynes/aper-2240-cleanup

fix: remove LR MFE URL building logic

.env

@@ -22,8 +22,6 @@ LOGO_URL=''
 LOGO_TRADEMARK_URL=''
 LOGO_WHITE_URL=''
 FAVICON_URL=''
-ENABLE_LEARNER_RECORD_MFE=''
-LEARNER_RECORD_MFE_BASE_URL=''
 COLLECT_YEAR_OF_BIRTH=true
 APP_ID=''
 MFE_CONFIG_API_URL=''

.env.development

@@ -23,8 +23,6 @@ LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
 LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
 LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg
 FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
-ENABLE_LEARNER_RECORD_MFE=''
-LEARNER_RECORD_MFE_BASE_URL='http://localhost:1990'
 COLLECT_YEAR_OF_BIRTH=true
 APP_ID=''
 MFE_CONFIG_API_URL=''

.env.test

@@ -17,8 +17,6 @@ LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
 LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
 LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg
 FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
-ENABLE_LEARNER_RECORD_MFE=''
-LEARNER_RECORD_MFE_BASE_URL='http://localhost:1990'
 COLLECT_YEAR_OF_BIRTH=true
 APP_ID=''
 MFE_CONFIG_API_URL=''

src/index.jsx

@@ -65,8 +65,6 @@ initialize({
   handlers: {
     config: () => {
       mergeConfig({
-        ENABLE_LEARNER_RECORD_MFE: (process.env.ENABLE_LEARNER_RECORD_MFE || false),
-        LEARNER_RECORD_MFE_BASE_URL: process.env.LEARNER_RECORD_MFE_BASE_URL,
         COLLECT_YEAR_OF_BIRTH: process.env.COLLECT_YEAR_OF_BIRTH,
         ENABLE_SKILLS_BUILDER: process.env.ENABLE_SKILLS_BUILDER,
       }, 'App loadConfig override handler');

src/profile/ProfilePage.jsx

@@ -46,10 +46,10 @@ class ProfilePage extends React.Component {
   constructor(props, context) {
     super(props, context);
 
-    const recordsUrl = this.getRecordsUrl(context);
+    const credentialsBaseUrl = context.config.CREDENTIALS_BASE_URL;
 
     this.state = {
-      viewMyRecordsUrl: recordsUrl,
+      viewMyRecordsUrl: credentialsBaseUrl ? `${credentialsBaseUrl}/records` : null,
       accountSettingsUrl: `${context.config.LMS_BASE_URL}/account/settings`,
     };
 
@@ -92,19 +92,6 @@ class ProfilePage extends React.Component {
     this.props.updateDraft(name, value);
   }
 
-  getRecordsUrl(context) {
-    let recordsUrl = null;
-
-    if (getConfig().ENABLE_LEARNER_RECORD_MFE) {
-      recordsUrl = getConfig().LEARNER_RECORD_MFE_BASE_URL;
-    } else {
-      const credentialsBaseUrl = context.config.CREDENTIALS_BASE_URL;
-      recordsUrl = credentialsBaseUrl ? `${credentialsBaseUrl}/records` : null;
-    }
-
-    return recordsUrl;
-  }
-
   isYOBDisabled() {
     const { yearOfBirth } = this.props;
     const currentYear = new Date().getFullYear();