Andal.LND/frontend-app-learning
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: update discussion sidebar url to allow grouping by subsection (#968)

Browse Source 
To enable grouping by subsection in the discussions MFE, this PR updates
the embed URL to the one that supports grouping.

ref: https://github.com/openedx/frontend-app-discussions/pull/281
This commit is contained in:
Kshitij Sobti
2022-10-12 12:57:42 +00:00
committed by GitHub
parent 1892edaade
commit e5e73e40ba
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/courseware/course/sidebar/sidebars/discussions/DiscussionsSidebar.jsx
View File

@@ -19,7 +19,7 @@ function DiscussionsSidebar({ intl }) {
if (!topic?.id) {
return null;
}
const discussionsUrl = `${getConfig().DISCUSSIONS_MFE_BASE_URL}/${courseId}/topics/${topic.id}`;
const discussionsUrl = `${getConfig().DISCUSSIONS_MFE_BASE_URL}/${courseId}/category/${unitId}`;
return (
<SidebarBase
title={intl.formatMessage(messages.discussionsTitle)}

2
src/courseware/course/sidebar/sidebars/discussions/DiscussionsSidebar.test.jsx
View File

@@ -59,7 +59,7 @@ describe('Discussions Trigger', () => {
renderWithProvider();
expect(screen.queryByTitle('Discussions')).toBeInTheDocument();
expect(screen.queryByTitle('Discussions'))
.toHaveAttribute('src', `http://localhost:2002/${courseId}/topics/topic-1?inContext`);
.toHaveAttribute('src', `http://localhost:2002/${courseId}/category/${unitId}?inContext`);
});
it('should show nothing if unit has no discussions associated with it', async () => {