Andal.LND/frontend-app-learning
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove currency symbol to avoid double currency symbol with some upgrade buttons (#448)

Browse Source
This commit is contained in:
Matthew Piatetsky
2021-05-14 09:48:50 -04:00
committed by GitHub
parent b1fdbcccf3
commit d8243d6ea8
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/course-home/outline-tab/widgets/UpgradeCard.test.jsx
View File

@@ -134,8 +134,8 @@ describe('Upgrade Card', () => {
expirationDate: discountExpirationDate.toString(),
percentage: 15,
code: 'Welcome15',
discountedPrice: '126.65',
originalPrice: '149',
discountedPrice: '$126.65',
originalPrice: '$149',
upgradeUrl: 'www.exampleUpgradeUrl.com',
},
});
@@ -163,8 +163,8 @@ describe('Upgrade Card', () => {
expirationDate: discountExpirationDate.toString(),
percentage: 15,
code: 'Welcome15',
discountedPrice: '126.65',
originalPrice: '149',
discountedPrice: '$126.65',
originalPrice: '$149',
upgradeUrl: 'www.exampleUpgradeUrl.com',
},
});
@@ -192,8 +192,8 @@ describe('Upgrade Card', () => {
expirationDate: discountExpirationDate.toString(),
percentage: 15,
code: 'Welcome15',
discountedPrice: '126.65',
originalPrice: '149',
discountedPrice: '$126.65',
originalPrice: '$149',
upgradeUrl: 'www.exampleUpgradeUrl.com',
},
});
@@ -221,8 +221,8 @@ describe('Upgrade Card', () => {
expirationDate: discountExpirationDate.toString(),
percentage: 15,
code: 'Welcome15',
discountedPrice: '126.65',
originalPrice: '149',
discountedPrice: '$126.65',
originalPrice: '$149',
upgradeUrl: 'www.exampleUpgradeUrl.com',
},
});

2
src/generic/upgrade-button/FormattedPricing.jsx
View File

@@ -53,7 +53,7 @@ function FormattedPricing(props) {
{intl.formatMessage(messages.srPrices, { discountedPrice, originalPrice })}
</span>
<span aria-hidden="true">
<span>{currencySymbol}{discountedPrice}</span> (<del>{currencySymbol}{originalPrice}</del>)
<span>{discountedPrice}</span> (<del>{originalPrice}</del>)
</span>
</>
);

4
src/shared/streak-celebration/StreakCelebrationModal.jsx
View File

@@ -90,8 +90,8 @@ function StreakModal({
};
offer = {
discountedPrice: (mode.price * 0.85).toFixed(2).toString(),
originalPrice: mode.price.toString(),
discountedPrice: `${verifiedMode.currencySymbol}${(mode.price * 0.85).toFixed(2).toString()}`,
originalPrice: `${verifiedMode.currencySymbol}${mode.price.toString()}`,
upgradeUrl: mode.upgradeUrl,
};
}