Andal.LND/frontend-app-gradebook
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

EDUCATOR-4685 final fix for using label with course id

Browse Source
This commit is contained in:
atesker
2019-10-04 10:00:24 -04:00
parent 80aa4f10a0
commit ee8e56a792
2 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/Gradebook/index.jsx
View File

@@ -309,8 +309,7 @@ export default class Gradebook extends React.Component {
name: 'edx.gradebook.reports.grade_export.downloaded',
properties: {
category: trackingCategory,
courseId: this.props.courseId,
label: this.props.courseId, // check to see if google analytics captures label property
label: this.props.courseId,
},
}));
window.location = this.props.gradeExportUrl;
@@ -321,8 +320,7 @@ export default class Gradebook extends React.Component {
name: 'edx.gradebook.reports.intervention.downloaded',
properties: {
category: trackingCategory,
courseId: this.props.courseId,
label: this.props.courseId, // check to see if google analytics captures label property
label: this.props.courseId,
},
}));
window.location = this.props.interventionExportUrl;
@@ -526,7 +524,7 @@ export default class Gradebook extends React.Component {
name: 'edx.gradebook.grades.filter_applied',
properties: {
category: trackingCategory,
courseId: this.props.courseId,
label: this.props.courseId,
cohort: this.props.selectedCohort,
track: this.props.selectedTrack,
assignmentType: this.props.selectedAssignmentType,

12
src/data/store.js
View File

@@ -24,9 +24,8 @@ const eventsMap = {
name: 'edx.gradebook.grades.displayed',
properties: {
category: trackingCategory,
courseId: action.courseId,
track: action.track,
label: action.courseId,
track: action.track,
cohort: action.cohort,
assignmentType: action.assignmentType,
prev: action.prev,
@@ -35,10 +34,9 @@ const eventsMap = {
})),
[GRADE_UPDATE_SUCCESS]: trackEvent(action => ({
name: 'edx.gradebook.grades.grade_override.succeeded',
label: action.courseId,
properties: {
category: trackingCategory,
courseId: action.courseId,
label: action.courseId,
updatedGrades: action.payload.responseData,
},
})),
@@ -46,7 +44,7 @@ const eventsMap = {
name: 'edx.gradebook.grades.grade_override.failed',
properties: {
category: trackingCategory,
courseId: action.courseId,
label: action.courseId,
error: action.payload.error,
},
})),
@@ -54,14 +52,14 @@ const eventsMap = {
name: 'edx.gradebook.grades.upload.grades_overrides.succeeded',
properties: {
category: trackingCategory,
courseId: action.courseId,
label: action.courseId,
},
})),
[UPLOAD_OVERRIDE_ERROR]: trackEvent(action => ({
name: 'edx.gradebook.grades.upload.grades_overrides.failed',
properties: {
category: trackingCategory,
courseId: action.courseId,
label: action.courseId,
error: action.payload.error,
},
})),