fix tests

This commit is contained in:
Ben Warzeski
2021-05-17 11:17:39 -04:00
parent 92035af5d7
commit 7e0e286efe
10 changed files with 27 additions and 24 deletions

View File

@@ -2,14 +2,18 @@ import React from 'react';
import { mount, shallow } from 'enzyme';
import selectors from 'data/selectors';
import { updateAssignmentFilter } from 'data/actions/filters';
import { updateGradesIfAssignmentGradeFiltersSet } from 'data/actions/grades';
import actions from 'data/actions';
import { updateGradesIfAssignmentGradeFiltersSet } from 'data/thunkActions/grades';
import {
AssignmentFilter,
mapStateToProps,
mapDispatchToProps,
} from '.';
jest.mock('data/thunkActions/grades', () => ({
updateGradesIfAssignmentGradeFiltersSet: jest.fn(),
}));
jest.mock('data/selectors', () => ({
/** Mocking to use passed state for validation purposes */
filters: {
@@ -160,7 +164,7 @@ describe('AssignmentFilter', () => {
describe('mapDispatchToProps', () => {
test('updateAssignmentFilter', () => {
expect(mapDispatchToProps.updateAssignmentFilter).toEqual(
updateAssignmentFilter,
actions.filters.update.assignment,
);
});
test('updateGradesIfAsssignmentGradeFiltersSet', () => {

View File

@@ -1,8 +1,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { updateAssignmentLimits } from 'data/actions/filters';
import { fetchGrades } from 'data/actions/grades';
import actions from 'data/actions';
import { fetchGrades } from 'data/thunkActions/grades';
import {
AssignmentGradeFilter,
@@ -167,7 +167,7 @@ describe('AssignmentGradeFilter', () => {
expect(
mapDispatchToProps.updateAssignmentLimits,
).toEqual(
updateAssignmentLimits,
actions.filters.update.assignmentLimits,
);
});
});

View File

@@ -70,7 +70,6 @@ export const mapStateToProps = (state) => ({
selectedAssignmentType: selectors.filters.assignmentType(state),
});
console.log({ actions });
export const mapDispatchToProps = {
filterAssignmentType: actions.filters.update.assignmentType,
};

View File

@@ -2,7 +2,7 @@ import React from 'react';
import { shallow } from 'enzyme';
import selectors from 'data/selectors';
import { filterAssignmentType } from 'data/actions/grades';
import actions from 'data/actions';
import {
AssignmentTypeFilter,
@@ -128,7 +128,7 @@ describe('AssignmentTypeFilter', () => {
describe('mapDispatchToProps', () => {
test('filterAssignmentType', () => {
expect(mapDispatchToProps.filterAssignmentType).toEqual(
filterAssignmentType,
actions.filters.update.assignmentType,
);
});
});

View File

@@ -3,8 +3,8 @@
import React from 'react';
import { shallow } from 'enzyme';
import { updateCourseGradeFilter } from 'data/actions/filters';
import { fetchGrades } from 'data/actions/grades';
import actions from 'data/actions';
import { fetchGrades } from 'data/thunkActions/grades';
import {
CourseGradeFilter,
mapStateToProps,
@@ -91,11 +91,11 @@ describe('CourseGradeFilter', () => {
el.instance().updateCourseGradeFilters();
});
it('calls props.updateFilter with selection', () => {
expect(props.updateFilter).toHaveBeenCalledWith(
props.filterValues.courseGradeMin,
props.filterValues.courseGradeMax,
props.courseId,
);
expect(props.updateFilter).toHaveBeenCalledWith({
courseGradeMin: props.filterValues.courseGradeMin,
courseGradeMax: props.filterValues.courseGradeMax,
courseId: props.courseId,
});
});
it('calls props.getUserGrades with selection', () => {
expect(props.getUserGrades).toHaveBeenCalledWith(
@@ -184,7 +184,7 @@ describe('CourseGradeFilter', () => {
describe('mapDispatchToProps', () => {
describe('updateFilter', () => {
test('from updateCourseGradeFilter', () => {
expect(mapDispatchToProps.updateFilter).toEqual(updateCourseGradeFilter);
expect(mapDispatchToProps.updateFilter).toEqual(actions.filters.update.courseGradeLimits);
});
});
describe('getUserGrades', () => {

View File

@@ -3,7 +3,7 @@
import React from 'react';
import { shallow } from 'enzyme';
import { fetchGrades } from 'data/actions/grades';
import { fetchGrades } from 'data/thunkActions/grades';
import {
StudentGroupsFilter,
mapStateToProps,

View File

@@ -1,7 +1,7 @@
import React from 'react';
import { shallow } from 'enzyme';
import { updateIncludeCourseRoleMembers } from 'data/actions/filters';
import actions from 'data/actions';
import {
GradebookFilters,
@@ -98,7 +98,7 @@ describe('GradebookFilters', () => {
describe('mapDispatchToProps', () => {
test('updateIncludeCourseRoleMembers', () => {
expect(mapDispatchToProps.updateIncludeCourseRoleMembers).toEqual(
updateIncludeCourseRoleMembers,
actions.filters.update.includeCourseRoleMembers,
);
});
});

View File

@@ -4,7 +4,7 @@ import { shallow } from 'enzyme';
import {
fetchGrades,
fetchMatchingUserGrades,
} from '../../data/actions/grades';
} from '../../data/thunkActions/grades';
import { mapDispatchToProps, mapStateToProps, SearchControls } from './SearchControls';
jest.mock('@edx/paragon', () => ({

View File

@@ -7,7 +7,7 @@ import {
maxCourseGradeInvalidMessage,
minCourseGradeInvalidMessage,
} from './StatusAlerts';
import { closeBanner } from '../../data/actions/grades';
import actions from 'data/actions';
jest.mock('@edx/paragon', () => ({
StatusAlert: 'StatusAlert',
@@ -92,7 +92,7 @@ describe('StatusAlerts', () => {
expect(
mapDispatchToProps.handleCloseSuccessBanner,
).toEqual(
closeBanner,
actions.grades.banner.close,
);
});
});

View File

@@ -682,7 +682,7 @@ describe('grades thunkActions', () => {
);
const { csvUpload, uploadOverride } = actions.grades;
describe('valid data', () => {
it('sends csvUpload finished and uploadOverride success actions', () => {
it('sends csvUpload finished and uploadOverride success actions', () => {
testFetch(
(resolve) => resolve(),
[