Andal.LND/frontend-app-gradebook
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use SITE_NAME env var for index.html title (#178)

Browse Source 
We currently have a hard-coded “edX” string in Gradebook’s index.html file.  This replaces that string with the value of the SITE_NAME environment variable, which is set at build time from .env.development for dev, and from the build process at production build-time.
This commit is contained in:
David Joy
2021-05-04 13:40:08 -04:00
committed by GitHub
parent 61fdb31316
commit 4fdc541992
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.env
View File

@@ -13,7 +13,7 @@ ACCESS_TOKEN_COOKIE_NAME=null,
CSRF_COOKIE_NAME='csrftoken', CSRF_COOKIE_NAME='csrftoken',
NEW_RELIC_APP_ID=null, NEW_RELIC_APP_ID=null,
NEW_RELIC_LICENSE_KEY=null, NEW_RELIC_LICENSE_KEY=null,
SITE_NAME=null, SITE_NAME='',
MARKETING_SITE_BASE_URL=null, MARKETING_SITE_BASE_URL=null,
SUPPORT_URL=null, SUPPORT_URL=null,
CONTACT_URL=null, CONTACT_URL=null,

2
.env.development
View File

@@ -13,7 +13,7 @@ CSRF_TOKEN_API_PATH='/csrf/api/v1/token'
REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh' REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
ACCESS_TOKEN_COOKIE_NAME='edx-jwt-cookie-header-payload' ACCESS_TOKEN_COOKIE_NAME='edx-jwt-cookie-header-payload'
USER_INFO_COOKIE_NAME='edx-user-info' USER_INFO_COOKIE_NAME='edx-user-info'
SITE_NAME='edX' SITE_NAME=localhost
DATA_API_BASE_URL='http://localhost:8000' DATA_API_BASE_URL='http://localhost:8000'
// LMS_CLIENT_ID should match the lms DOT client application id your LMS containe // LMS_CLIENT_ID should match the lms DOT client application id your LMS containe

4
public/index.html
View File

@@ -1,9 +1,9 @@
<!doctype html> <!doctype html>
<html lang="en-us"> <html lang="en-us">
<head> <head>
<title>Gradebook | edX</title> <title>Gradebook | <%= process.env.SITE_NAME %></title>
<meta charset="utf-8"> <meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0"> <meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="shortcut icon" href="<%=htmlWebpackPlugin.options.FAVICON_URL%>" type="image/x-icon" /> <link rel="shortcut icon" href="<%=htmlWebpackPlugin.options.FAVICON_URL%>" type="image/x-icon" />
</head> </head>
<body> <body>