From 4fdc541992725662cfd26f537bb5de826c3032a2 Mon Sep 17 00:00:00 2001 From: David Joy Date: Tue, 4 May 2021 13:40:08 -0400 Subject: [PATCH] fix: use SITE_NAME env var for index.html title (#178) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We currently have a hard-coded “edX” string in Gradebook’s index.html file. This replaces that string with the value of the SITE_NAME environment variable, which is set at build time from .env.development for dev, and from the build process at production build-time. --- .env | 2 +- .env.development | 2 +- public/index.html | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.env b/.env index dd8f92b..9ea5a9a 100644 --- a/.env +++ b/.env @@ -13,7 +13,7 @@ ACCESS_TOKEN_COOKIE_NAME=null, CSRF_COOKIE_NAME='csrftoken', NEW_RELIC_APP_ID=null, NEW_RELIC_LICENSE_KEY=null, -SITE_NAME=null, +SITE_NAME='', MARKETING_SITE_BASE_URL=null, SUPPORT_URL=null, CONTACT_URL=null, diff --git a/.env.development b/.env.development index af1c632..73f1316 100644 --- a/.env.development +++ b/.env.development @@ -13,7 +13,7 @@ CSRF_TOKEN_API_PATH='/csrf/api/v1/token' REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh' ACCESS_TOKEN_COOKIE_NAME='edx-jwt-cookie-header-payload' USER_INFO_COOKIE_NAME='edx-user-info' -SITE_NAME='edX' +SITE_NAME=localhost DATA_API_BASE_URL='http://localhost:8000' // LMS_CLIENT_ID should match the lms DOT client application id your LMS containe diff --git a/public/index.html b/public/index.html index cbf8b63..7040971 100755 --- a/public/index.html +++ b/public/index.html @@ -1,9 +1,9 @@ - Gradebook | edX + Gradebook | <%= process.env.SITE_NAME %> - +