Mohamed Akram 25e4e39953 fix: preformatted content being re-formatted (#376)
The issue had to do with how Firefox handles pasting newlines inside a <pre
contenteditable> tag (TinyMCE's editor works via contenteditable) and
fast-xml-parser's parsing. In Firefox, newlines are converted to <br> when
pasted, while Chrome preserves them. The parser by default trims spaces in text
nodes. In Firefox, the parser creates individual text nodes between the <br>
elements, and those have leading spaces in the example. In Chrome, there are no
<br> elements and the entire content is a single text node as-is. Setting
trimValues to false disables the trimming and resolves this issue in Firefox.

While investigating this, I noticed the builder also mishandles <br /> tags
emitted by the editor, converting them to <br></br>. The unpairedTags option in
the builder ensures they are output correctly as a single tag, and setting
suppressUnpairedNode to false ensures that single tag is <br/> rather than <br>
to remain XML compatible.

While trying to resolve this, I was looking into the paste plugin in TinyMCE.
It changes the behavior of pasting, making it more consistent between Chrome
and Firefox (i.e. both emit <br>) and is incorporated into TinyMCE 6 core.
Unfortunately, it seems to mangle pasting inside a <pre> tag by inserting
redundant nbsp characters (tinymce/tinymce#9017). TinyMCE 6 also outputs <br>
rather than <br /> - adding unpairedTags to the parser options is meant to
handle this, but it does not seem to behave entirely correct
(NaturalIntelligence/fast-xml-parser#609). These should be kept in mind if/when
upgrading to TinyMCE 6 (the different behaviors can be seen easily at
https://fiddle.tiny.cloud).
2023-09-11 10:47:04 -04:00
2023-07-20 14:52:21 -04:00
2022-03-30 15:13:19 -04:00
2021-11-19 14:28:50 -05:00

frontend-lib-content-components

A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.

How to set up development workflow of V2 content Editors in Studio and course Authoring MFE.

This guide presumes you have a functioning devstack.

  1. Enable Studio to use an editor for your xblock using waffle flags
    1. Add the string name of your editor e.g. html to the flag check in the edx-platform repo.
    2. In devstack + venv, run $ make dev.provision.lms+studio+frontend-app-course-authoring to make up the required services. Minimum services required are lms, studio and frontend-app-course-authoring.
    3. In Studio Django Admin turn on new_core_editors.use_new_text_editor flag for HTML editor, new_core_editors.use_new_video_editor flag for new video editor, and new_core_editors.use_new_problem_editor flag for problems. The list of supported flags is in toggles.py. . you might have to add a flag for your xblock of choice.
  2. Clone this repo into the ${DEVSTACK_WORKSPACE}/src directory the sibling repo of your edx devstack /src.
  3. In the course authoring app, follow the guide to use your local verison of frontend-lib-content-components. The module.config.js in the frontend-app-course-authoring repo will be:
    module.exports = {
    /*
    Modules you want to use from local source code.  Adding a module here means that when this app
    runs its build, it'll resolve the source from peer directories of this app.

    moduleName: the name you use to import code from the module.
    dir: The relative path to the module's source code.
    dist: The sub-directory of the source code where it puts its build artifact.  Often "dist".

    To use a module config:

    1. Copy module.config.js.example and remove the '.example' extension
    2. Uncomment modules below in the localModules array to load them from local source code.
    3. Remember to re-build the production builds of those local modules if they have one.
        See note below.
    */
    localModules: [
        /*********************************************************************************************
        IMPORTANT NOTE: If any of the below packages (like paragon or frontend-platform) have a build
        step that populates their 'dist' directories, you must manually run that step.  For paragon
        and frontend-platform, for instance, you need to run `npm run build` in the repo before
        module.config.js will work.
        **********************************************************************************************/

        // { moduleName: '@edx/brand', dir: '../brand-openedx' }, // replace with your brand checkout
        // { moduleName: '@edx/paragon/scss/core', dir: '../paragon', dist: 'scss/core' },
        // { moduleName: '@edx/paragon/icons', dir: '../paragon', dist: 'icons' },
        // { moduleName: '@edx/paragon', dir: '../paragon', dist: 'dist' },
        // { moduleName: '@edx/frontend-platform', dir: '../frontend-platform', dist: 'dist' },
        // NOTE: This is the relative path of the frontend-lib-content-components in the frontend-app-course-authoring container.
        { moduleName: '@edx/frontend-lib-content-components', dir: '../src/frontend-lib-content-components', dist: 'dist' },
    ],
    };

  1. Open a terminal

    1. cd ${DEVSTACK_WORKSPACE}/src/frontend-lib-content-components
    2. run $ npm install
    3. run $ make build when you want to see your changes.
  2. In devstack run make studio-static followed by $ make dev.down.frontend-app-course-authoring and $ make dev.up.frontend-app-course-authoring.

  3. Go to studio and edit a course or add the Xblock with the developing editor, it should redirect to frontend-app-course-authoring MFE and the editor should load.

Using the gallery view.

The gallery view runs the editor components with mocked-out block data, and sometimes does not replicate all desired behaviors, but can be used for faster iteration on UI-related changes. To run the gallery view, from the root directory, run

$ cd www $ npm start

and now the gallery will be live at http://localhost:8080/index.html. use the toggle at the top to switch between available editors.

Creating Xblock Editor

To develop a custom Xblock editor, run the command:

$ npm run-script addXblock <name of xblock>

from the frontend-lib-content-components source directory. It will create an editor you can then view at src/editors/containers. It will also configure the editor to be viewable in the gallery view. Adding the editor to be used in studio will require the following steps:

  1. Adding a flag in toggles.py
  2. Activating the Flag in Studio Django Admin.
  3. Add the function in studio_xblock_wrapper.html
  4. Make appropriate changes in container.js in the edx-platform repo.
  5. Activate the flag.
  6. Follow steps 4 to 6 from above

Installing into a project

  • npm install @edx/frontend-lib-content-components
  • For the Jest tests to work, a few config options are necessary. In jest.config.js, include:
  moduleNameMapper: {
    '^lodash-es$': 'lodash',
  },
  • Some mocks for test setup are also necessary, specifically replacing window.matchMedia.
  • To make this easier, we provide example files for jest.config.js and setupTest.js that are known to work. You can find them in the example/ folder.
Description
No description provided
Readme AGPL-3.0 88 MiB
Languages
TypeScript 56.6%
JavaScript 42%
SCSS 1.4%