Andal.LND/frontend-app-authoring
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Andal LND - Remove footer slots from course authoring pages, custom branding #1

Closed
Andalsoftware wants to merge 1 commits from andal-lnd/front-end into master
pull from: andal-lnd/front-end
merge into: Andal.LND:master
Conversation 2 Commits 1 Files Changed 10 +174 -236
Andalsoftware commented 2026-03-31 13:43:18 +07:00
Owner
Copy Link

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be linked here.

Useful information to include:

  • Which user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).

Supporting information

Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for manually testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'
## Description Describe what this pull request changes, and why. Include implications for people using this change. Design decisions and their rationales should be documented in the repo (docstring / ADR), per [OEP-19](https://open-edx-proposals.readthedocs.io/en/latest/oep-0019-bp-developer-documentation.html), and can be linked here. Useful information to include: - Which user roles will this change impact? Common user roles are "Learner", "Course Author", "Developer", and "Operator". - Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable). ## Supporting information Link to other information about the change, such as GitHub issues, or Discourse discussions. Be sure to check they are publicly readable, or if not, repeat the information here. ## Testing instructions Please provide detailed step-by-step instructions for manually testing this change. ## Other information Include anything else that will help reviewers and consumers understand the change. - Does this change depend on other changes elsewhere? - Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility. ## Best Practices Checklist We're trying to move away from some deprecated patterns in this codebase. Please check if your PR meets these recommendations before asking for a review: - [ ] Any _new_ files are using TypeScript (`.ts`, `.tsx`). - [ ] Avoid `propTypes` and `defaultProps` in any new or modified code. - [ ] Tests should use the helpers in `src/testUtils.tsx` (specifically `initializeMocks`) - [ ] Do not add new fields to the Redux state/store. Use React Context to share state among multiple components. - [ ] Use React Query to load data from REST APIs. See any `apiHooks.ts` in this repo for examples. - [ ] All new i18n messages in `messages.ts` files have a `description` for translators to use. - [ ] Avoid using `../` in import paths. To import from parent folders, use `@src`, e.g. `import { initializeMocks } from '@src/testUtils';` instead of `from '../../../../testUtils'`
Andalsoftware added 1 commit 2026-03-31 13:43:18 +07:00
Andal LND - Remove footer slots from course authoring pages, custom branding
Some checks failed
Lint Commit Messages / commitlint (pull_request) Has been cancelled
Details
Lockfile Version check / version-check (pull_request) Has been cancelled
Details
validate / tests (pull_request) Has been cancelled
Details
validate / coverage (pull_request) Has been cancelled
Details
c0b07f06af
Andalsoftware requested review from Damar 2026-03-31 13:43:18 +07:00
Andalsoftware requested review from rafli 2026-03-31 13:43:19 +07:00
Andalsoftware requested review from tauficls 2026-03-31 13:43:19 +07:00
Damar approved these changes 2026-03-31 13:57:51 +07:00
tauficls approved these changes 2026-03-31 14:00:21 +07:00
Andalsoftware closed this pull request 2026-03-31 14:00:31 +07:00
Some checks failed
Lint Commit Messages / commitlint (pull_request) Has been cancelled
Details
Lockfile Version check / version-check (pull_request) Has been cancelled
Details
validate / tests (pull_request) Has been cancelled
Details
validate / coverage (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
rafli
Damar
tauficls
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Andalsoftware Banu Damar rafli richard tauficls
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Andal.LND/frontend-app-authoring#1
Delete Branch "andal-lnd/front-end"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?