bszabo
0edee6b4e0
Merge pull request #57 from edx/TNL-9804-make-small-code-stewardship-changes-to-frontend-lib-content-components
...
Tnl 9804 make small code stewardship changes to frontend lib content components
2022-04-11 18:12:19 -04:00
Bernard Szabo
0d60cd97a0
refactor: Fix footer aria descriptions
...
'screensaver' in Aria description messages changed to 'screen reader'
2022-04-11 16:33:19 -04:00
Raymond Zhou
553e4d8c04
fix: editor has double scrollbars ( #59 )
2022-04-11 12:26:39 -04:00
Bernard Szabo
48fcfb0e00
refactor: Preserve button default messages
...
description for aria labels may explicitly reference intended screensaver use, but label names and ids should remain unchanged
2022-04-08 16:55:14 -04:00
connorhaugh
33b2c6a660
feat: image context toolbar ( #55 )
...
Note: this removes the crop and rotate functionality from the toolbar, as it requires an image_proxy server or tinymce cloud. https://www.tiny.cloud/docs-4x/plugins/imagetools/#imagetools_proxy . We also need to create a follow up ticket to handle right click behavior.
This is that follow up ticket
2022-04-08 13:23:42 -04:00
Raymond Zhou
ef6ea6b617
fix: saving block title ( #50 )
...
* fix: saving block title
* fix: ben's suggestions
2022-04-08 12:45:49 -04:00
Bernard Szabo
d79ee29b96
refactor: consistent naming and default message for saveButton label
...
Prior to this change Aria message and default message were different
2022-04-07 16:12:13 -04:00
Bernard Szabo
26c0c78660
refactor: use consistent ordering for header/footer attributes
2022-04-07 16:12:13 -04:00
kenclary
bc3ef37dcf
Merge pull request #53 from edx/kenclary/TNL-9832
...
fix: remove spurious hard-coded height for img-settings-form-container class. Fixes TNL-9832.
2022-04-07 15:49:06 -04:00
Ken Clary
e3236e9d95
fix: remove spurious hard-coded height for img-settings-form-container class. Fixes TNL-9832.
2022-04-07 15:44:47 -04:00
connorhaugh
c817e17d8a
fix: update texteditor spacing ( #49 )
...
footer is now locked to bottom of page, and that text editor content scrolls, and that this works on resize of page.
2022-04-07 14:49:15 -04:00
Raymond Zhou
8104aa3152
fix: load block title ( #51 )
2022-04-07 12:47:35 -04:00
connorhaugh
c3d9109211
fix: remove merge artifiact ( #48 )
...
For repo health
2022-04-06 10:50:08 -04:00
Raymond Zhou
45758612a4
feat: empty gallery ( #46 )
...
Adds a new option to the behavior for when the gallery has no images in it.
2022-04-05 11:43:40 -04:00
connorhaugh
049b6a9211
Fix: release ci ( #47 )
...
* feat: add capabilities
* chore: more tests
* fix: use correct hook source for getDispatch
* fix: fix fetchImages data contract
* fix: make onClose method a callback for ImageUploadModal
* chore: lint and test updates
* chore: clean up propType warning
* fix: upload of file
* fix: error notifcations
* fix: improve test coverage
* fix: lint fixes
* fix: lint fix
* rebase: stept 1
* rebase: step 2
* fix: use correct hook source for getDispatch
* rebase: step 3
* rebase: step 4
* chore: clean up propType warning
* fix: upload of file
* rebase: step 5
* fix: improve test coverage
* fix: lint fixes
* fix: release CI
Co-authored-by: Ben Warzeski <bwarzeski@edx.org >
2022-04-04 09:17:34 -04:00
connorhaugh
fd35c1cb18
Feat: Add Request Alerts and upload file ( #43 )
...
Fixes to Upload data type, as well as adding in of two error alerts for upload and fetch.
Co-authored-by: Ben Warzeski <bwarzeski@edx.org >
Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com
2022-04-04 08:33:31 -04:00
Raymond Zhou
28516a0389
fix: text editor save ( #45 )
...
* fix: text editor save
* fix: update snapshot
2022-04-01 17:01:12 -04:00
Raymond Zhou
dca18b9b97
chore: i18n complete ( #37 )
...
* chore: i18n
2022-03-31 16:14:29 -04:00
Ben Warzeski
0f87a61639
feat: Select img api ( #41 )
...
* feat: add capabilities
* chore: more tests
* fix: use correct hook source for getDispatch
* fix: fix fetchImages data contract
* fix: make onClose method a callback for ImageUploadModal
* chore: lint and test updates
* chore: clean up propType warning
Co-authored-by: connorhaugh <chaugh21@amherst.edu >
2022-03-30 15:13:19 -04:00
Ben Warzeski
1a5497a5ae
Feat select image modal ( #38 )
...
* feat: select image modal
* chore: fix module config
2022-03-24 16:16:38 -04:00
Ben Warzeski
09e9d865c2
Chore: Test coverage hunt ( #36 )
...
* chore: add brand mocking in gallery view
* feat: dev gallery app
* chore: link mock block ids to real block type api
* feat: image settings page features
* chore: more tests
* chore: keystore util and more testing
* chore: more tests
* chore: re-install lint plugin...
* chore: lint fixes
* chore: moar tests
* chore: remove brand from module.config and link gallery to edx.org brand
2022-03-24 11:15:32 -04:00
Ben Warzeski
284601d6d2
feat: image dimension lock logic update ( #34 )
2022-03-22 10:03:26 -04:00
Ben Warzeski
3b8a7780ac
I18n example ( #33 )
...
* feat: i18n pt 1
* fix: prevent float calculations when updating dimensions
2022-03-17 14:08:46 -04:00
Ben Warzeski
a79da4cb2d
feat: useState test util ( #31 )
2022-03-16 11:27:08 -04:00
Jawayria
9e84e0ecf0
fix: update dependencies ( #32 )
...
* fix: update dependencies
Co-authored-by: M Umar Khan <umar.khan@arbisoft.com >
2022-03-16 09:45:35 -04:00
Ben Warzeski
32e4d5f7a1
feat: Image settings feature and design completeness ( #30 )
...
* feat: devgallery api mode
* feat: dev gallery app
* chore: link mock block ids to real block type api
* feat: image settings page features
* fix: update tests
* fix: console message cleanup
* fix: test fixes from code walkthrough with ray
2022-03-15 16:32:07 -04:00
connorhaugh
4ae2d1230b
feat: insert images into text editor html ( #29 )
...
This work adds the functionality that when an image is selected ineither the select image step of the image upload modal, or by using the toolbar inside tinymce, the requisite image is loaded into the settings page, and on the click of the save button, it is inserted into tinymce html.
2022-03-15 10:53:56 -04:00
connorhaugh
5258e93972
Test add requests redux tests ( #24 )
...
Add redux tests as well as get save functionality working.
2022-03-07 19:43:46 -05:00
connorhaugh
c4cd0c44ce
test: update editor-level tests ( #26 )
...
To complete https://openedx.atlassian.net/browse/TNL-9601
2022-03-07 15:03:13 -05:00
Ben Warzeski
ac0d261e89
Gallery app ( #27 )
...
* feat: devgallery api mode
* chore: update react version
* feat: dev gallery app
* chore: fix component tests
* chore: lint fixes
* chore: link mock block ids to real block type api
2022-03-07 13:35:28 -05:00
Raymond Zhou
6f0f6296e4
test: cms api tests + extra lint ( #25 )
2022-03-01 11:32:03 -05:00
Ben Warzeski
9c9d3c8fdf
feat: image upload skeleton ( #22 )
2022-03-01 11:17:03 -05:00
Raymond Zhou
f3d80995c5
test: cms urls ( #23 )
2022-02-25 19:24:05 -05:00
connorhaugh
7ccba63a85
test: add TextEditor Tests ( #21 )
2022-02-25 15:06:12 -05:00
Raymond Zhou
042246be86
Test: editor header component ( #20 )
...
* test: header tests start
* test: EditableHeader test ready for review 1
* test: editor header tests complete
* test: fixing up nits
* test: ben's corrections
2022-02-25 12:15:13 -05:00
Ben Warzeski
1a1900f213
feat: redux tests pt 1 ( #19 )
...
* feat: redux tests pt 1
* chore: add app thunkAction tests
* chore: resolve lint issues
* Update src/editors/data/redux/app/reducer.test.js
Co-authored-by: connorhaugh <49422820+connorhaugh@users.noreply.github.com >
Co-authored-by: connorhaugh <49422820+connorhaugh@users.noreply.github.com >
2022-02-24 16:59:30 -05:00
Ben Warzeski
2b0346fe84
chore: add tests for EditorHeader hooks ( #18 )
2022-02-23 11:55:53 -05:00
connorhaugh
6ca93a7297
test: add EditorFooter tests ( #16 )
...
* test: add EditorFooter tests
2022-02-22 13:24:15 -05:00
Ben Warzeski
d2e89d7b28
chore: rename lms service to cms ( #15 )
...
* chore: rename lms service to cms
* fix: remove typo
* fix: remove old selector
2022-02-22 12:59:37 -05:00
Ben Warzeski
362139edd2
feat: mock paragon and i18n library for tests
2022-02-22 12:45:30 -05:00
Ben Warzeski
5a1d71a62c
!refactor: Breaking Change refactor use Redux. No release
2022-02-18 13:16:36 -05:00
connorhaugh
eef30348fd
feat: add plugins including image-upload ( #12 )
...
This adds the image upload "plugin" and all the desired built-in plugins.
Per the following two tickets
https://openedx.atlassian.net/browse/TNL-9367
https://openedx.atlassian.net/browse/TNL-9475
I need to add the requisite plugins, as well as a framework for the image upload modal.
2022-02-14 12:33:49 -05:00
connorhaugh
2f931b5bdb
fix: dont encode with uri twice ( #10 )
2022-01-27 12:39:19 -05:00
connorhaugh
d8c6b8dddd
feat: Text Editor and V2 Editor Framework ( #9 )
...
Text Editor and V2 Editor Framework. Documentation to come.
2022-01-25 14:04:57 -05:00
kenclary
c93c5e986a
Merge pull request #8 from edx/kenclary/release-fix
...
fix: correct project links in package.json
2021-12-15 11:34:36 -05:00
Ken Clary
bb7360ac93
fix: correct project links in package.json
2021-12-15 11:31:46 -05:00
kenclary
f7935deea0
Merge pull request #7 from edx/kenclary/release-fix
...
fix: correct(?) configuration of main branch for semantic-release.
2021-12-15 11:01:48 -05:00
Ken Clary
b98fe329af
fix: correct(?) configuration of main branch for semantic-release.
2021-12-15 10:52:22 -05:00
kenclary
2bd75952f0
Merge pull request #6 from edx/kenclary/security
...
fix: update dependencies for security.
2021-12-14 17:22:23 -05:00
Ken Clary
f44017e5f4
fix: update dependencies for security.
2021-12-14 17:12:22 -05:00