fix: editor container can scroll again (#435)

This is a fix to a problem where some css prevented the editors from scrolling.
This commit is contained in:
Jesper Hodge
2023-12-14 11:53:26 -05:00
committed by GitHub
parent 4483214de1
commit fbd3d8506f
5 changed files with 10 additions and 29 deletions

View File

@@ -33,14 +33,6 @@ export const Editor = ({
return (
<div
className="d-flex flex-column"
style={{
/* Positioned as a proper Paragon FullscreenModal should have been. */
position: 'fixed',
top: 0,
left: 0,
right: 0,
height: '100%',
}}
>
<div
className="pgn__modal-fullscreen h-100"

View File

@@ -3,15 +3,6 @@
exports[`Editor render presents error message if no relevant editor found and ref ready 1`] = `
<div
className="d-flex flex-column"
style={
Object {
"height": "100%",
"left": 0,
"position": "fixed",
"right": 0,
"top": 0,
}
}
>
<div
aria-label="fAkEBlock"
@@ -30,15 +21,6 @@ exports[`Editor render presents error message if no relevant editor found and re
exports[`Editor render snapshot: renders correct editor given blockType (html -> TextEditor) 1`] = `
<div
className="d-flex flex-column"
style={
Object {
"height": "100%",
"left": 0,
"position": "fixed",
"right": 0,
"top": 0,
}
}
>
<div
aria-label="html"

View File

@@ -2,7 +2,7 @@
exports[`EditorContainer component render snapshot: initialized. enable save and pass to header 1`] = `
<div
className="d-flex flex-column position-relative zindex-0"
className="editor-container d-flex flex-column position-relative zindex-0"
style={
Object {
"minHeight": "100%",
@@ -83,7 +83,7 @@ exports[`EditorContainer component render snapshot: initialized. enable save and
exports[`EditorContainer component render snapshot: not initialized. disable save and pass to header 1`] = `
<div
className="d-flex flex-column position-relative zindex-0"
className="editor-container d-flex flex-column position-relative zindex-0"
style={
Object {
"minHeight": "100%",

View File

@@ -13,6 +13,7 @@ import EditorFooter from './components/EditorFooter';
import TitleHeader from './components/TitleHeader';
import * as hooks from './hooks';
import messages from './messages';
import './index.scss';
export const EditorContainer = ({
children,
@@ -29,7 +30,7 @@ export const EditorContainer = ({
const handleCancel = hooks.handleCancel({ onClose, returnFunction });
return (
<div
className="d-flex flex-column position-relative zindex-0"
className="editor-container d-flex flex-column position-relative zindex-0"
style={{ minHeight: '100%' }}
>
<BaseModal

View File

@@ -0,0 +1,6 @@
// fix double scrollbars
.editor-container {
.pgn__modal-body {
overflow: visible;
}
}