Andal.LND/frontend-app-authoring
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add error messages for minimum validation

Browse Source
This commit is contained in:
Kshitij Sobti
2021-09-15 16:08:39 +05:30
committed by Awais Jibran
parent fde08bac4c
commit e6d6609bc2
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pages-and-resources/teams/Settings.jsx
View File

@@ -61,7 +61,7 @@ function TeamSettings({
validationSchema={{
maxTeamSize: Yup.number()
.required(intl.formatMessage(messages.maxTeamSizeEmpty))
.min(TeamSizes.MIN)
.min(TeamSizes.MIN, intl.formatMessage(messages.maxTeamSizeInvalid))
.max(
TeamSizes.MAX,
intl.formatMessage(messages.maxTeamSizeTooHigh, {
@@ -79,8 +79,8 @@ function TeamSettings({
.required(intl.formatMessage(messages.teamSetFormDescriptionError))
.trim(),
maxTeamSize: Yup.number()
.required(intl.formatMessage(messages.maxTeamSizeEmpty))
.min(TeamSizes.MIN)
.nullable()
.min(TeamSizes.MIN, intl.formatMessage(messages.maxTeamSizeInvalid))
.max(
TeamSizes.MAX,
intl.formatMessage(messages.maxTeamSizeTooHigh, {

6
src/pages-and-resources/teams/messages.js
View File

@@ -30,9 +30,13 @@ const messages = defineMessages({
defaultMessage: 'The maximum number of learners that can join a team',
},
maxTeamSizeEmpty: {
id: 'authoring.pagesAndResources.teams.teamSize.maxTeamSizeInvalid',
id: 'authoring.pagesAndResources.teams.teamSize.maxTeamSizeEmpty',
defaultMessage: 'Enter max team size',
},
maxTeamSizeInvalid: {
id: 'authoring.pagesAndResources.teams.teamSize.maxTeamSizeInvalid',
defaultMessage: 'Max team size must be a positive number larger than zero.',
},
maxTeamSizeTooHigh: {
id: 'authoring.pagesAndResources.teams.teamSize.maxTeamSizeTooHigh',
defaultMessage: 'Max team size must less than {max}',