Andal.LND/frontend-app-authoring
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: update discussions API handler to match shape from server (#109)

Browse Source 
The application was expecting a different API shape than the server was sending.  I have _no_ idea how this made it through, as it’s blatantly broken.  I don’t see any changes in this code in the past few weeks.

Anyway, the client was expecting a “features” array inside an app (provider), which simply didn’t exist.  The app itself is the array.  This PR udpates the shape in `normalizeApps` and also the associated test, which was also equally as wrong.  Somehow.
This commit is contained in:
David Joy
2021-05-03 15:10:15 -04:00
committed by GitHub
parent c20fbbcf79
commit ce85197a33
2 changed files with 27 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pages-and-resources/discussions/data/api.js
View File

@@ -37,12 +37,12 @@ function normalizePluginConfig(data) {
}
function normalizeApps(data) {
const apps = Object.entries(data.providers.available).map(([key, app]) => ({
const apps = Object.entries(data.providers.available).map(([key, appFeatures]) => ({
id: key,
featureIds: app.features,
featureIds: appFeatures,
// TODO: Fix this and get it from the backend!
documentationUrl: 'http://example.com',
hasFullSupport: app.features.length >= data.features.length,
hasFullSupport: appFeatures.length >= data.features.length,
}));
return {
courseId: data.context_key,

56
src/pages-and-resources/discussions/factories/mockApiResponses.js
View File

@@ -18,22 +18,18 @@ export const piazzaApiResponse = {
providers: {
active: 'piazza',
available: {
legacy: {
features: [
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
],
},
piazza: {
features: [
// We give piazza all features just so we can test our "full support" text.
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
'lti',
],
},
legacy: [
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
],
piazza: [
// We give piazza all features just so we can test our "full support" text.
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
'lti',
],
},
},
};
@@ -59,22 +55,18 @@ export const legacyApiResponse = {
providers: {
active: 'legacy',
available: {
legacy: {
features: [
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
],
},
piazza: {
features: [
// We give piazza all features just so we can test our "full support" text.
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
'lti',
],
},
legacy: [
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
],
piazza: [
// We give piazza all features just so we can test our "full support" text.
'discussion-page',
'embedded-course-sections',
'wcag-2.1',
'lti',
],
},
},
};