Andal.LND/frontend-app-authoring
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: advanced editor not saving (#315)

Browse Source
This commit is contained in:
Kristin Aoki
2023-04-21 10:25:01 -04:00
committed by GitHub
parent 492ee27d8e
commit c37e6957f6
2 changed files with 23 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/editors/containers/ProblemEditor/components/EditProblemView/hooks.js
View File

@@ -126,7 +126,7 @@ export const getContent = ({
lmsEndpointUrl,
}) => {
const problem = problemState;
const hasNoAnswers = checkForNoAnswers({
const hasNoAnswers = isAdvancedProblemType ? false : checkForNoAnswers({
problem,
openNoAnswerModal,
});

30
src/editors/containers/ProblemEditor/components/EditProblemView/hooks.test.js
View File

@@ -190,17 +190,16 @@ describe('EditProblemView hooks parseState', () => {
});
});
describe('getContent', () => {
const problemState = { problemType: ProblemTypeKeys.NUMERIC, answers: [{ id: 'A', title: 'problem', correct: true }] };
const isAdvancedProblem = false;
const assets = {};
const lmsEndpointUrl = 'someUrl';
const editorRef = refMock;
const openNoAnswerModal = jest.fn();
test('default save and returns parseState data', () => {
test('default visual save and returns parseState data', () => {
const problemState = { problemType: ProblemTypeKeys.NUMERIC, answers: [{ id: 'A', title: 'problem', correct: true }] };
const content = hooks.getContent({
isAdvancedProblemType: false,
problemState,
isAdvancedProblem,
editorRef,
assets,
lmsEndpointUrl,
@@ -211,11 +210,26 @@ describe('EditProblemView hooks parseState', () => {
settings: undefined,
});
});
test('returns null', () => {
const problem = { ...problemState, answers: [{ id: 'A', title: '', correct: true }] };
test('default advanced save and returns parseState data', () => {
const problemState = { problemType: ProblemTypeKeys.ADVANCED };
const content = hooks.getContent({
problemState: problem,
isAdvancedProblem,
isAdvancedProblemType: true,
problemState,
editorRef,
assets,
lmsEndpointUrl,
openNoAnswerModal,
});
expect(content).toEqual({
olx: 'rawOLX',
settings: undefined,
});
});
test('returns null', () => {
const problemState = { problemType: ProblemTypeKeys.NUMERIC, answers: [{ id: 'A', title: '', correct: true }] };
const content = hooks.getContent({
isAdvancedProblemType: false,
problemState,
editorRef,
assets,
lmsEndpointUrl,