refactor: refactoring after review

This commit is contained in:
PKulkoRaccoonGang
2024-02-26 10:28:46 +02:00
committed by Adolfo R. Brandes
parent 6aff1c1168
commit 6b57ce3e53
5 changed files with 14 additions and 14 deletions

View File

@@ -29,7 +29,7 @@ const CourseUnit = ({ courseId }) => {
unitTitle,
isQueryPending,
savingStatus,
isEditTitleFormOpen,
isTitleEditFormOpen,
isErrorAlert,
isInternetConnectionAlertFailed,
handleTitleEditSubmit,
@@ -62,7 +62,7 @@ const CourseUnit = ({ courseId }) => {
title={(
<HeaderTitle
unitTitle={unitTitle}
isEditTitleFormOpen={isEditTitleFormOpen}
isTitleEditFormOpen={isTitleEditFormOpen}
handleTitleEdit={handleTitleEdit}
handleTitleEditSubmit={handleTitleEditSubmit}
/>

View File

@@ -8,7 +8,7 @@ const slice = createSlice({
initialState: {
savingStatus: '',
isQueryPending: false,
isEditTitleFormOpen: false,
isTitleEditFormOpen: false,
loadingStatus: {
fetchUnitLoadingStatus: RequestStatus.IN_PROGRESS,
courseSectionVerticalLoadingStatus: RequestStatus.IN_PROGRESS,
@@ -30,7 +30,7 @@ const slice = createSlice({
state.isQueryPending = payload;
},
changeEditTitleFormOpen: (state, { payload }) => {
state.isEditTitleFormOpen = payload;
state.isTitleEditFormOpen = payload;
},
updateSavingStatus: (state, { payload }) => {
state.savingStatus = payload.status;

View File

@@ -13,7 +13,7 @@ import messages from './messages';
const HeaderTitle = ({
unitTitle,
isEditTitleFormOpen,
isTitleEditFormOpen,
handleTitleEdit,
handleTitleEditSubmit,
}) => {
@@ -28,7 +28,7 @@ const HeaderTitle = ({
return (
<div className="d-flex align-items-center lead">
{isEditTitleFormOpen ? (
{isTitleEditFormOpen ? (
<Form.Group className="m-0">
<Form.Control
ref={(e) => e && e.focus()}
@@ -63,7 +63,7 @@ const HeaderTitle = ({
HeaderTitle.propTypes = {
unitTitle: PropTypes.string.isRequired,
isEditTitleFormOpen: PropTypes.bool.isRequired,
isTitleEditFormOpen: PropTypes.bool.isRequired,
handleTitleEdit: PropTypes.func.isRequired,
handleTitleEditSubmit: PropTypes.func.isRequired,
};

View File

@@ -9,7 +9,7 @@ import HeaderTitle from './HeaderTitle';
import messages from './messages';
const unitTitle = 'Getting Started';
const isEditTitleFormOpen = false;
const isTitleEditFormOpen = false;
const handleTitleEdit = jest.fn();
const handleTitleEditSubmit = jest.fn();
let store;
@@ -19,7 +19,7 @@ const renderComponent = (props) => render(
<IntlProvider locale="en">
<HeaderTitle
unitTitle={unitTitle}
isEditTitleFormOpen={isEditTitleFormOpen}
isTitleEditFormOpen={isTitleEditFormOpen}
handleTitleEdit={handleTitleEdit}
handleTitleEditSubmit={handleTitleEditSubmit}
{...props}
@@ -52,7 +52,7 @@ describe('<HeaderTitle />', () => {
it('render HeaderTitle with open edit form', () => {
const { getByRole } = renderComponent({
isEditTitleFormOpen: true,
isTitleEditFormOpen: true,
});
expect(getByRole('textbox', { name: messages.ariaLabelButtonEdit.defaultMessage })).toBeInTheDocument();
@@ -71,7 +71,7 @@ describe('<HeaderTitle />', () => {
it('calls saving title by clicking outside or press Enter key', async () => {
const { getByRole } = renderComponent({
isEditTitleFormOpen: true,
isTitleEditFormOpen: true,
});
const titleField = getByRole('textbox', { name: messages.ariaLabelButtonEdit.defaultMessage });

View File

@@ -29,7 +29,7 @@ export const useCourseUnit = ({ courseId, blockId }) => {
const loadingStatus = useSelector(getLoadingStatus);
const { draftPreviewLink, publishedPreviewLink } = useSelector(getCourseSectionVertical);
const navigate = useNavigate();
const isEditTitleFormOpen = useSelector(state => state.courseUnit.isEditTitleFormOpen);
const isTitleEditFormOpen = useSelector(state => state.courseUnit.isTitleEditFormOpen);
const isQueryPending = useSelector(state => state.courseUnit.isQueryPending);
const unitTitle = courseUnit.metadata?.displayName || '';
@@ -49,7 +49,7 @@ export const useCourseUnit = ({ courseId, blockId }) => {
};
const handleTitleEdit = () => {
dispatch(changeEditTitleFormOpen(!isEditTitleFormOpen));
dispatch(changeEditTitleFormOpen(!isTitleEditFormOpen));
};
const handleTitleEditSubmit = (displayName) => {
@@ -95,7 +95,7 @@ export const useCourseUnit = ({ courseId, blockId }) => {
isErrorAlert,
isLoading: loadingStatus.fetchUnitLoadingStatus === RequestStatus.IN_PROGRESS
|| loadingStatus.courseSectionVerticalLoadingStatus === RequestStatus.IN_PROGRESS,
isEditTitleFormOpen,
isTitleEditFormOpen,
isInternetConnectionAlertFailed: savingStatus === RequestStatus.FAILED,
handleInternetConnectionFailed,
headerNavigationsActions,