feat: remove general and group feedback (#273)

This commit is contained in:
Raymond Zhou
2023-03-13 09:25:38 -07:00
committed by GitHub
parent 2ea3efed4b
commit 56621ca575
2 changed files with 2 additions and 30 deletions

View File

@@ -23,11 +23,6 @@ exports[`SettingsWidget snapshot snapshot: renders Settings widget for Advanced
problemType="stringresponse"
/>
</div>
<div
className="mt-3"
>
<GroupFeedback />
</div>
<div>
<Advanced
open={false}
@@ -110,11 +105,6 @@ exports[`SettingsWidget snapshot snapshot: renders Settings widget page 1`] = `
problemType="stringresponse"
/>
</div>
<div
className="mt-3"
>
<GroupFeedback />
</div>
<div>
<Advanced
open={true}
@@ -197,11 +187,6 @@ exports[`SettingsWidget snapshot snapshot: renders Settings widget page advanced
problemType="stringresponse"
/>
</div>
<div
className="mt-3"
>
<GroupFeedback />
</div>
<div>
<Advanced
open={false}

View File

@@ -13,7 +13,6 @@ import ResetCard from './settingsComponents/ResetCard';
import MatlabCard from './settingsComponents/MatlabCard';
import TimerCard from './settingsComponents/TimerCard';
import TypeCard from './settingsComponents/TypeCard';
import GeneralFeedbackCard from './settingsComponents/GeneralFeedback/index';
import GroupFeedbackCard from './settingsComponents/GroupFeedback/index';
import SwitchToAdvancedEditorCard from './settingsComponents/SwitchToAdvancedEditorCard';
import messages from './messages';
@@ -28,7 +27,6 @@ export const SettingsWidget = ({
problemType,
// redux
answers,
generalFeedback,
groupFeedbackList,
blockTitle,
correctAnswerCount,
@@ -41,10 +39,7 @@ export const SettingsWidget = ({
const { isAdvancedCardsVisible, showAdvancedCards } = showAdvancedSettingsCards();
const feedbackCard = () => {
if (problemType === ProblemTypeKeys.ADVANCED) {
return (<></>);
}
if ([ProblemTypeKeys.MULTISELECT, ProblemTypeKeys.TEXTINPUT, ProblemTypeKeys.NUMERIC].includes(problemType)) {
if ([ProblemTypeKeys.MULTISELECT].includes(problemType)) {
return (
<div className="mt-3"><GroupFeedbackCard
groupFeedbacks={groupFeedbackList}
@@ -54,13 +49,7 @@ export const SettingsWidget = ({
</div>
);
}
return (
<div className="mt-3"><GeneralFeedbackCard
generalFeedback={generalFeedback}
updateSettings={updateField}
/>
</div>
);
return (<></>);
};
return (
@@ -144,7 +133,6 @@ SettingsWidget.propTypes = {
title: PropTypes.string,
unselectedFeedback: PropTypes.string,
})).isRequired,
generalFeedback: PropTypes.string.isRequired,
groupFeedbackList: PropTypes.arrayOf(
PropTypes.shape(
{
@@ -166,7 +154,6 @@ SettingsWidget.propTypes = {
};
const mapStateToProps = (state) => ({
generalFeedback: selectors.problem.generalFeedback(state),
groupFeedbackList: selectors.problem.groupFeedbackList(state),
settings: selectors.problem.settings(state),
answers: selectors.problem.answers(state),