Andal.LND/frontend-app-authoring
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove useEffect that fires before search params (#465)

Browse Source 
* fix: remove useEffect that fires before search params

* fix: remove disable lint lines
This commit is contained in:
Kristin Aoki
2024-03-18 15:31:00 -04:00
committed by GitHub
parent 85ca350591
commit 4fa169556e
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/editors/containers/VideoEditor/components/VideoEditorModal.jsx
View File

@@ -5,7 +5,6 @@ import * as appHooks from '../../../hooks';
import { thunkActions, selectors } from '../../../data/redux';
import VideoSettingsModal from './VideoSettingsModal';
// import SelectVideoModal from './SelectVideoModal';
import * as module from './VideoEditorModal';
export const {
navigateTo,
@@ -13,15 +12,10 @@ export const {
export const hooks = {
initialize: (dispatch, selectedVideoId, selectedVideoUrl) => {
// eslint-disable-next-line react-hooks/rules-of-hooks
React.useEffect(() => {
dispatch(thunkActions.video.loadVideoData(selectedVideoId, selectedVideoUrl));
}, []);
dispatch(thunkActions.video.loadVideoData(selectedVideoId, selectedVideoUrl));
},
returnToGallery: () => {
// eslint-disable-next-line react-hooks/rules-of-hooks
useReturnToGallery: () => {
const learningContextId = useSelector(selectors.app.learningContextId);
// eslint-disable-next-line react-hooks/rules-of-hooks
const blockId = useSelector(selectors.app.blockId);
return () => (navigateTo(`/course/${learningContextId}/editor/course-videos/${blockId}`));
},
@@ -36,8 +30,8 @@ const VideoEditorModal = ({
const searchParams = new URLSearchParams(document.location.search);
const selectedVideoId = searchParams.get('selectedVideoId');
const selectedVideoUrl = searchParams.get('selectedVideoUrl');
const onReturn = module.hooks.returnToGallery();
module.hooks.initialize(dispatch, selectedVideoId, selectedVideoUrl);
const onReturn = hooks.useReturnToGallery();
hooks.initialize(dispatch, selectedVideoId, selectedVideoUrl);
return (
<VideoSettingsModal {...{
close,