Andal.LND/frontend-app-authoring
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: don't use eval() to parse OLX (#2848)

Browse Source
This commit is contained in:
Braden MacDonald
2026-01-29 07:39:48 -08:00
committed by GitHub
parent 9d9d7a7167
commit 27e709912d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/editors/containers/ProblemEditor/data/OLXParser.js
View File

@@ -257,7 +257,7 @@ export class OLXParser {
if (isComplexAnswer && preservedAnswer) {
title = this.richTextBuilder.build(preservedAnswer);
}
const correct = eval(element['@_correct'].toLowerCase());
const correct = element['@_correct'].toLowerCase() === 'true';
const id = indexToLetterMap[index];
const feedback = this.getAnswerFeedback(preservedFeedback, `${option}hint`);
answers.push(
@@ -279,7 +279,7 @@ export class OLXParser {
}
const feedback = this.getAnswerFeedback(preservedFeedback, `${option}hint`);
answers.push({
correct: eval(choice['@_correct'].toLowerCase()),
correct: choice['@_correct'].toLowerCase() === 'true',
id: indexToLetterMap[answers.length],
title,
...feedback,